Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

Hi, AFAIK, anyone can switch from Simple User to Advanced User, so I don't think it's a good idea to completely prevent someone (by showing an error) from performing an action just because its user type is not the right one. For me, the best solution would be to show a warning to both simple and advanced users when they try to move/rename pages with xclass. WDYT?

Thanks, Adel On Mon, Sep 24, 2018 at 9:55 AM Simon Urli <simon.urli(a)xwiki.com> wrote: > > Hi all, > > On 9/24/18 9:00 AM, Clément Aubin wrote: >> Hi, >> >> On 09/23/2018 10:12 AM, Vincent Massol wrote: >>> Hi Simon, >>> >>>> On 21 Sep 2018, at 16:58, Simon Urli <simon.urli(a)xwiki.com> wrote: >>>> >>>> >>>> >>>> On 9/21/18 4:53 PM, Adel Atallah wrote: >>>>> +1 for the warning, but I would not forbid simple users from renaming >>>>> or moving pages but instead just hide the action (from the page menu). >>>> >>>> OK I should have written it: by "forbid" I meant: >>>> >>>> 1. Hide the action from the menu >>>> 2. Return an error message if the user try to access the >> renaming/moving page (using forged URL) >> This isn't a realy good idea IMO as we could break extensions that >> redirect a user to the rename action of a page using things such as >> $xwiki.getURL(). > >> >> A good workaround would be to add the same warning as when editing >> extension pages [1]. > So you suggest to have the same behaviour for advanced and simple user > then? > > I'm not sure to understand in what way displaying an error to user > telling them they don't have enough privileges to do this action is > really breaking a behaviour here. > > Could you provide an example of a usecase with an extension you > mentioned please? Just for me to better see the issue. > > Thanks, > Simon >> >> Thanks, >> Clément >> >> [1] >> https://www.xwiki.org/xwiki/bin/view/Documentation/UserGuide/Features/PageE… >> >>>> >>>> So you suggest we shouldn't do 2? >>> >>> So +1 to prevent/warn the user when doing a move/renaming AND copy >> pages containing XClass definitions (the message should list all such >> pages). >>> >>> -1 to hide the action from the menu (if you’re talking about the >> “Move/Rename” and “Copy" actions) because: >>> 1) you get to choose whether you move/rename/copy children after you >> click the action >>> 2) even when the current page has an XClass, the user wouldn't >> understand why he cannot see/click on the action. It’s better that he >> can do it but get an error message, explaining why and telling him that >> to contact an advanced users if he really needs to do it. >>> >>> Thanks >>> -Vincent >>> >>>> >>>>> On Fri, Sep 21, 2018 at 4:44 PM Simon Urli <simon.urli(a)xwiki.com> wrote: >>>>>> >>>>>> Hi all, >>>>>> >>>>>> users might currently break their AWM application by renaming/moving >>>>>> pages containing XClass definition. >>>>>> >>>>>> We need a proper refactoring operation to be able to properly do such >>>>>> move/rename. But this feature might take a while to be completely >>>>>> available. >>>>>> >>>>>> In the meantime I propose that we prevent users from renaming/moving >>>>>> pages containing XClass. >>>>>> >>>>>> What I propose is the following: >>>>>> - Forbid completely *simple users* to rename/move pages >> containing XClass >>>>>> - Display a warning to *advanced users* when they perform such >>>>>> operation: the same kind of warning we already have when performing >> edit >>>>>> on XWiki pages >>>>>> >>>>>> WDYT? >>>>>> >>>>>> Simon >>>>>> >>>>>> -- >>>>>> Simon Urli >>>>>> Software Engineer at XWiki SAS >>>>>> simon.urli(a)xwiki.com >>>>>> More about us at http://www.xwiki.com >>>> >>>> -- >>>> Simon Urli >>>> Software Engineer at XWiki SAS >>>> simon.urli(a)xwiki.com >>>> More about us at http://www.xwiki.com >>> > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.urli(a)xwiki.com > More about us at http://www.xwiki.com