Re: [xwiki-devs] New commons-repository module?

On Thu, Jun 28, 2012 at 3:05 PM, Vincent Massol <vincent(a)massol.net> wrote: You're trying to read it as a conjunction while it's used as a preposition. Though I agree the way it's written makes the sentence not really natural to read. Jerome

> I don't really care if it's good English or not…. All I care is to > understand what Thomas is trying to explain :) > > I'll assume it means: > > " > Extension Manager is a module to install/manage extension in your > application and XWiki Repository is a platform to distribute extensions. > Since both are very different technically and they are starting to be > pretty big, Marius and I decided to separated them in two different modules > " > > In this case both are handling extensions which is the common point and > thus I'd expect to see a xwiki-commons-extension module that only deals > with what an Extension is and then have xwiki-commons-extensionmanager that > installs /manager extensions. > > Otherwise you've just created a cyclic dependencies: > * commons-repository needs the concept of extension defined in > commons-extension and commons-extension uses commons-repository > > Thanks > -Vincent > >> >> Jerome >> >> >>> >>>> your application and XWiki Repository as a platform to distribute >>> >>> has? >>> is? >>> >>>> extensions are very different technically and are starting to be >>>> pretty big Marius and me decided to separated them in two different >>>> modules. The main link between them is that Extension Manager has a >>>> handler for this kind of repositories exactly like it has one for >>>> maven repositories (and more later). It makes easier to manage them >>>> separately in UI tests, Jira,etc. >>> >>> Sorry but I don't really understand what you mean. >>> >>> Can you give me a use case where someone would use commons-repository >>> alone (without xwiki-extension)? >>> >>> I don't understand why it's a problem to have >>> xwiki-commons-extension/xwiki-commons-extension-repository/ and what it >>> changes for ui tests, jira, etc >>> >>> I also see we have >>> xwiki-commons-extension/xwiki-commons-extension-repositories/ what are >>> those compared to xwiki-commons-repository? >>> >>> Also xwiki-commons-repository-api is pretty empty… It has a class which > is >>> about REST and which should probably be in a REST module and there's >>> another one which is an interface with no methods. >>> >>> I really don't see the point of a separate top module in commons. I'm >>> probably missing something. >>> >>> Thanks >>> -Vincent >>> >>>>> Note1: Its description in pom.xml is pretty vague: >>>>> <description>XWiki Commons - Repository</description> >>>>> In commons-repository-api it's even worse: >>>>> <description>Contains commons stuff to use in a a client or a server >>> implementation</description> >>>>> >>>>> Note2: On http://commons.xwiki.org/xwiki/bin/view/Main/WebHome it's >>> not described either, nor on e.x.o >>>> >>>> I just finished the refactoring on git yesterday... >>>> >>>>> >>>>> Thanks >>>>> -Vincent