17 May
2011
17 May
'11
11:11 a.m.
Thanks Jun,
I'll look at it asap. I think you could push your changes directly in
your fork instead of publishing patches on dropbox...
It could be useful to comment the code and sending pull requests when
things are done.
Thanks,
Fabio
On Tue, May 17, 2011 at 4:21 AM, Jun Han <jun.han37(a)gmail.com> wrote:
Hi, Fabio,
The updated patch is located in:
http://dl.dropbox.com/u/3466762/xwiki/fix_xeclipse_150.patch
The main changes are the following:
1. removed the parent folder and removed the dependency of other modules
to it
2. binary files for both Linux and Windows in x86 and x86_64 platforms
will be generated via command "mvn clean install"
One issue is that MacOSX binary (cocoa x86_64, x86) files cannot be
generated by a maven build under linux or windows.
I have tried eclipse delta pack. The maven can find the required
specific swt libraries, but still cannot generate the correct binary files.
It seems that the binary RCP product of MacOS can only be generated
under MaxOS via the tycho build script.
Maybe a newer version of maven-tycho-plugin can fix this issue.
Best regards
Jun Han
On 5/16/2011 12:26 PM, Fabio Mancinelli wrote:
Hi Jun
I've tested your patch and it kinda works.
It builds fine but I have an issue because apparently Tycho doesn't
package things well for the x86_64 architecture so I am not able to
run XEclipse (the x86 version core-dumps my JVM :))
I have a question though... Why have you created a parent/pom.xml?
Couldn't you put all the directive in the toplevel pom.xml and make it
the parent for everyone?
Thanks,
Fabio
On Mon, May 16, 2011 at 7:51 AM, Jun Han<jun.han37(a)gmail.com> wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Dear all,
I followed Sergiu's instruction, and did the following:
1. fork xwiki.eclipse repo as master
2. create a branch, called fix_xeclipse_150
3. commits changes
4. created a patch file (link is
http://dl.dropbox.com/u/3466762/xwiki/fix_xeclipse_150.patch)
How to test the build script is listed below:
0. install and configure maven 3.0.3
1. download the patch file
2. check out the master branch of xwiki.eclipse
3. git apply path_to_fix_xeclipse_150.patch (git will give 4 whitespace
warnings)
4. mvn clean install
5. the generated RCP products in 32bit linux and windows are located in
the folder of product/target/products/org.xwiki.eclipse.rcp.product
6. tested in both 32bit Fedora 14 and Windows 7, build/install/run
successfully
best regards
Jun Han
On 05/15/2011 08:17 AM, Sergiu Dumitriu wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs On 05/15/2011 06:02 AM, Jun Han wrote:
> Dear all,
>
> I checked out the xeclipse source codes from github and created a branch
> (fix_xeclipse_150) for it.
>
> Based on that branch, the build scripts for XWiki Eclipse have been
> created using maven + tycho.
>
> The command "maven clean install" can do the following things:
> 1. generates product for multiple target platforms (linux+win 32bit) and
> the binary files can launch successfully.
> 2. generate p2 repository
> 3. generate update site
>
> Now my question is how to create a patch using git or Egit in Eclipse.
> From my understanding from googling around, a patch in git can only be
> created after several commits, which is different to SVN.
> Since I do not have commits permission, I am not sure how to create a
> patch against the master branch.
- create an account on github
- fork the xwiki-eclipse repository
- add your forked repository as a remote to the local repository
- commit locally and push to your remote repository
- create a pull request
> A zip file containing the whole project can be found in this link:
> http://dl.dropbox.com/u/3466762/xwiki/xwiki-eclipse-b150.zip
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs