Re: [xwiki-devs] [Proposal] Introduce user management configuration in virtual mode

Hi all, I just had a discussion with JV about this, and my initial opinion is something like this: On 09/23/2010 09:23 PM, Jean-Vincent Drean wrote: +1, not correct but we need a method to relate a User instance with its details (the XWikiUsers object in the document, if it's a wiki implementation, etc). I agree here, it just makes it complicated for API (well, temporary API or however it should be called) users to operate with, I don't think one should know what a result set is in order to be able to get the next 25 users starting from the 20th user. Not -1, is just feels more friendly with primitives instead of classes. Although it makes a lot of sense to filter by various values of fields (as a general approach), if filtering is allowed by other fields, then these fields need to be also returned in the User class (to be completely coherent). If the fields are also stored in the User class, then basically we just endup copying data from XObjects to User objects. Although possible, because of cache size and synchronization it doesn't seem as a very good idea. I think the path to go is minimalistic User implementation (some sort of a 'pointer' to a user) which can be connected with the actual implementation for the user (in this proposal, it's the DocumentReference) but in general it could be the user id (which in the case of wiki users it's the serialized document reference of the user document but it can have any other form for other user implementation). If this is achieved, then we could do anything with the returned users (because we can find the full, original data) and this component meets its purpose (of handling users retrieval (global - local)) with a very light implementation. this would solve the situation when you don't know exactly what are these users and where do they come from, you just want all the users on the farm (for rights, or for listing available users). If you know there is the notion of local users and that you want only those, you go to XObject level, as JV said. In my view, this API should not completely replace all users management everywhere, XWiki.XWikiUsers class should still be used for specific cases, it's just there to save a few ifs that you'd do everytime you handle users, it's like a shortcut for frequent cases (even the proposed "local", "global", "mixed" scopes have the same flavour of frequently used cases) and make sure there's an easy way to deal all the situations when listing users are needed in an unified way (JV please correct me if I'm wrong on this one).

Thanks, Anca >> >> errr? We're talking about APIs here.... why would I? Simply because there's a notion of local and global users so we need an api to return local users, global users, all users, etc. > > There's a notion of local and global wiki pages, but should it matter > for user management ? > >> >> Whenever you talk specific without being able to do something generic you can be sure your API is flawed and this is my main concern with the proposal: I see it very focused on a single need and IMO it hasn't been thought to be generic. While I'm fine with this we need to know it's going to have to be broken very soon and thus it's not really an API and should be internal instead. >> > > I think we know enough our needs to be able to define a specific API > that won't have to be broken. > > Thanks, > JV. > >> It's ok to be minimalistic but it's not ok not to prepare for all the use cases because you'll have to break the api later on. >> >> Thanks >> -Vincent >> >>> >>>> Thanks >>>> -Vincent >>>> >>>> On Sep 17, 2010, at 11:39 AM, Jean-Vincent Drean wrote: >>>> >>>>> Up! >>>>> >>>>> I could commit the code I have if we agree that it is going in the >>>>> good direction. >>>>> I'm thinking about the component implementation proposal in particular: >>>>> http://dev.xwiki.org/xwiki/bin/view/Design/UsersModule#HUsersComponent >>>>> >>>>> Thanks, >>>>> JV. >>>>> >>>>> On Wed, Aug 4, 2010 at 11:30 AM, Jean-Vincent Drean >>>>> &lt;jean-vincent(a)drean.org&gt; wrote: >>>>>> Hi Devs, >>>>>> >>>>>> I'd like to introduce a new configuration property that would define >>>>>> at which level users should be handled in a farm. >>>>>> See the proposition about the new entry in xwiki.properties, it should >>>>>> be self-explanatory: >>>>>> >>>>>> --------------------------------8<-------------------------------- >>>>>> #-# [Since 2.5M1] >>>>>> #-# Define at which level users and groups should be handled in the >>>>>> farm. Available modes: >>>>>> #-# >>>>>> #-# mixed (default): >>>>>> #-# - user registration available in the main wiki and local wikis >>>>>> #-# - users from the current wiki and the main wiki will be displayed >>>>>> in the rights interface and user suggests >>>>>> #-# - user administration is present in all the wikis >>>>>> #-# >>>>>> #-# local: >>>>>> #-# - user registration available in the main wiki and local wikis >>>>>> #-# - only users from the current wiki will be displayed in the rights >>>>>> interface and user suggests >>>>>> #-# - user administration is present in all the wikis >>>>>> #-# >>>>>> #-# global: >>>>>> #-# - user registration available in the main wiki only, the register >>>>>> link in local wikis will point to the main wiki >>>>>> #-# - only users from the main wiki will be displayed in the rights >>>>>> interface and user suggests >>>>>> #-# - user administration is present in the main wiki only >>>>>> core.virtual.users=mixed >>>>>> -------------------------------->8-------------------------------- >>>>>> >>>>>> More details are available here: >>>>>> http://dev.xwiki.org/xwiki/bin/view/Design/UsersModule >>>>>> >>>>>> WDYT ? >>>>>> >>>>>> Thanks, >>>>>> JV.