15 Jul
2009
15 Jul
'09
10:30 a.m.
Asiri Rathnayake wrote:
Hi devs,
I have completed wiki macro bridge implementation but there are few things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need to
be moved into /platform/core/trunk/xwiki-properties
This should be a separate vote.
2. Need to commit the
xwiki-application-wiki-macro-bridge under
/platform/xwiki-applications/trunk/wiki-macro-bridge. This application hosts
XWiki.WikiMacroClass and XWiki.WikiMacroParameterClass documents. For 2.0M3
we will remove this application and add initialization code that will
generate these two pages automatically.
If this will be removed shortly, why not wait? I don't like creating an
application just so that it can be removed after a few days, since this
creates junk on jira, hudson, our maven repo...
Alternatively, we can keep the xar permanently, since it will contain a
nice UI for managing macros.
3. Commit xwiki-core-rendering-macro-wikibridge under
/platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge
Why is the app called wiki-macro-bridge when the module is called
macro-wikibridge?
4. Make necessary dependancy changes so that XE will
bundled with wiki-macro
support by default.
Here is my +1 for all of above.
Note that this is a quite large commit (had to refactor macros to use
xwiki-properties), there might be few places where my code can be improved.
Any comments are welcome.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/