[xwiki-devs] [VOTE] merge branch 'feature-solr-search' into 'master' for 4.3M2

Hi devs, I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap. Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4] The pull requests [5][6] are available for reviewing so start shooting :) Thanks, Eduard ---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2] https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade [3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34