10 Feb
2011
10 Feb
'11
4:02 p.m.
On Feb 10, 2011, at 3:53 PM, Caleb James DeLisle wrote:
[snip]
If we are to keep deprecated code such as rendering1.0
(forever?) I think we need to move it out of
the core where it confuses attempts to fix core bugs.
Yes that's the goal. We need to do some more refactoring before this can happen:
* Move templates to use wiki syntax and the new rendering engine
* Move translation keys to use the new rendering engine too
Once these 2 are done we can move it our into a separate module and after some time not
bundle it with the default distribution.
Thanks
-Vincent
Caleb
On 02/09/2011 09:21 AM, Vincent Massol wrote:
+0 for the idea but I don't know that part of
the code enough to know what problems this is going to cause (custom storage
implementations out there, etc).
Personally I'd have preferred to not touch a single bit at any existing storage
interfaces and instead introduce new storage APIs in the new xwiki-store module and have a
flag to direct to the old or new implementations. This is basically the strategy we
followed with the new rendering engine and that has allowed us to keep 100% backward
compat for the XWiki 1.0 syntax.
Thanks
-Vincent
On Feb 9, 2011, at 2:20 PM, Caleb James DeLisle wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs I would like to propose another round of storage
deprecations, the goal of these is to remove and
decrease visibility of code in order to simplify storage and move as much as possible
over from API
to implementation details. I am proposing deprecation of each of the following, after 2
releases
this may be revisited and they may be removed or altered. The following are changes I
have made
locally and found xwiki-core does compile and test with those changes.
For now I propose adding deprecation comments and annotations to each class or method.
WDYT?
Caleb
XWikiAttachmentStoreInterface.java
saveAttachmentContent(XWikiAttachment attachment, XWikiContext context, boolean
bTransaction)
remove
cleanUp(XWikiContext context)
remove
XWikiBatcher.java
remove entirely
XWikiBatcherFactory.java
remove entirely
XWikiBatcherStats.java
remove entirely
XWikiDefaultStore.java
remove entirely
XWikiHibernateBaseStore.java
getDatabaseProductName(XWikiContext context)
public --> protected
shutdownHibernate(XWikiContext context)
remove
updateSchema(XWikiContext context)
public --> private
getSchemaFromWikiName(String wikiName, DatabaseProduct databaseProduct, XWikiContext
context)
protected --> private
getSchemaFromWikiName(XWikiContext context)
protected --> private
getSchemaUpdateScript(Configuration config, XWikiContext context)
public --> private
updateSchema(String[] createSQL, XWikiContext context)
public --> private
updateSchema(BaseClass bclass, XWikiContext context)
remove
isVirtual(XWikiContext context)
public --> protected
beginTransaction(SessionFactory sfactory, XWikiContext context)
public --> protected
beginTransaction(SessionFactory sfactory, boolean withTransaction, XWikiContext context)
public --> protected
endTransaction(XWikiContext context, boolean commit, boolean withTransaction)
public --> protected
execute(XWikiContext context, boolean bTransaction, boolean doCommit,
HibernateCallback<T> cb)
public --> private
XWikiHibernateStore.java
getContent(XWikiDocument doc, StringBuffer buf)
remove
public List search(Query query, int nb, int start, XWikiContext context)
remove
injectCustomMappingsInSessionFactory(BaseClass bclass, XWikiContext context)
public --> private
injectCustomMappingsInSessionFactory(XWikiContext context)
public --> private
XWikiHibernateVersioningStore.java
loadAllRCSNodeInfo(XWikiContext context, final long id, boolean bTransaction)
protected --> private
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs