On 1 Mar 2016 at 18:23:14, Thomas Mortagne
(thomas.mortagne@xwiki.com(mailto:thomas.mortagne@xwiki.com)) wrote:
On Tue, Mar 1, 2016 at 6:09 PM, Marius Dumitru Florea
wrote:
> On Fri, Feb 5, 2016 at 3:06 PM, vincent(a)massol.net
> wrote:
>
>> Hi devs,
>>
>> I’ve just realized (thanks to a failing functional test) that we’ve
>> changed the behavior we had when we restore a deleted document.
>>
>> We used to add a revision with a comment text of "Restored from recycle
>> bin”.
>>
>> After
https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision
>> created when restoring a deleted document.
>>
>> We need to decide if that’s what we want.
>>
>> Apart from the fact that it’s a minor backward-compatibility breakage (for
>> tools/scripts expecting that revision), the only downside I can see is that
>> by looking at a document history you won’t be able to get the full list of
>> what happened to this doc, i.e. that such user has restored the document.
>>
>> WDYT?
>>
>
> "Alice has deleted this page" and "Bob has restored this page from
recycle
> bin" are *activity stream* events more than history entries (versions).
I agree
There's no
need to be able to revert, compare or blame such a "version".
There may be other page actions like this too, that should appear in the
activity stream (for a page) but that don't necessarily generate a new
version in the history. So we could imagine having another "Activity
Stream" tab/viewer besides History, or a unified History viewer that shows
both activity stream events and page versions.
Indeed, like the distinction Jira makes between history and activity.
It’s a nice idea. I’ve created
http://jira.xwiki.org/browse/XWIKI-13169
Thanks
-Vincent
>> Personally I think this could be acceptable
but I’m not sure.
>>
>> Thanks
>> -Vincent