21 Oct
2010
21 Oct
'10
1:17 a.m.
On 10/20/2010 10:57 AM, Vincent Massol wrote:
On Oct 19, 2010, at 10:04 PM, Marius Dumitru Florea wrote:
I don't like getLinkURL. Link is almost a synonym of URL, so it sounds
like a pleonasm a bit, at least for me.
getResourceURL?
On 10/19/2010 09:43 PM, Vincent Massol wrote:
You're right, since we have no way of differentiating links and images in
ResourceReference we need to have 2 methods:
- getImageURL
- getLinkURL
(better than getAttachmentURL IMO) Hi,
We currently have 2 methods introduced in 2.5 timeframe in the WikiModel class:
String getAttachmentURL(ResourceReference attachmentReference);
String getImageURL(ResourceReference attachmentReference, Map<String, String>
parameters);
I think we should merge them into a single method in charge of returning the URL of any
resource reference:
getResourceURL(ResourceReference reference,
Map<String, String> parameters);
Are you going to use the current implementation of getImageURL for all
ResourceType.ATTACHMENT resources? Thanks
-Vincent
>
> Thanks,
> Marius
>
>>
>> Note that this would assume that all references have a URL associated to them.
It's not always true (it's true for documents, attachments, url, interwiki and the
future icon/symbol but false for path and mailto). We could return null for resource types
that have no associated URLs.
>>
>> The reason I'm proposing this because in order to implement support for
symbol/icon I'd need to add a new method to WikiModel: getIconURL(ResourceReference
iconReference) but I feel it's better to have a single getResourceURL().
>>
>> WDYT?
>>
>> Thanks
>> -Vincent
--
Sergiu Dumitriu
http://purl.org/net/sergiu/