5 May
2010
5 May
'10
5:29 p.m.
On Wed, May 5, 2010 at 17:08, Jerome Velociter <jerome(a)xwiki.com> wrote:
Hi devs,
Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org to 2.3),
we've face the <body> database className conflict again, on code.xwiki.org.
What happens is that the "code" DOM class name is apposed to the body element
(see htmlheader.vm), and this interferes with styles defined for the {{code}} macro.
Potentially there are other scenarios where class names can conflict with database names.
I propose we prefix the apposed class name with "wiki-" (that's what
we've been doing on xwiki.org for some time now) in order to avoid this.
Though, we need to agree on this, since it can be a breaking change for those who relied
on that "feature" to skin differently different wikis on a farm.
WDYT ?
I don't see anything wrong with "wiki-" (note that '-' is forbidden
by
wiki manager) so +1.
Jerome.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne