10 Feb
2011
10 Feb
'11
6:43 p.m.
On Thu, Feb 10, 2011 at 18:40, Vincent Massol <vincent(a)massol.net> wrote:
oups
"and we refactor all the other get*Block based on these new methods
using predifined BlockMatcher (ClassBlockMatcher,
MetaDataBlockMatcher, etc...)"
On Feb 10, 2011, at 6:27 PM, Thomas Mortagne wrote:
Yep sorry several mixed versions.
Here is a proposal to reduce all get...Block to 2
methods which
support matching any Block.
interface Block
{
enum TraversalStrategy
{
/** Search in parents **/
PARENT,
/** Search in children **/
CHILD,
/** Search recursively in children (and children of children etc...) **/
CHILDRECURSE,
/** Search in previous siblings **/
PREVIOUS,
/** Search recursively in previous siblings (and parent previous
sibling etc...) **/
PREVIOUSRECURSE,
/** Search in next siblings**/
NEXT,
/** Search recursively in next siblings (and children etc...)**/
NEXTRECURSE
}
[...]
List<Block> getBlocks(BlockMatcher matcher, TraversalStrategy
traversalStrategy, boolean recurse);
recurse param should be removed right?
Block getFirstBlock(BlockMatcher matcher, TraversalStrategy
traversalStrategy, boolean recurse);
}
same here
interface BlockMatcher
{
boolean match(Block block);
}
et on refactor tous les autres get*Block basé sur ceux la avec des
BlockMatcher prédéfinis (ClassBlockMatcher, MetaDataBlockMatcher,
etc...).
Frenglish? ;)
+1
Thanks
-Vincent
--
Thomas Mortagne
Note: the main use case for this change is to support MetaData search.
WDYT (especially on the vocabulary like "TraversalStrategy") ?
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs