5 Feb
2013
5 Feb
'13
10:35 a.m.
Hi Edy,
On Feb 4, 2013, at 7:47 PM, Eduard Moraru <enygma2002(a)gmail.com> wrote:
Hi devs,
I`ve just pushed (to master and stable-4.4.x) a fix for a workspace bug [1]
that caused problems when a workspace name/ID contained an underscore. I am
mentioning this because the fix required, in order for it to be a proper
fix, that I do a clirr violation (remove the wikiName parameter from the
createWorkspace method because it was misleading).
Since this API is not used in any XWiki module that I know of, not in any
third party code either (correct me if I`m wrong), I think that the clirr
exclusion will not create new issues.
Just wanted to mention it. If someone does not agree with this decision,
please let me know so that we can make a better one.
Seems good to reuse the wiki name from the XWikiServer object.
Now let's hope that nobody was using that API (it's a pretty high level and
important API and it's not a new API - dates back from April 2011, i.e. almost 2 years
ago…).
A safer solution could have been to allow passing null as the first parameter in which
case the name from XWikiServer would be used and otherwise the passed name would override
the XWikiServer name. And then in the future (in 5.0 for ex), deprecate and add a new
signature.
However I'm not sure I agree with breaking the Script Service… Why cause an
unnecessary breakage?
Why not simply deprecate the signature with the String as first param and add new
signatures?
BTW are you saying that the script service is not used by any wiki page of ours?
Thanks
-Vincent
Thanks,
Eduard
----------
[1] http://jira.xwiki.org/browse/XWIKI-8394