Hi,
While I understand the logic, this proposal sounds like we want to move
towards skin-level tests (and supporting multiple skins), i.e. with the
addition of a new XWiki skin, we will need a complete set of new UI tests
for the new skin, since all our existing UI tests will be associated with
the previous skin.
AFAIK, we agreed (mainly due to low man-power) to only support 1 XWiki skin
and, as skins come and go, we only update the tests, not replace them. Take
the colibri to flamingo transition for example: we just updated some tests
instead of rewriting a complete new set of tests + pageObjects.
IMO, if we are looking for a replacement of xwiki-enterprise-test-ui, we
could try what Marius suggested and use an xwiki-platform-web-test module
so that we move the tests to platform and still don`t tie them to a
particular skin (such as flamingo).
Thanks,
Eduard
On Mon, Aug 3, 2015 at 5:14 PM, vincent(a)massol.net <vincent(a)massol.net>
wrote:
Note that we could also move the base PageObjects
currently located in
xwiki-platform-test into xwiki-platform-flamingo-skin-test-pageobjects…
-Vincent
On 3 Aug 2015 at 14:55:22, vincent(a)massol.net (vincent(a)massol.net(mailto:
vincent(a)massol.net)) wrote:
On 3 Aug 2015 at 14:53:50, Marius Dumitru Florea (
mariusdumitru.florea@xwiki.com(mailto:mariusdumitru.florea@xwiki.com))
wrote:
+1. I guess we'll have to add a
xwiki-platofrm-web-test module at some
point for testing the Velocity templates that are shared between
skins.
yes, I didn’t mention this but I agree. For now since we have only 1
skin (or will
soon since we’re removing colibri) it seems simpler to have
the tests in Flamingo.
Thanks
-Vincent
> Thanks,
> Marius
>
> On Mon, Aug 3, 2015 at 3:41 PM, vincent(a)massol.net wrote:
> > Hi devs,
> >
> > I’ve brainstormed with Thomas and we’ve discussed where to put
functional tests such as test that verify that page creation from the UI
works (i.e. that test the create vm and the oldcore java action in this
case).
> >
> > We’re proposing to put those tests (which are currently located in
enterprise tests) under xwiki-platform-flamingo-skin, i.e. to assimilate
those tests as functional skin tests.
> >
> > In order to do this I’ll create:
> >
> > xwiki-platform-flamingo
> > |_ xwiki-platform-flamingo-skin
> > |_ xwiki-platform-flamingo-skin-resources (—> zip)
> > |_ xwiki-platform-flamingo-skin-test (functional tests)
> > |_ xwiki-platform-flamingo-theme
> > |_ xwiki-platform-flamingo-theme-bootswatch (XAR)
> > |_ xwiki-platform-flamingo-theme-ui (XAR)
> > |_ xwiki-platform-flamingo-theme-test (functional tests for Theme UI)
> >
> > WDYT?
> >
> > I’m going to start moving and splitting the current CreatePageTest
into
2:
> > * the tests that use Template Provider
will go in
platform-administration-tests
> > * the tests that verify simple
page/space creation will go in
xwiki-platform-flamingo-skin-test
> >
> > Thanks
> > -Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs