1) 4 (and 1 non binding) +1
2) 1 +1
Looks like won't fix wins, closing the issue.
On Tue, Jan 20, 2015 at 6:28 PM, Denis Gervalle <dgl(a)softec.lu> wrote:
Well, since it was usual to make a skin without
specifying a base skin,
allowing to start from scratch by doing so is an improvement.
+1 for 1)
On Tue, Jan 20, 2015 at 12:09 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com
wrote:
> Since it seems to not be very clear: 2) does not prevent anything,
> it's just a configuration you can change in xwiki.cfg any time you
> want (basically the opposite of 1)).
>
> On Tue, Jan 20, 2015 at 11:26 AM, Guillaume "Louis-Marie" Delhumeau
> <gdelhumeau(a)xwiki.com
wrote:
>
> +1 for 1, because it allows us to create a new skin from scratch.
> > +0 for 2 and 3, since I guess that existent skins that do not specify
> their
> > base skin were based on Colibri and will not necessary behave correctly
> > with Flamingo.
> >
> >
> > 2015-01-20 10:37 GMT+01:00 Thomas Mortagne <thomas.mortagne(a)xwiki.com>om>:
> >
> >> Since 6.2 (and XE-1419) there is no base skin by default which mean
> >> that if you forget to set a base skin in your wiki skin it inherit
> >> directly from /templates and /resources. XE-1419 was done mostly to
> >> make sure colibri and flamingo were not going to inherit from each
> >> other.
> >>
> >> This leaded to
http://jira.xwiki.org/browse/XWIKI-11443, I see several
> >> possibility to close this issue:
> >>
> >> 1) won't fix, if you want a default base skin then just set it in
> xwiki.cfg
> >> 2) put back the default skin in xwiki.defaultbaseskin (so flamingo) in
> >> xwiki.cfg
> >> 3) force wiki skin to fallback in default skin
> >>
> >> The issue with 3) is that it makes impossible to do a wiki skin from
> >> scratch (why not ?).
> >>
> >> Now that filesystem skin explicitly indicate there parent skin 2) is
> >> not a problem anymore for them so we could put it back, I guess my +1
> >> goes to than and that's what I will do to unlock 6.4 if there is no
> >> answer.
> >>
> >> I don't have a strong opinion on it since I pretty much never ever do
> >> any wiki skin, just want to close this issue...
> >>
> >> --
> >> Thomas Mortagne
> >> _______________________________________________
> >> devs mailing list
> >> devs(a)xwiki.org
> >>
http://lists.xwiki.org/mailman/listinfo/devs
> >>
> >
> >
> >
> > --
> > Guillaume Delhumeau (gdelhumeau(a)xwiki.com)
> > Research & Development Engineer at XWiki SAS
> > Committer on the
XWiki.org project
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> >
http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
>
http://lists.xwiki.org/mailman/listinfo/devs
>
--
Denis Gervalle
SOFTEC sa - CEO
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs