7 Dec
2010
7 Dec
'10
12:15 a.m.
On 12/04/2010 05:02 PM, Raluca Stavro wrote:
Hello,
The current searchUniquePages() method from the activitystream plugin
returns the list unique page names sorted by max(event.date) desc.
Because each page appears once in the list, the events for a page on
previous days are not being displayed in the activity stream (on
dashboard, user profile and tags).
What searchUniquePages() method should actually return is the list of
unique pages GROUPED and ordered BY DAY.
Since this method is used only once, in the activity macro, the query
inside it could be modified, so that the result list to match the
activity stream requirements.
Otherwise, I would have to create a new method, something like:
searchUniquePagesPerDay() and depricate the searchUniquePages()
method.
What do you think that the best solution would be in this case?
I think it's better to keep the current method as it is, since it has
its valid usecases, although it won't be used by default anywhere. The
name doesn't allow the proposed behavior, since then it won't return
UNIQUE pages.
I'd add another method, searchDailyPages, which returns a list of <date,
page name> entries.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/