Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

Hi everyone, the current behaviour of the ObservationManager is to always triggers the listeners if it matches the events. Now regarding the CancelableEvents, the match is only done on the type of the event and some given filter rules, but never with its cancel status: if an event is cancelled, the matching listeners are always triggered. I propose to change that behaviour, to trigger listeners only if the CancelableEvents are not canceled: basically, a cancelled event wouldn't match any listener. My primary reason for wanting that change is that the current behaviour led to a bad UX: if an event triggers multiple questions, no matter if one is cancelled, all questions will be asked to the user. Do you know if the current behaviour is required at some places? Else do you agree on changing it? Simon -- Simon Urli Software Engineer at XWiki SAS simon.urli(a)xwiki.com More about us at http://www.xwiki.com