On 12/21/2010 02:45 PM, Marius Dumitru Florea wrote:
Some nitpicking:
Enable or disable the WYSIWYG/Source tabs. [ ] Yes [ ] No
^ This isn't a yes/no question. How about:
1. [ ] Enable the Source tab
2. [ ] Display WYSIWYG/Source tabs
1 says that only the WYSIWYG mode is enabled, while 2 says that both
modes are enabled, just that there's no UI to switch between them, but
either one can still be displayed by other means (JS scripting or field
configuration). Personally I prefer the wording of 1, even if 2 is the
actual implementation, since it's more user friendly.
Inputs: I'm not sure a text input is the best element here, can't a
select be used?
Lists: I think that "Drag and drop to change the order" is not a very
useful tooltip, is it possible to have an item description instead? If
not possible yet, something to keep in mind for the future.
Yes/No radio buttons: Usually checkboxes are better for this. You can
see this proposed in the forms standard as well:
http://incubator.myxwiki.org/xwiki/bin/Standards/FormVerticalUsage#HFormExa…
Font sizes: I agree that pt is the better unit here. Even though px is
the standard unit on the web, the WYSIWYG is mostly trying to emulate
Office applications, where the pt is the preferred unit.
Overall, this looks very nice. +1 for committing it.
Referring to the other thread about committing the forms standard in the
platform, I'm planning to do that in the coming days. How do we make
sure we're not overlapping?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/