27 Apr
2007
27 Apr
'07
9:49 p.m.
On Apr 27, 2007, at 9:02 PM, Ludovic Dubost wrote:
-1
I think you specify the reference to this value in
hibernate.cfg.xml to tell hibernate to get it's datasource from
this variable.
Yes this is how it works...
It's useful because it allows to manage the
datasource information
in the App Server config which is liked by App Server managers
Of course it's useful! :-)
But this is not my proposal...
My proposal is that the default configuration of XWiki is consistent.
Right now it isn't. Hibernate.cfg.xml doesn't use data source while
web.xml defines one. The issue is that even though xwiki doesn't use
the DS by default, users still have to configure it in the app server
making it more complex to install XWiki (and useless).
So 2 choices:
- either we decide DS is the default config
- or we decide no DS is the default config
but not both at the same time... I prefer the no DS option as it's
easier to get started for a user. Advanced user can the use a
container-defined DS.
I agree DS are useful which is why we should document it and even
possibly comment it out with some comments in the file. But it
shouldn't be on by default IMO.
However +1 for documenting and test how to specify the
datasource
in hibernate.cfg.xml
yep
Thanks
-Vincent
Ludovic
Vincent Massol a écrit :
> Hi,
>
> I'd like to remove the DataSource reference in web.xml (for 1.1
> Beta 1):
>
> <resource-ref>
> <description>DB Connection</description>
> <res-ref-name>jdbc/XWikiDS</res-ref-name>
> <res-type>javax.sql.DataSource</res-type>
> <res-auth>Container</res-auth>
> </resource-ref>
>
> it's defined in there but our default hibernate config doesn't use
> it, so it's not used by default... but forces users using an app
> server to create a fake DS as is described for example in the
> install notes for Websphere and jboss.
>
> We also need to document how to configure xwiki to use the app
> server DS.
> For example see:
> http://mail-archive.objectweb.org/xwiki-dev/2005-06/msg00124.html
>
> But I think our default should be the simplest possible ie without
> DS.
>
> WDYT?
>
> Thanks
> -Vincent
>