8 Apr
2012
8 Apr
'12
6:04 p.m.
Le 8 avr. 2012 à 04:07, Sergiu Dumitriu a écrit :
Fabio,
I insisted on a fork from your repo (with the right branch, that was the trick I and
Savitha failed to catch for a while) so that we can evaluate the contribution of Savitha
to this work. He found it independently of me.
This is now visible in commit:
https://github.com/savee1/xwiki-platform/commit/5bb50fe2ddb12c1ef68fb83e096…
In all cases, I think the work of Savitha will be on his GitHub repo, at best as a branch
from xwiki directly, where a pull request will be able to be formulated. I wouldn't be
surprised, however, that several pull requests will be needed in a non-linear way so that
things will not be as simple as GitHub wishes us to be. In this case, there will be diff
juggling.
Maybe it will be even easier that he makes a new repo, not based on others, so that it
becomes something people can deploy when they feel its ready. The big repos at GitHub are
not too friendly for this kind of sub-modules unfortunately (this is a great loss to my
taste compared to svn).
So... what is the procedure to review his work and give our ranking?
Is this only in Melange or is there a way inside?
I haven't been able to check, yet, if it runs as desired...
paul
So I propose
to open a fork of xwiki-platform in xwiki-contrib, and
that Savitha works on that fork and (re)send pull requests there.
WDYT?
That won't work, there is a fork already, and github only allows one fork per user
(or organization).
Let's follow the github philosophy, which is "be social" and work on
Savitha's personal fork for the moment.