Re: [xwiki-devs] [VOTE] Is it OK to edit a standard color theme

To give my opinion, I’m hesitating about 2 approaches: Approach 1: “standard" ================== * We should have “Default Color Theme” be a copy from the Iceberg color theme page. I think I’d prefer the copy to be done at runtime; for example if the currently defined color theme page doesn’t exist when going to the L&F > Themes admin page, create it by copying Iceberg. This provides a self healing feature if the color theme page has been removed/doesn’t exist/etc. * Predefined color theme pages should be considered “standard” and a warning message displayed if a user wants to edit them. BTW would be nice to have a feature to have a customized message per “type”. For example for color theme pages we would display a message saying that the user should copy the page to customize it instead of editing it. * The Color Theme UI should also be improved a bit to have a “Customize” button on color theme pages that would perform a copy to let the user customize a theme. Approach 2: “demo" ================ * Consider all color themes to be demo content and once the user starts modifying them don’t merge them anymore * When we want to provide modified color themes, introduce new theme pages * Don’t provide a “Default Color Theme” page. Directly set “Iceberg” to be the default CT. Analysis ======= Approach 2 is more wiki style and simpler for sure. Users can use the diff feature and the rollback feature if they want to go back to the original versions. I think I’m leaning more towards 2 ATM.

Thanks -Vincent