Hi,
On Mon, May 4, 2009 at 6:09 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
Henning Sprang wrote:
I just ran into this little, but very annoying
problem, becaue I
actually lost 15 minutes of editing:
I entered some text in the page edit textfiled, but I also wanted to
add a little save/commit comment.
So I wrote some words into the the text input field, ad naturally, I hit
return.
The page view is shown, but all I entered into the text field is gone.
Not exactly what I want when entering a save/commit comment, isn't it?
This is normal browser behavior. Hitting enter submits the form using
the first submit button it finds. To avoid this, we can only do one
(100% working) thing: reorder the buttons so that preview is the first
one (or Save).
This could trigger the more general question of action order in XWiki:
sometimes the "do" action is on the left while the "don't" is on
the right
(for instance to post a comment the button in on the left while the cancel
button is on the right), sometimes the "do" action is on the right and the
"don't" on the left (as is the case when saving a page).
It would be much better if this ordering was consistent throughout XWiki.
As you can see from this page:
http://doc.trolltech.com/qq/qq19-buttons.html#anextendedmessagebox
the Windows ordering of such buttons usually is Ok / Cancel while the Mac OS
X one is Cancel / Ok .
Given Sergiu's remark (the fact that upon hitting enter in a form field the
action triggered is the one of the first button encountered), I'd say that
we'd better have "Save" first in most cases -> it's better to save
content
as long as it can be deleted afterwards than the other way round (cancel
first that leads to the data loss Henning experienced).
So my take on this issue would be that we should standardize buttons all
around XWiki to have the Save / Preview / Cancel order for every post / save
action (comment, page, blog post, form etc...)
WDYT?
Guillaume
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Guillaume Lerouge
Product Manager - XWiki
Skype ID : wikibc
http://guillaumelerouge.com/