10 May
2010
10 May
'10
10:06 a.m.
On Mon, May 10, 2010 at 09:34, Ludovic Dubost <ludovic(a)xwiki.org> wrote:
I was also +1 on this..
However it would be nice to provide a script to detect any data that might
have been using the feature, and put it in the release notes
Things is that this feature was pretty much not usable anyway since not all
the places manipulating groups was using it, in fact it was only applied by
XWikiGroupServiceImpl#listMemberForGroup.
Ludovic
Le 09/05/10 12:44, Thomas Mortagne a écrit :
3 +1
--
Thomas Mortagne
Committed in trunk
On Fri, May 7, 2010 at 18:36, Thomas Mortagne<thomas.mortagne(a)xwiki.com
--
Ludovic Dubost
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
wrote:
Hi devs,
I recently created http://jira.xwiki.org/jira/browse/XWIKI-5149, this
issue is due to the fact that XWikiGroupServiceImpl#listMemberForGroup
is splitting the value of the "member" field based on white space and
comma.
That does not make sense IMO and makes impossible to have a user with
a white space (and comma which is less common) in its name for a very
bad reason. Also the name of the field is "member" and not
"members".
Last reason is that i think in all other places we don't take this
value as a list.
Note that this bug is mainly a pain for authenticators where you have
to remember the real name of the user and have some collision handling
to support use case users "somename" and "some name" coming for an
external authentication server in which theses are two different
users.
WDYT ?
Here is my +1.
--
Thomas Mortagne