On Jun 27, 2009, at 2:46 PM, Thomas Mortagne wrote:
On Sat, Jun 27, 2009 at 10:48, Vincent
Massol<vincent(a)massol.net>
wrote:
Hi,
In order to implement SpacePreferencesConfigurationSource I need
access to the current space.
Hence I'm proposing to add String
DocumentAccessBridge.getCurrentSpace()
Here's my +1
I think SpacePreferencesConfigurationSource should be in
xwiki-core
for now (until we have the new model) or it will just be a class full
of calls to DocumentAccessBridge...
Same for WikiPreferencesConfigurationSource.
I see only 1 getProperty() call for each (and possibly - not even sure
- one call to get the current space).
What am I missing?
And the calls to the access bridge are OK, since they are supposed to be
replaced with calls to the new model once it is in place, so all the
code that needs access to the model *should* use the bridge. Once we
have the new model in place, the default bridge implementation will use
it instead of the old core.
--
Sergiu Dumitriu