On Nov 29, 2011, at 10:56 AM, Ludovic Dubost wrote:
Yes it should be configurable where the class should
be
We also need a list of Applications somewhere so that you can find your
application easily.
This could also be my proposal here:
http://markmail.org/thread/jupn22fdk4nnqj6p
Thanks
-Vincent
Ludovic
2011/11/29 Ecaterina Moraru (Valica) <valicac(a)gmail.com>
> Hi,
>
> One of the bad things in the structure of the AppWithinMinutes is that all
> new user classes are created inside AppWithinMinutes space.
> First of all is kind of hard to distinguish what are internal code pages
> and what pages were created during my test (TestClass, TestHome, TestSheet,
> etc.).
> Maybe some page name convension would be helpful for pages like: DBList,
> Date, etc.
> This mixing of pages will make harder also the export of one specific
> application and it's pages.
>
> Just a thought,
> Caty
>
>
> On Mon, Nov 28, 2011 at 16:19, Marius Dumitru Florea <
> mariusdumitru.florea(a)xwiki.com> wrote:
>
>> Caty.. I can see that you spent a lot of time testing but the only
>> purpose of the AppWithinMinutes home page, as it is right now, is to
>> expose the class editor and the live table generator in XE 3.3M2,
>> which means it's temporary. This thread is about the AppWithinMinutes
>> wizard I have committed yesterday, which, as I wrote in my mail, is
>> located at AppWithinMinutes.CreateApplication page. I'm afraid some of
>> your comments below are not relevant in the context of the wizard. I
>> will reply to the relevant ones.
>>
>> On Mon, Nov 28, 2011 at 3:15 PM, Ecaterina Moraru (Valica)
>> <valicac(a)gmail.com> wrote:
>>> Hi Marius,
>>>
>>> I'm gonna list some thoughts as I test what you did. I didn't read
>> anything
>>> that Ludo wrote so these will be my first impressions and not a
>>> continuation of the discussion. Some items may be very fined grained,
>> but I
>>> will list them in order to remember them.
>>>
>>> *AppWithinMinutes.WebHome*
>>> - Some fields validation about what fields are required or not. If you
>>> press the buttons without entering anything in the fields you don't
> know
>> if
>>> something happened or not.
>>>
>>> - "Class Name" field - some suggest would be nice in order to know
what
>>> classes can be edited. Especially if I need to write them in Space.Page
>>> form. Very nice that I can edit XWiki.XWikiUsers
>>>
>>> - "Create/Edit Class": I've entered "Class
Name"='TestClass' and I was
>> very
>>> surprised that the title of that class was "Class: Test" and not
> "Class:
>>> TestClass"
>>> *
>>>
>>> ?editor=inline&sheet=AppWithinMinutes.ClassEditSheet*
>>> - First time when you enter the editor, the pages "TestTemplate"
and
>>> "TestSheet" are displayed as non-created. Why don't you create
them
> from
>>> start?
>>>
>>> - Check icon's title is "Hide configuration panel" - should be
"Apply
>>> changes" or "Save configuration" or "Save" or
"Save changes" or :)
>>
>> It doesn't save the changes. I'm fine with "Hide configuration
panel
>> and apply changes".
>>
>>>
>>> - I cannot drag something at the start of my form or in between what
>> fields
>>> already exists. It adds the new field at the bottom and than I need to
>>> reorder. Very annoying.
>>
>> I know, but it's not a priority IMO.
>>
>>>
>>> - No error if I put the same "Name" on multiple fields. The error
> appears
>>> on "Save". The error is not contextual. I mean to use the xError
for
> the
>>> specific problematic fields.
>>
>> I didn't have time to implement client-side validation. I agree it's
>> important but we won't have it in the first version.
>>
>>>
>>> - General remark: I really hate the "Editor: ---" thing. When you
> reload
>>> the page it appears the WYSIWYG (because that is the default). Should
>> write
>>> "Default editor" instead of "---", because IMO
"---" means "None"
>>>
>>> - On hitting "Enter" is always re-saves. Don't know if this is
a good
>> thing
>>> or not, but is not an explicit user action. I did not hit the
"Save"
>>> myself: maybe I was just testing and I didn't want to make any
>> modification
>>> on the form (now my name is in the history and everybody will know I
> was
>>> here :) )
>>>
>>> - I would like to have the "Preview" button back in order to see
how
> the
>>> form looks like (even if it's an WYSIWYG mode somehow), but if I have
> my
>>> configurations open.
>>>
>>> - I was expecting to see my generated form when I press
"Save&View" or
>> when
>>> I go to the page AppWithinMinutes.TestClass (not an empty page)
>>>
>>> - /view/AppWithinMinutes/TestClass - I wanted to go back in the
>>> AppWithinMinutes editor, I pressed "Edit": took me to
"WYSIWYG",
> pressed
>>> "Class" took me to class editor, then I remembered I need to press
>>> "Inline". How do I get back? //Later//: "Edit Class" is
only on the
> page
>>> created for the livetable.
>>>
>>> - Adding "Number" and writing some characters in it didn't
wield any
>> error.
>>> //Later//: Also when you create a new entry the default character value
>> is
>>> not present (because it was not a number), but if you put again
>> characters
>>> instead of numbers: they don't get displayed, but again no warning or
>>> correction
>>
>> Falls in the "client-side validation" category.
>>
>>>
>>> - "Configure" is kind of an "Advanced params" until I get
to the
> "Static
>>> List", when I am unable to edit the choices. I would prefer to have the
>>> default selection when I hit the checkbox/radio only. If I double click
>> on
>>> the choice name can I have the "Configure" opened? In order to see
that
>>> there is the place where I need to change the values. Or open the
>>> "Configure" if a double click the whole area.
>>
>> I don't like the double-clicking idea.
>>
>>>
>>> - The preview only on "Hide configuration panel" is kind of
annoying.
>> Again
>>> that entry should be named "Save changes" or something. I pressed
>> "Multiple
>>> Select", it auto-changed the "Display Type" to
"checkbox", but this
>> change
>>> is not visible. I try to look for a way to mark my change, so I'm out
> of
>>> field's area, so the toolbox for the field is not visible. Maybe if you
>>> have the configuration zone open we should keep the field's toolbox,
> even
>>> if we are not hovering the area: in order for the Check to be more
>> visible.
>>
>> Keeping the toolbox visible when the configuration panel is shown is
>> an interesting idea.
>>
>>>
>>> - Again about the auto-preview: if I hit Enter in a input, the page
> gets
>>> saved. Can't it also refresh the preview with the change I did also?
> I'm
>>> talking about changing the "Rows" for a Textarea zone: put
"4", pressed
>>> "Enter", page gets saved, but in order to get the textarea resized
I
> need
>>> to refresh the page or hit "Hide configuration panel".
>>
>>> Obs: After adding "Static list" or "Checkbox" fields the
save behavior
> on
>>> inputs disappeared. (not sure this is the reason)
>>
>> I think this is just the browser behavior.
>>
>>>
>>> - "Static List" values - missing an active state for the Choice
being
>>> edited. The hover color, should be preserved to mark the active value
>> being
>>> edited.
>>
>> Agree.
>>
>>>
>>> - Not sure what "Sort" does. I don't see any change in the
sorting.
>>> Shouldn't the choice be rearranged?
>>>
>>> - Regarding the "Date" field: would be nicer if the
"06/11/2011
> 14:41:26"
>>> info would be presented in the "cds_top" instead of
"cds_footer" and
> have
>>> the "X" instead of "Ok" near this (at the top).
>>> If it's at the top is easier to compare the "current value"
with the
> "new
>>> value".
>>> "@" is kind of cryptic and geekish. You have place to put
"Time",
>>> especially if you remove the "Ok" and make it an "X"
>>>
>>> - Not sure what "Update class template" and "Update class
sheet" mean
>> but I
>>> don't care. Could be in an advanced configuration zone for the form
>>> (class).
>>>
>>>
>>> *AppWithinMinutes.WebHome*
>>>
>>> "Generate Livetable"
>>> - I've entered a non existing class "NewClass" and a random
target -
>>> worked, but maybe I should have an option to create that non existing
>> class
>>> somewhere
>>>
>>> - If I put "NewClass" in the "Class Name" and nothing in
the "Target
> Page
>>> Name" takes me to the editor (AppWithinMinutes/NewClass?editor=inline),
>> not
>>> to the Livetable Generator - hmmm
>>>
>>> - "Columns" is always white initially or after an add operation -
could
>> be
>>> a text there "Add column" (with gray + italic) to encourage
clicking
>>>
>>> - After the table was generated there are some problems with
> translations
>>> in the header: "$msg.get('xe.livetable.select.all')",
"$l10n_value",
> etc.
>>> but this is a snapshot
>>>
>>
>>> - I tried to open in another tab the "Add new entry" :)
>>
>> I know, but I didn't want to spend time on this (read the URL fragment
>> on page load and show the dialog).
>>
>>>
>>> - "Edit class" is not working - takes me to the WYSIWYG
>>>
>>> - "Add new entry" works, but the new page is not displayed in the
>> livetable
>>>
>>>
>>
>
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
>>>
>>
>>> Marius, very nice work. Hope my feedback will help you.
>>
>> It helps. Thanks,
>> Marius
>>
>>>
>>> Thanks,
>>> Caty
>>>
>>>
>>> On Sun, Nov 27, 2011 at 14:25, Marius Dumitru Florea <
>>> mariusdumitru.florea(a)xwiki.com> wrote:
>>>
>>>> Hi devs,
>>>>
>>>> I just committed a first version of the AppWithinMinutes wizard. If
>>>> you want to try it then download the latest XE 3.3 snapshot and visit
>>>> AppWithinMinutes.CreateApplication page.
>>>>
>>>> Waiting for feedback,
>>>> Marius