27 Oct
2009
27 Oct
'09
9:18 p.m.
Hi,
I've just noticed on trunk that now non admin users can only see a few
classes in the object editor: some Blog classes and the Panel Class.
Is that normal? I don't remember when we decided this.
Thanks
-Vincent
27 Oct
27 Oct
10:29 p.m.
Hi,
On Tue, Oct 27, 2009 at 9:18 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi,
I've just noticed on trunk that now non admin users can only see a few
classes in the object editor: some Blog classes and the Panel Class.
Is that normal? I don't remember when we decided this.
That sounds weird given I don't recall any discussion about this either.
Could a commit of XWiki.XWikiPreferences have slipped with specific rights
object attached to it that should not have been there?
Anyway, I think users with edit rights should be allowed to see all existing
objects in the object editor.
Guillaume
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Guillaume Lerouge
Product Manager - XWiki SAS
Skype: wikibc
Twitter: glerouge
http://guillaumelerouge.com/
28 Oct
28 Oct
11:29 a.m.
Ok it seems this was done by Sergiu in rev 18828 for issue
"XAPANELS-77: Improve class and object editor panels"
The AddObject panel was modified to have this check:
#foreach ($classname in $xwiki.classList)
#if($!xwiki.hasAccessLevel("edit", $classname))
...
Thus only Objects for which the user has edit rights on the Class name
are listed.
Is that what we want? It doesn't sound quite right to me.
Thanks
-Vincent
On Oct 27, 2009, at 9:18 PM, Vincent Massol wrote:
Hi,
I've just noticed on trunk that now non admin users can only see a
few classes in the object editor: some Blog classes and the Panel
Class.
Is that normal? I don't remember when we decided this.
Thanks
-Vincent
11:30 a.m.
On Oct 28, 2009, at 11:29 AM, Vincent Massol wrote:
Ok it seems this was done by Sergiu in rev 18828 for
issue
"XAPANELS-77: Improve class and object editor panels"
The AddObject panel was modified to have this check:
#foreach ($classname in $xwiki.classList)
#if($!xwiki.hasAccessLevel("edit", $classname))
...
Thus only Objects for which the user has edit rights on the Class
name are listed.
Is that what we want? It doesn't sound quite right to me.
BTW that's why users on cannot add macros, plugins, etc anymore on
code.xwiki.org I think.
-Vincent
Thanks
-Vincent
On Oct 27, 2009, at 9:18 PM, Vincent Massol wrote:
Hi,
I've just noticed on trunk that now non admin users can only see a
few classes in the object editor: some Blog classes and the Panel
Class.
Is that normal? I don't remember when we decided this.
Thanks
-Vincent
12:06 p.m.
Hi,
On Wed, Oct 28, 2009 at 11:30 AM, Vincent Massol <vincent(a)massol.net> wrote:
On Oct 28, 2009, at 11:29 AM, Vincent Massol wrote:
I would rather say that if the user can view the Object's Class and has edit
right on the target page he should be allowed to add that object to the
page. For instance an user might not be able to edit the BlogArticle class
yet want to add a blog article object to a page...
Looks like a regression to me.
Guillaume
Ok it seems this was done by Sergiu in rev 18828
for issue
"XAPANELS-77: Improve class and object editor panels"
The AddObject panel was modified to have this check:
#foreach ($classname in $xwiki.classList)
#if($!xwiki.hasAccessLevel("edit", $classname))
...
Thus only Objects for which the user has edit rights on the Class
name are listed.
Is that what we want? It doesn't sound quite right to me.
BTW that's why users on cannot add macros,
plugins, etc anymore on
code.xwiki.org I think.
-Vincent
--
Guillaume Lerouge
Product Manager - XWiki SAS
Skype: wikibc
Twitter: glerouge
http://guillaumelerouge.com/
Thanks
-Vincent
On Oct 27, 2009, at 9:18 PM, Vincent Massol wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Hi,
I've just noticed on trunk that now non admin users can only see a
few classes in the object editor: some Blog classes and the Panel
Class.
Is that normal? I don't remember when we decided this.
Thanks
-Vincent
12:10 p.m.
On Wed, Oct 28, 2009 at 11:29, Vincent Massol <vincent(a)massol.net> wrote:
Ok it seems this was done by Sergiu in rev 18828 for
issue
"XAPANELS-77: Improve class and object editor panels"
The AddObject panel was modified to have this check:
#foreach ($classname in $xwiki.classList)
#if($!xwiki.hasAccessLevel("edit", $classname))
That does not make sense, a user should be able to add an object even
if he can't modify the class.
...
Thus only Objects for which the user has edit rights on the Class name
are listed.
Is that what we want? It doesn't sound quite right to me.
Thanks
-Vincent
On Oct 27, 2009, at 9:18 PM, Vincent Massol wrote:
--
Thomas Mortagne
Hi,
I've just noticed on trunk that now non admin users can only see a
few classes in the object editor: some Blog classes and the Panel
Class.
Is that normal? I don't remember when we decided this.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
12:13 p.m.
On Oct 28, 2009, at 12:10 PM, Thomas Mortagne wrote:
On Wed, Oct 28, 2009 at 11:29, Vincent Massol
<vincent(a)massol.net>
wrote:
I've created http://jira.xwiki.org/jira/browse/XAPANELS-95
Waiting for Sergiu's input. He must have had some reason for doing this.
Thanks
-Vincent
Ok it seems this was done by Sergiu in rev 18828
for issue
"XAPANELS-77: Improve class and object editor panels"
The AddObject panel was modified to have this check:
#foreach ($classname in $xwiki.classList)
#if($!xwiki.hasAccessLevel("edit", $classname))
That does not make sense, a user should be able to add an object even
if he can't modify the class. > ...
>
> Thus only Objects for which the user has edit rights on the Class
> name
> are listed.
>
> Is that what we want? It doesn't sound quite right to me.
>
> Thanks
> -Vincent
>
> On Oct 27, 2009, at 9:18 PM, Vincent Massol wrote:
>
>> Hi,
>>
>> I've just noticed on trunk that now non admin users can only see a
>> few classes in the object editor: some Blog classes and the Panel
>> Class.
>>
>> Is that normal? I don't remember when we decided this.
>>
>> Thanks
>> -Vincent
29 Oct
29 Oct
4:41 a.m.
On 10/28/2009 12:13 PM, Vincent Massol wrote:
On Oct 28, 2009, at 12:10 PM, Thomas Mortagne wrote:
Yes, a really good reason: copy/paste. That check was supposed to be
just in the class editor, for the "edit another class" select.
On Wed, Oct 28, 2009 at 11:29, Vincent
Massol<vincent(a)massol.net>
wrote:
I've created http://jira.xwiki.org/jira/browse/XAPANELS-95
Waiting for Sergiu's input. He must have had some reason for doing this. Ok it seems this was done by Sergiu in rev 18828
for issue
"XAPANELS-77: Improve class and object editor panels"
The AddObject panel was modified to have this check:
#foreach ($classname in $xwiki.classList)
#if($!xwiki.hasAccessLevel("edit", $classname))
That does not make sense, a user should be able to add an object even
if he can't modify the class. Thanks
-Vincent
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
> ...
>
> Thus only Objects for which the user has edit rights on the Class
> name
> are listed.
>
> Is that what we want? It doesn't sound quite right to me.
>
> Thanks
> -Vincent
>
> On Oct 27, 2009, at 9:18 PM, Vincent Massol wrote:
>
>> Hi,
>>
>> I've just noticed on trunk that now non admin users can only see a
>> few classes in the object editor: some Blog classes and the Panel
>> Class.
>>
>> Is that normal? I don't remember when we decided this.
>>
>> Thanks
>> -Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5495
days inactive
5497
days old
7 comments
4 participants
participants (4)
-
Guillaume Lerouge -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol