15 Jul
2009
15 Jul
'09
10:16 a.m.
Hi devs,
I have completed wiki macro bridge implementation but there are few things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need to
be moved into /platform/core/trunk/xwiki-properties
2. Need to commit the xwiki-application-wiki-macro-bridge under
/platform/xwiki-applications/trunk/wiki-macro-bridge. This application hosts
XWiki.WikiMacroClass and XWiki.WikiMacroParameterClass documents. For 2.0M3
we will remove this application and add initialization code that will
generate these two pages automatically.
3. Commit xwiki-core-rendering-macro-wikibridge under
/platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge
4. Make necessary dependancy changes so that XE will bundled with wiki-macro
support by default.
Here is my +1 for all of above.
Note that this is a quite large commit (had to refactor macros to use
xwiki-properties), there might be few places where my code can be improved.
Any comments are welcome.
Thanks.
- Asiri
15 Jul
15 Jul
10:30 a.m.
Asiri Rathnayake wrote:
Hi devs,
I have completed wiki macro bridge implementation but there are few things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need to
be moved into /platform/core/trunk/xwiki-properties
This should be a separate vote.
2. Need to commit the
xwiki-application-wiki-macro-bridge under
/platform/xwiki-applications/trunk/wiki-macro-bridge. This application hosts
XWiki.WikiMacroClass and XWiki.WikiMacroParameterClass documents. For 2.0M3
we will remove this application and add initialization code that will
generate these two pages automatically.
If this will be removed shortly, why not wait? I don't like creating an
application just so that it can be removed after a few days, since this
creates junk on jira, hudson, our maven repo...
Alternatively, we can keep the xar permanently, since it will contain a
nice UI for managing macros.
3. Commit xwiki-core-rendering-macro-wikibridge under
/platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge
Why is the app called wiki-macro-bridge when the module is called
macro-wikibridge?
4. Make necessary dependancy changes so that XE will
bundled with wiki-macro
support by default.
Here is my +1 for all of above.
Note that this is a quite large commit (had to refactor macros to use
xwiki-properties), there might be few places where my code can be improved.
Any comments are welcome.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
10:42 a.m.
Hi,
On Wed, Jul 15, 2009 at 2:00 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
Yes we can keep it and it will become handy as you say when authoring wiki
macors.
I find it hard to give an appropriate name :) Let me explain:
xwiki-core-rendering-macro-wikibridge is not itself a macro (unlike those
inside xwiki-rendering-macros) it's a bridge that allows creating macros
form wiki documents. But we could not find a better place to put this
module. So we decided to put it inside
xwiki-rendering/xwiki-rendering-macros/ and followed the macro module naming
convention which is xwiki-rendering-macro-(macroname)
The application itself contains the xwiki classes required for defining a
wiki macro. And it's not a macro, so we can't call it macro-wikibridge.
wiki-macro-bridge sounds more explanatory, so I went with it. Any
suggesstions?
Thanks.
- Asiri
Asiri Rathnayake wrote:
I forgot to mention. This module is required by wiki-macro-bridge. There was
a vote started by thomas long time ago to refactor macros to use this api
instead of BeanUtils but nobody voted for it. I thought it would not require
a seperate vote because it is a dependancy of wiki-macro-bridge.
Hi devs,
I have completed wiki macro bridge implementation but there are few
things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need
to
be moved into
/platform/core/trunk/xwiki-properties
This should be a separate vote. 2. Need to
commit the xwiki-application-wiki-macro-bridge under
/platform/xwiki-applications/trunk/wiki-macro-bridge. This application
hosts
XWiki.WikiMacroClass and
XWiki.WikiMacroParameterClass documents. For
2.0M3
we will remove this application and add
initialization code that will
generate these two pages automatically.
If this will be removed shortly, why not wait? I don't like creating an
application just so that it can be removed after a few days, since this
creates junk on jira, hudson, our maven repo...
Alternatively, we can keep the xar permanently, since it will contain a
nice UI for managing macros. 3. Commit
xwiki-core-rendering-macro-wikibridge under
/platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge
Why is the app called wiki-macro-bridge when the module is called
macro-wikibridge?
10:43 a.m.
On Wed, Jul 15, 2009 at 2:12 PM, Asiri Rathnayake <
asiri.rathnayake(a)gmail.com> wrote:
Hi,
On Wed, Jul 15, 2009 at 2:00 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
Correction: wiki-macro-bridge should be xwiki-rendering-macro-wikibridge.
- Asiri
Asiri Rathnayake wrote:
I forgot to mention. This module is required by wiki-macro-bridge. There
was a vote started by thomas long time ago to refactor macros to use this
api instead of BeanUtils but nobody voted for it. I thought it would not
require a seperate vote because it is a dependancy of wiki-macro-bridge.
Hi devs,
I have completed wiki macro bridge implementation but there are few
things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need
to
be moved into
/platform/core/trunk/xwiki-properties
This should be a separate vote. 
12:07 p.m.
On Wed, Jul 15, 2009 at 10:16, Asiri
Rathnayake<asiri.rathnayake(a)gmail.com> wrote:
Hi devs,
I have completed wiki macro bridge implementation but there are few things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need to
be moved into /platform/core/trunk/xwiki-properties
+1
2. Need to commit the xwiki-application-wiki-macro-bridge under
/platform/xwiki-applications/trunk/wiki-macro-bridge. This application hosts
XWiki.WikiMacroClass and XWiki.WikiMacroParameterClass documents. For 2.0M3
we will remove this application and add initialization code that will
generate these two pages automatically.
+0, same as Sergiu, if we have an application we should have some UI
in it, at least the list of wiki macros for example.
3. Commit xwiki-core-rendering-macro-wikibridge under
/platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge
+1
4. Make necessary dependancy changes so that XE will bundled with wiki-macro
support by default.
+1
Here is my +1 for all of above.
Note that this is a quite large commit (had to refactor macros to use
xwiki-properties), there might be few places where my code can be improved.
Any comments are welcome.
Thanks.
- Asiri
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
16 Jul
16 Jul
8:06 a.m.
+0
Thanks,
Marius
Asiri Rathnayake wrote:
Hi devs,
I have completed wiki macro bridge implementation but there are few things
that needs to be done inorder to commit it.
1. xwiki-properties module currently under sandbox (
http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-properties/) need to
be moved into /platform/core/trunk/xwiki-properties
2. Need to commit the xwiki-application-wiki-macro-bridge under
/platform/xwiki-applications/trunk/wiki-macro-bridge. This application hosts
XWiki.WikiMacroClass and XWiki.WikiMacroParameterClass documents. For 2.0M3
we will remove this application and add initialization code that will
generate these two pages automatically.
3. Commit xwiki-core-rendering-macro-wikibridge under
/platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge
4. Make necessary dependancy changes so that XE will bundled with wiki-macro
support by default.
Here is my +1 for all of above.
Note that this is a quite large commit (had to refactor macros to use
xwiki-properties), there might be few places where my code can be improved.
Any comments are welcome.
Thanks.
- Asiri
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5594
days inactive
5595
days old
5 comments
4 participants
participants (4)
-
Asiri Rathnayake -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne