On Mon, Mar 4, 2013 at 5:02 PM, Ecaterina Moraru (Valica)
<valicac(a)gmail.com> wrote:
Hi devs,
Our documentation
http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms is
requesting to use .buttonwrapper class as container for button
controls.
When I added this in the standard was because we were also supporting
Toucan Skin and in Toucan this was needed in order to have images on
buttons (it was an older skin and we needed to support IE6 and IE7).
Since we don't support Toucan anymore and now the CSS has advanced
that you can insert additional style by using the ':after' or
':before' pseudo-classes I don't think there is no reason to keep an
additional container.
I send this mail because Marius created a very sweet
Button Group
Widget in 4.5.1
Thanks :)
http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki451#HButt…
and he is using the .buttonwrapper container. I don't think we should
promote an additional container anymore.
I used it because it was in the standard but technically I don't need
it (I have my own button-group and dynamic-button-group classes). I'll
have to adjust the CSS if we drop it though.
Right now Colibri's CSS demand the 'buttonwrapper' in the style it has
both for inputs or for links. This could be changed for Colibri by
rewriting a bit those rules or by adding new ones (more specific but
would preserve backward compatibility).
I don't know if these changes should be kept for a new skin or added
now, so let me know what you think.
+1 to drop it, but I'm not sure if from Colibri too or just from Flamingo.
Thanks,
Marius
Thanks,
Caty
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs