9 May
2007
9 May
'07
7:14 a.m.
Hi,
1) In trunk, it's not possible to save without entering a comment. I
think this should be optional.
2) When clicking on save with no comment there's a dialog box that
pops up that asks for a comment but it's not possible to cancel it
even though there's a cancel button
Thanks
-Vincent
9 May
9 May
8:23 a.m.
New subject: [xwiki-dev] Problem with new comment on save feature
Hi,
These behavior are user configurable.. Maybe I did not put the right
default config in xwiki.cfg
With this config you are non intrusive..
## Use edit comments (activate/deactivate the whole feature)
xwiki.editcomment=1
## Hide editcomment field and only use JS (show/hide the field. 1 is hidden)
xwiki.editcomment.hidden=0
## Make edit comment mandatory (asks until the comment is not empty. 1
is mandatory. 0 means comment can be empty)
xwiki.editcomment.mandatory=0
## Make edit comment suggested (asks 1 time if the comment is empty. 1
shows one popup if comment is empty. 0 means there is no popup. This
setting is ignored is mandatory is set)
xwiki.editcomment.suggested=0
Ludovic
Vincent Massol a écrit :
Hi,
1) In trunk, it's not possible to save without entering a comment. I
think this should be optional.
2) When clicking on save with no comment there's a dialog box that
pops up that asks for a comment but it's not possible to cancel it
even though there's a cancel button
Thanks
-Vincent
------------------------------------------------------------------------
--
You receive this message as a subscriber of the xwiki-dev(a)objectweb.org mailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
--
Ludovic Dubost
Blog: http://www.ludovic.org/blog/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
AIM: nvludo Yahoo: ludovic
11:48 a.m.
New subject: [xwiki-dev] Problem with new comment on save feature
On May 9, 2007, at 10:23 AM, Ludovic Dubost wrote:
Hi,
These behavior are user configurable.. Maybe I did not put the
right default config in xwiki.cfg
With this config you are non intrusive..
ok I've changed the default to be less intrusive by default.
## Use edit comments (activate/deactivate the whole
feature)
xwiki.editcomment=1
## Hide editcomment field and only use JS (show/hide the field. 1
is hidden)
xwiki.editcomment.hidden=0
## Make edit comment mandatory (asks until the comment is not
empty. 1 is mandatory. 0 means comment can be empty)
xwiki.editcomment.mandatory=0
In that case the popup shouldn't have a cancel button I think as it's
misleading. WDYT?
## Make edit comment suggested (asks 1 time if the
comment is
empty. 1 shows one popup if comment is empty. 0 means there is no
popup. This setting is ignored is mandatory is set)
xwiki.editcomment.suggested=0
Thanks
-Vincent
Vincent Massol a écrit :
> Hi,
>
> 1) In trunk, it's not possible to save without entering a comment.
> I think this should be optional.
> 2) When clicking on save with no comment there's a dialog box that
> pops up that asks for a comment but it's not possible to cancel it
> even though there's a cancel button
>
> Thanks
> -Vincent
1:46 p.m.
New subject: [xwiki-dev] Problem with new comment on save feature
In that case the popup shouldn't have a cancel button I think as it's
misleading. WDYT?
I don't think you can do that with a standard javascript message box.
--
http://purl.org/net/sergiu
10 May
10 May
11:54 a.m.
New subject: [xwiki-dev] Problem with new comment on save feature
Sergiu Dumitriu wrote:
If you only want a pop-up message with one button, I believe the correct
javascript method to use is
alert("you are a turkey");
...all you can do is press ok :-)
Or am I answering the wrong question?
cheers :-)
Thomas
In that case the popup shouldn't have a cancel button I think as it's
misleading. WDYT?
I don't think you can do that with a standard javascript message box.
11 May
11 May
9:56 a.m.
New subject: [xwiki-dev] Problem with new comment on save feature
On May 10, 2007, at 1:54 PM, Thomas Drevon wrote:
Sergiu Dumitriu wrote:
If you only want a pop-up message with one button, I believe the
correct javascript method to use is
alert("you are a turkey");
...all you can do is press ok :-)
Or am I answering the wrong question?
yep that was exactly my thought.
Ludovic and Sergiu, are you ok with this?
Thanks
-Vincent
In that case the popup shouldn't have a cancel button I think as
it's
misleading. WDYT?
I don't think you can do that with a standard javascript message box.
6727
days inactive
6729
days old
5 comments
4 participants
participants (4)
-
Ludovic Dubost -
Sergiu Dumitriu -
Thomas Drevon -
Vincent Massol