13 Apr
2012
13 Apr
'12
5:43 p.m.
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB is ready). We
also need an event when the wiki is ready since in s a multiwiki environment when you
create a new wiki for example, you might need to init some stuff (like initialize
mandatory classes). It's also needed the first time a request comes in for a given
wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent and to send it in
XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
Note that I was tempted to have a WikiCreatedEvent event sent when creating a wiki but
that wouldn't fill the use case of initializing the wiki on the first request to it.
Thanks
-Vincent
13 Apr
13 Apr
5:47 p.m.
Vincent,
on IRC you had suggested me to use such an event.
I couldn't find it.
Is there an overview of such events?
thanks in advance
Paul
Le 13 avr. 2012 à 17:43, Vincent Massol a écrit :
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB is ready). We
also need an event when the wiki is ready since in s a multiwiki environment when you
create a new wiki for example, you might need to init some stuff (like initialize
mandatory classes). It's also needed the first time a request comes in for a given
wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent and to send it in
XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
Note that I was tempted to have a WikiCreatedEvent event sent when creating a wiki but
that wouldn't fill the use case of initializing the wiki on the first request to it.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5:54 p.m.
On Apr 13, 2012, at 5:47 PM, Paul Libbrecht wrote:
Vincent,
on IRC you had suggested me to use such an event.
I couldn't find it.
Each module can create events. For AppStarted/ReadyEvent they're currently in
commons-observation-api
Is there an overview of such events?
* Observation module:
http://extensions.xwiki.org/xwiki/bin/view/Extension/Observation+Module
* For events you need to check the javadoc for each module since each module can provides
its own events. There's no centralized place where all events are listed ATM.
Thanks
-Vincent
thanks in advance
Paul
Le 13 avr. 2012 à 17:43, Vincent Massol a écrit :
> Hi devs,
>
> We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB is ready).
We also need an event when the wiki is ready since in s a multiwiki environment when you
create a new wiki for example, you might need to init some stuff (like initialize
mandatory classes). It's also needed the first time a request comes in for a given
wiki.
>
> Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent and to send
it in XWiki.updateDatabase():
>
> ...
> synchronized (wikiName) {
> if (!wikiList.contains(wikiName)) {
> wikiList.add(wikiName);
>
> // Make sure these classes exists
> if (initClasses) {
> initializeMandatoryClasses(context);
> getPluginManager().virtualInit(context);
> getRenderingEngine().virtualInit(context);
> }
>
> --> send WikiReadyEvent here
>
> }
> }
>
> WDYT?
>
> Note that I was tempted to have a WikiCreatedEvent event sent when creating a wiki
but that wouldn't fill the use case of initializing the wiki on the first request to
it.
>
> Thanks
> -Vincent
14 Apr
14 Apr
12:13 a.m.
On Fri, Apr 13, 2012 at 6:47 PM, Paul Libbrecht <paul(a)hoplahup.net> wrote:
Vincent,
on IRC you had suggested me to use such an event.
I couldn't find it.
Is there an overview of such events?
That would indeed be a valueable piece of lore, specially for (but not
limited to) newcomers.
Thanks,
Eduard
thanks in advance
Paul
Le 13 avr. 2012 à 17:43, Vincent Massol a écrit :
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when
DB is
ready). We also need an event when the wiki is ready since in s a
multiwiki environment when you create a new wiki for example, you might
need to init some stuff (like initialize mandatory classes). It's also
needed the first time a request comes in for a given wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent
and to
send it in XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
Note that I was tempted to have a WikiCreatedEvent event sent when
creating a wiki
but that wouldn't fill the use case of initializing the
wiki on the first request to it.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
16 Apr
16 Apr
8:42 a.m.
The whole initialization listening business is quite tricky so I am:
+1 for WikiReadyEvent
but again I could be more informed with an overview
Can't this be created by collecting the relevant pointers to a javadoc?
paul
Le 14 avr. 2012 à 00:13, Eduard Moraru a écrit :
on IRC you had
suggested me to use such an event.
I couldn't find it.
Is there an overview of such events?
That would indeed be a valueable piece of lore, specially for (but not
limited to) newcomers.
17 Apr
17 Apr
9:49 a.m.
On Apr 14, 2012, at 12:13 AM, Eduard Moraru wrote:
On Fri, Apr 13, 2012 at 6:47 PM, Paul Libbrecht
<paul(a)hoplahup.net> wrote:
Eddy, there's an overview, it's at:
http://extensions.xwiki.org/xwiki/bin/view/Extension/Observation+Module
What's missing IMO is that each Module needs to document what Events it creates and
thus what event can be consumed by others. It's up to each module to document that.
For example the Model module should document all the model events (add/update/delete for
all Entities). Right now we have 2 model modules: xwiki-platform-oldcore and
xwiki-platform-model.
Right now we have http://extensions.xwiki.org/xwiki/bin/view/Extension/Model+Module and we
could either add doc for the oldcore there too or (better) create an oldcore module on
e.x.o.
Thanks
-Vincent
Vincent,
on IRC you had suggested me to use such an event.
I couldn't find it.
Is there an overview of such events?
That would indeed be a valueable piece of lore, specially for (but not
limited to) newcomers. Thanks,
Eduard
>
> thanks in advance
>
> Paul
>
>
> Le 13 avr. 2012 à 17:43, Vincent Massol a écrit :
>
>> Hi devs,
>>
>> We already have ApplicationStartedEvent and ApplicationReadyEvent (when
> DB is ready). We also need an event when the wiki is ready since in s a
> multiwiki environment when you create a new wiki for example, you might
> need to init some stuff (like initialize mandatory classes). It's also
> needed the first time a request comes in for a given wiki.
>>
>> Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent
> and to send it in XWiki.updateDatabase():
>>
>> ...
>> synchronized (wikiName) {
>> if (!wikiList.contains(wikiName)) {
>> wikiList.add(wikiName);
>>
>> // Make sure these classes exists
>> if (initClasses) {
>> initializeMandatoryClasses(context);
>> getPluginManager().virtualInit(context);
>> getRenderingEngine().virtualInit(context);
>> }
>>
>> --> send WikiReadyEvent here
>>
>> }
>> }
>>
>> WDYT?
>>
>> Note that I was tempted to have a WikiCreatedEvent event sent when
> creating a wiki but that wouldn't fill the use case of initializing the
> wiki on the first request to it.
>>
>> Thanks
>> -Vincent
3:09 p.m.
On Tue, Apr 17, 2012 at 10:49 AM, Vincent Massol <vincent(a)massol.net> wrote:
On Apr 14, 2012, at 12:13 AM, Eduard Moraru wrote:
Eddy, there's an overview, it's at:
http://extensions.xwiki.org/xwiki/bin/view/Extension/Observation+Module
Not talking about that.
On Fri, Apr 13, 2012 at 6:47 PM, Paul Libbrecht
<paul(a)hoplahup.net>
wrote:
Vincent,
on IRC you had suggested me to use such an event.
I couldn't find it.
Is there an overview of such events?
That would indeed be a valueable piece of lore, specially for (but not
limited to) newcomers.
What's missing IMO is that each Module needs to document what Events it
creates and thus what event can be consumed by others. It's up to each
module to document that.
For example the Model module should document all the model events
(add/update/delete for all Entities). Right now we have 2 model modules:
xwiki-platform-oldcore and xwiki-platform-model.
Right now we have
http://extensions.xwiki.org/xwiki/bin/view/Extension/Model+Module and we
could either add doc for the oldcore there too or (better) create an
oldcore module on e.x.o.
This is what I was referring to (same as Paul), though it would be much
more valuable if we could come up with a documentation scheme that could
offer a single entry point for all the vents (somehow aggregated from all
the other modules).
I know that it`s each module's task to document events (and other API
items), but an aggregated events documentation (or at least list with
"event -> module" items where to go for more details) would be great. You
can not assume everybody knows the code by heart.
Thanks,
Eduard
Thanks
-Vincent
Thanks,
Eduard
>
> thanks in advance
>
> Paul
>
>
> Le 13 avr. 2012 à 17:43, Vincent Massol a écrit :
>
>> Hi devs,
>>
>> We already have ApplicationStartedEvent and ApplicationReadyEvent (when
> DB is ready). We also need an event when the wiki is ready since in s a
> multiwiki environment when you create a new wiki for example, you might
> need to init some stuff (like initialize mandatory classes). It's also
> needed the first time a request comes in for a given wiki.
>>
>> Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent
> and to send it in XWiki.updateDatabase():
>>
>> ...
>> synchronized (wikiName) {
>> if (!wikiList.contains(wikiName)) {
>> wikiList.add(wikiName);
>>
>> // Make sure these classes exists
>> if (initClasses) {
>> initializeMandatoryClasses(context);
>> getPluginManager().virtualInit(context);
>> getRenderingEngine().virtualInit(context);
>> }
>>
>> --> send WikiReadyEvent here
>>
>> }
>> }
>>
>> WDYT?
>>
>> Note that I was tempted to have a WikiCreatedEvent event sent when
> creating a wiki but that wouldn't fill the use case of initializing the
> wiki on the first request to it.
>>
>> Thanks
>> -Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
14 Apr
14 Apr
12:12 a.m.
Hi,
On Fri, Apr 13, 2012 at 6:43 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB
is ready). We also need an event when the wiki is ready since in s a
multiwiki environment when you create a new wiki for example, you might
need to init some stuff (like initialize mandatory classes). It's also
needed the first time a request comes in for a given wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent
and to send it in XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
+1. I could have used that on the annotations migrator instead of
ApplicationReadyEvent.
Thanks,
Eduard
Note that I was tempted to have a WikiCreatedEvent event sent when
creating a wiki but that wouldn't fill the use case of initializing the
wiki on the first request to it.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9:40 a.m.
On Apr 14, 2012, at 12:12 AM, Eduard Moraru wrote:
Hi,
On Fri, Apr 13, 2012 at 6:43 PM, Vincent Massol <vincent(a)massol.net> wrote:
Does it mean you're not using a Migrator?
Thanks
-Vincent
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB
is ready). We also need an event when the wiki is ready since in s a
multiwiki environment when you create a new wiki for example, you might
need to init some stuff (like initialize mandatory classes). It's also
needed the first time a request comes in for a given wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent
and to send it in XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
+1. I could have used that on the annotations migrator instead of
ApplicationReadyEvent. Thanks,
Eduard
>
> Note that I was tempted to have a WikiCreatedEvent event sent when
> creating a wiki but that wouldn't fill the use case of initializing the
> wiki on the first request to it.
>
> Thanks
> -Vincent
17 Apr
17 Apr
3:14 p.m.
On Sat, Apr 14, 2012 at 10:40 AM, Vincent Massol <vincent(a)massol.net> wrote:
On Apr 14, 2012, at 12:12 AM, Eduard Moraru wrote:
Does it mean you're not using a Migrator?
A poor choice of words on my side. I was actually talking about this
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwi…
targeted the currently configured annotations class.
For the rest, yes, I`ve used a migrator (migration 40001:
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwi…).
Thanks,
Eduard
Hi,
On Fri, Apr 13, 2012 at 6:43 PM, Vincent Massol <vincent(a)massol.net>
wrote:
> Hi devs,
>
> We already have ApplicationStartedEvent and ApplicationReadyEvent (when
DB
is
ready). We also need an event when the wiki is ready since in s a
multiwiki environment when you create a new wiki for example, you might
need to init some stuff (like initialize mandatory classes). It's also
needed the first time a request comes in for a given wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent
and to send it in XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
+1. I could have used that on the annotations migrator instead of
ApplicationReadyEvent.
Thanks
-Vincent
Thanks,
Eduard
>
> Note that I was tempted to have a WikiCreatedEvent event sent when
> creating a wiki but that wouldn't fill the use case of initializing the
> wiki on the first request to it.
>
> Thanks
> -Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
14 Apr
14 Apr
10:11 a.m.
+0
Thanks,
Marius
On Fri, Apr 13, 2012 at 6:43 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB is ready). We
also need an event when the wiki is ready since in s a multiwiki environment when you
create a new wiki for example, you might need to init some stuff (like initialize
mandatory classes). It's also needed the first time a request comes in for a given
wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent and to send it in
XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
Note that I was tempted to have a WikiCreatedEvent event sent when creating a wiki but
that wouldn't fill the use case of initializing the wiki on the first request to it.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
15 Apr
15 Apr
9:52 p.m.
On Fri, Apr 13, 2012 at 5:43 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi devs,
We already have ApplicationStartedEvent and ApplicationReadyEvent (when DB is ready). We
also need an event when the wiki is ready since in s a multiwiki environment when you
create a new wiki for example, you might need to init some stuff (like initialize
mandatory classes). It's also needed the first time a request comes in for a given
wiki.
Thus I propose to add a WikiReadyEvent next to ApplicationStartedEvent and to send it in
XWiki.updateDatabase():
...
synchronized (wikiName) {
if (!wikiList.contains(wikiName)) {
wikiList.add(wikiName);
// Make sure these classes exists
if (initClasses) {
initializeMandatoryClasses(context);
getPluginManager().virtualInit(context);
getRenderingEngine().virtualInit(context);
}
--> send WikiReadyEvent here
}
}
WDYT?
+1
Note that I was tempted to have a WikiCreatedEvent event sent when creating a wiki but
that wouldn't fill the use case of initializing the wiki on the first request to it.
There is a WikiCreatedEvent event already.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
4588
days inactive
4592
days old
11 comments
5 participants
participants (5)
-
Eduard Moraru -
Marius Dumitru Florea -
Paul Libbrecht -
Thomas Mortagne -
Vincent Massol