On Thu, Apr 14, 2016 at 5:43 PM, Vincent Massol <vincent(a)massol.net> wrote: Serialized document reference uses backslash to escape special characters which breaks the URL in Tomcat for security reasons.

See http://jira.xwiki.org/browse/XWIKI-11528 for the rationale behind it. I was trying to avoid backslash (from the serialized attachment reference) in the URL. _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 14 Apr 2016, at 18:46, Vincent Massol <vincent(a)massol.net> wrote: Yes, it’s both.

Thanks -Vincent > >>> This is based on the existing TemporaryResourceReference at: >>> >>> https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… >>> >>> For example: >>> >>> http:// >>> <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>> >>> Note that in this example from the officeviewer macro the module-dependent >>> resource path consists in: >>> >> >> >>> - base64(name of office attachment + hashcode(parameters)) >>> >> >> See http://jira.xwiki.org/browse/XWIKI-11528 for the rationale behind it. I >> was trying to avoid backslash (from the serialized attachment reference) in >> the URL. >> >> >>> - generated image name from PPT >>> >>> In this case, the implementation would generate the following file: >>> >>> >>> [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>> >>> WDYT? >>> >>> Thanks >>> -Vincent

FTR http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#Security -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 14 Apr 2016, at 17:55, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt; wrote: On Thu, Apr 14, 2016 at 4:52 PM, Marius Dumitru Florea &lt;mariusdumitru.florea(a)xwiki.com&gt; wrote: Badly configured Tomcat does not like slash but are you sure about backslash ? -- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

ok I’m going to implement this format, using the URL serializer/resolver that I’ve committed. Note that the URL format shouldn’t matter that much since it’s an internal format that we can change later on if we want. Let me know quickly if you don’t agree. Thanks -Vincent reference>/<module-dependent resource path> wrote: wrote: the characters backslash ? https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg module-dependent it. I reference) in [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

@Thomas: are you ok with the proposed format: http://<server>/<context>/tmp/<module id>/<serialized owner document reference>/<module-dependent resource path> ? Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 19 Apr 2016, at 10:25, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: As I mentioned in my previous mail we don’t need to consider it a reference to a document. We could just make it a reference to anything. The module using the tmp service would know what type of reference it is and it could cast it to a document reference if it knows it’s that.

BTW this means that my URL entity reference serializer/resolver are no useful for this ;) (they’d still be useful for the “reference” url scheme though). We could simply take a String an replace the “/“ and “\” with some other symbols and do the same when parsing the URL.. So the generic format would be: http://<server>/<context>/tmp/<module id>/<serialized reference/id representing the resource>/<module-dependent resource path> The <serialized reference/id representing the resource> wouldn’t be able to be empty though since <module-dependent resource path> is non-fixed length (e.g. “a/b/c”). WDYT? Thanks -Vincent > Now one job of the tmp resource is also to check access right so we > need to pass it an entity reference on which to test the right when a > right check is required. The alternative being to end up with the > reference both in the path (to avoir collisions) and as some URL > parameter which is not nice I guess what you propose it ok as long as > empty reference is supported (i.e. don't test the right and just go > return the file associated to the path) as in > http://mydomain/xwiki/tmp/mymodule//I/don't/care/about/right.png > > Making the tmp resource generic enough to be just an entry point for > calling some module which then do whatever it wants would just be a > duplicate of resource handler framework but maybe we just don't really > need this anymore central temp resource entry point since now that we > have a generic resource handler framework ? > > On Fri, Apr 15, 2016 at 9:26 AM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >> @Thomas: are you ok with the proposed format: >> >> http://<server>/<context>/tmp/<module id>/<serialized owner document reference>/<module-dependent resource path> >> >> ? >> >> Thanks >> -Vincent >> >>> On 14 Apr 2016, at 17:55, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt; wrote: >>> >>> On Thu, Apr 14, 2016 at 4:52 PM, Marius Dumitru Florea >>> &lt;mariusdumitru.florea(a)xwiki.com&gt; wrote: >>>> On Thu, Apr 14, 2016 at 5:43 PM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>> >>>>> Hi devs, >>>>> >>>>> I’m implementing http://jira.xwiki.org/browse/XWIKI-10375 ("Refactor the >>>>> temporary resource concept inside the Resource module”) and I need to >>>>> define a URL format for the new “tmp” resource type. >>>>> >>>>> I’m proposing the following: >>>>> >>>>> >>>> >>>>> http://<server>/<context>/tmp/<module id>/<serialized owner document >>>>> reference>/<module-dependent resource path> >>>>> >>>> >>>> Serialized document reference uses backslash to escape special characters >>>> which breaks the URL in Tomcat for security reasons. >>> >>> Badly configured Tomcat does not like slash but are you sure about backslash ? >>> >>>> >>>> >>>>> >>>>> This is based on the existing TemporaryResourceReference at: >>>>> >>>>> https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… >>>>> >>>>> For example: >>>>> >>>>> http:// >>>>> <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>>> >>>>> Note that in this example from the officeviewer macro the module-dependent >>>>> resource path consists in: >>>>> >>>> >>>> >>>>> - base64(name of office attachment + hashcode(parameters)) >>>>> >>>> >>>> See http://jira.xwiki.org/browse/XWIKI-11528 for the rationale behind it. I >>>> was trying to avoid backslash (from the serialized attachment reference) in >>>> the URL. >>>> >>>> >>>>> - generated image name from PPT >>>>> >>>>> In this case, the implementation would generate the following file: >>>>> >>>>> >>>>> [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>>> >>>>> WDYT? >>>>> >>>>> Thanks >>>>> -Vincent

On 19 Apr 2016, at 12:47, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt; wrote: On Tue, Apr 19, 2016 at 10:28 AM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: Yes, which is why I said in my previous mail that we can't really get rid of it. Extending what I started to express in my previous mail: IMO we should stop trying to make /tmp/ the ultimate generic temporary resource provider, we can live with something dedicated to providing a filesystem file associated to an entity and test access based on this entity. Any module that have another use case can easily bypass /tmp/ and provide its own resource reference handler. Making /tmp/ super generic just ends up reinventig a new (and more complex from what I can see in the proposals) resource reference handler framework. I'm even removing my comment about empty entity. That means: http://<server>/<context>/tmp/<entitytype>:<entity reference>/<module-dependent resource path> It's easy to support any resource reference instead of the entity reference later just by changing the meaning of <entitytype> into <resourcetype> so we don't really need to deal with it now.

The path is already module dependent so no need to add a module related element in the URL scheme IMO. We can indicate that a good practice for custom modules resources is to start the path with some module unique identifier but it does not really need to have any special meaning in the URL itself.

Exactly like module that manipulate permanent and temporary directories don't get a dedicated folder, they just decide to put their stuff in some mymodule/ subforlder (or not).

Thanks > -Vincent > >> BTW this means that my URL entity reference serializer/resolver are no useful for this ;) (they’d still be useful for the “reference” url scheme though). We could simply take a String an replace the “/“ and “\” with some other symbols and do the same when parsing the URL.. >> >> So the generic format would be: >> >> http://<server>/<context>/tmp/<module id>/<serialized reference/id representing the resource>/<module-dependent resource path> >> >> The <serialized reference/id representing the resource> wouldn’t be able to be empty though since <module-dependent resource path> is non-fixed length (e.g. “a/b/c”). >> >> WDYT? >> >> Thanks >> -Vincent >> >>> Now one job of the tmp resource is also to check access right so we >>> need to pass it an entity reference on which to test the right when a >>> right check is required. The alternative being to end up with the >>> reference both in the path (to avoir collisions) and as some URL >>> parameter which is not nice I guess what you propose it ok as long as >>> empty reference is supported (i.e. don't test the right and just go >>> return the file associated to the path) as in >>> http://mydomain/xwiki/tmp/mymodule//I/don't/care/about/right.png >>> >>> Making the tmp resource generic enough to be just an entry point for >>> calling some module which then do whatever it wants would just be a >>> duplicate of resource handler framework but maybe we just don't really >>> need this anymore central temp resource entry point since now that we >>> have a generic resource handler framework ? >>> >>> On Fri, Apr 15, 2016 at 9:26 AM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>> @Thomas: are you ok with the proposed format: >>>> >>>> http://<server>/<context>/tmp/<module id>/<serialized owner document reference>/<module-dependent resource path> >>>> >>>> ? >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> On 14 Apr 2016, at 17:55, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt; wrote: >>>>> >>>>> On Thu, Apr 14, 2016 at 4:52 PM, Marius Dumitru Florea >>>>> &lt;mariusdumitru.florea(a)xwiki.com&gt; wrote: >>>>>> On Thu, Apr 14, 2016 at 5:43 PM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>>>> >>>>>>> Hi devs, >>>>>>> >>>>>>> I’m implementing http://jira.xwiki.org/browse/XWIKI-10375 ("Refactor the >>>>>>> temporary resource concept inside the Resource module”) and I need to >>>>>>> define a URL format for the new “tmp” resource type. >>>>>>> >>>>>>> I’m proposing the following: >>>>>>> >>>>>>> >>>>>> >>>>>>> http://<server>/<context>/tmp/<module id>/<serialized owner document >>>>>>> reference>/<module-dependent resource path> >>>>>>> >>>>>> >>>>>> Serialized document reference uses backslash to escape special characters >>>>>> which breaks the URL in Tomcat for security reasons. >>>>> >>>>> Badly configured Tomcat does not like slash but are you sure about backslash ? >>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> This is based on the existing TemporaryResourceReference at: >>>>>>> >>>>>>> https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… >>>>>>> >>>>>>> For example: >>>>>>> >>>>>>> http:// >>>>>>> <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>>>>> >>>>>>> Note that in this example from the officeviewer macro the module-dependent >>>>>>> resource path consists in: >>>>>>> >>>>>> >>>>>> >>>>>>> - base64(name of office attachment + hashcode(parameters)) >>>>>>> >>>>>> >>>>>> See http://jira.xwiki.org/browse/XWIKI-11528 for the rationale behind it. I >>>>>> was trying to avoid backslash (from the serialized attachment reference) in >>>>>> the URL. >>>>>> >>>>>> >>>>>>> - generated image name from PPT >>>>>>> >>>>>>> In this case, the implementation would generate the following file: >>>>>>> >>>>>>> >>>>>>> [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent

On 19 Apr 2016, at 14:23, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt; wrote: On Tue, Apr 19, 2016 at 1:14 PM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: Actually we do have a parser for this since this syntax already exist for String to EntityReference automatic conversion in Velocity scripts. See https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwi…. You could move this in a EnityReferenceResolver and use the resolver in the converter if you prefer.

You can't really decide later to add a prefix without breaking the URL scheme. When you already have a prefix you can add other prefixes without breaking anything.

The right API being already EntityReference based it's just about converting the String to an EntityReference instead of a DocumentReference. As long as the choice is on module side it's never really fully safe but sure it's a bit safer. My point was more that for some core stuff we may not need any module id, producing simpler URL, but sure we can always find some module id that make sense. According to this logic it means we need to refactor the Environment API accordingly. Same thing for configurations and translations in which property names are up to each module which usually put itself as property name prefix but could forget, etc.

Thanks > -Vincent > >> Thanks >>> -Vincent >>> >>>> BTW this means that my URL entity reference serializer/resolver are no useful for this ;) (they’d still be useful for the “reference” url scheme though). We could simply take a String an replace the “/“ and “\” with some other symbols and do the same when parsing the URL.. >>>> >>>> So the generic format would be: >>>> >>>> http://<server>/<context>/tmp/<module id>/<serialized reference/id representing the resource>/<module-dependent resource path> >>>> >>>> The <serialized reference/id representing the resource> wouldn’t be able to be empty though since <module-dependent resource path> is non-fixed length (e.g. “a/b/c”). >>>> >>>> WDYT? >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> Now one job of the tmp resource is also to check access right so we >>>>> need to pass it an entity reference on which to test the right when a >>>>> right check is required. The alternative being to end up with the >>>>> reference both in the path (to avoir collisions) and as some URL >>>>> parameter which is not nice I guess what you propose it ok as long as >>>>> empty reference is supported (i.e. don't test the right and just go >>>>> return the file associated to the path) as in >>>>> http://mydomain/xwiki/tmp/mymodule//I/don't/care/about/right.png >>>>> >>>>> Making the tmp resource generic enough to be just an entry point for >>>>> calling some module which then do whatever it wants would just be a >>>>> duplicate of resource handler framework but maybe we just don't really >>>>> need this anymore central temp resource entry point since now that we >>>>> have a generic resource handler framework ? >>>>> >>>>> On Fri, Apr 15, 2016 at 9:26 AM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>>>> @Thomas: are you ok with the proposed format: >>>>>> >>>>>> http://<server>/<context>/tmp/<module id>/<serialized owner document reference>/<module-dependent resource path> >>>>>> >>>>>> ? >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> On 14 Apr 2016, at 17:55, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt; wrote: >>>>>>> >>>>>>> On Thu, Apr 14, 2016 at 4:52 PM, Marius Dumitru Florea >>>>>>> &lt;mariusdumitru.florea(a)xwiki.com&gt; wrote: >>>>>>>> On Thu, Apr 14, 2016 at 5:43 PM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>>>>>> >>>>>>>>> Hi devs, >>>>>>>>> >>>>>>>>> I’m implementing http://jira.xwiki.org/browse/XWIKI-10375 ("Refactor the >>>>>>>>> temporary resource concept inside the Resource module”) and I need to >>>>>>>>> define a URL format for the new “tmp” resource type. >>>>>>>>> >>>>>>>>> I’m proposing the following: >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>>> http://<server>/<context>/tmp/<module id>/<serialized owner document >>>>>>>>> reference>/<module-dependent resource path> >>>>>>>>> >>>>>>>> >>>>>>>> Serialized document reference uses backslash to escape special characters >>>>>>>> which breaks the URL in Tomcat for security reasons. >>>>>>> >>>>>>> Badly configured Tomcat does not like slash but are you sure about backslash ? >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> This is based on the existing TemporaryResourceReference at: >>>>>>>>> >>>>>>>>> https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… >>>>>>>>> >>>>>>>>> For example: >>>>>>>>> >>>>>>>>> http:// >>>>>>>>> <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>>>>>>> >>>>>>>>> Note that in this example from the officeviewer macro the module-dependent >>>>>>>>> resource path consists in: >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> - base64(name of office attachment + hashcode(parameters)) >>>>>>>>> >>>>>>>> >>>>>>>> See http://jira.xwiki.org/browse/XWIKI-11528 for the rationale behind it. I >>>>>>>> was trying to avoid backslash (from the serialized attachment reference) in >>>>>>>> the URL. >>>>>>>> >>>>>>>> >>>>>>>>> - generated image name from PPT >>>>>>>>> >>>>>>>>> In this case, the implementation would generate the following file: >>>>>>>>> >>>>>>>>> >>>>>>>>> [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>>>>>>> >>>>>>>>> WDYT? >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent

mariusdumitru.florea(a)xwiki.com&gt; wrote: wrote: the

Yes but the same is true whether you have “A\.B.C” or "/A\.B/C”.

That’s not a blocking issue anyway since we can easily transform them into other characters when we serialized and do the opposite when we parse the URL. https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg module-dependent it. I in

Yes. However the image name “Company Presentation-slide0” could also contain slash or backlashes too.

Note that I wasn’t sure why you you didn’t compute the base64 of both the name of attachment + the parameters instead of having 2 directory levels consisting in the base64 of the attachment name + the hashcode of the parameters as different path segments. Need to check XWIKI-11528, maybe it’s there. IMO we need to treat all path segments in the same way and convert slash and backslash into some other characters. I’m not sure we need the base64 solution. But anyway this is an implementation detail of the officeviewer module and not really related to the discussion of the generic Temporary URL format. Thanks -Vincent [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

mariusdumitru.florea(a)xwiki.com&gt; wrote: wrote: characters than that What do you propose? (I’ve sent another mail explaining why having the reference serialized as different path segments is an issue)

We could also implement a different document reference resolver/serializer for URLs so that the escape symbol is not “\”. Actually maybe this would be the best and would be useful in several places.

WDYT? Thanks -Vincent into the https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg reference) the base64 officeviewer [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 15 Apr 2016, at 11:00, Eduard Moraru &lt;enygma2002(a)gmail.com&gt; wrote: Hi, Re http://<server>/<context>/tmp/<module id>/<serialized owner document reference>/<module-dependent resource path> 1. What determines this <module id>? What about collisions between extensions not knowing about eachother?

2. Are all these temporary resources bound to a document? What about the ones that are not? They would use some random doc reference there? Would that matter?

As far as I see it, after http://<server>/<context>/tmp/<module id>/ we can have pretty much anything (i.e. <module-dependent resource path>), depending on the app's needs. Alternatively, this being a generic service, maybe we can assign a random ID on request and keep a mapping in a separate table.

We could even drop the <module id> from the URL and store it in the table instead (as a column). The idea would be that we would not need to expose all these "coordinates" in the actual URL and pollute it with the logic of each individual module, but only use a generic random (unique) ID since it`s a temporary resource anyway. Also, being a separate DB table, the data will not be available on an export since it`s temporary anyway. What is left, IMO, is a way to clean this temporary data. On the DB table side, we can always clean the table data on startup and the URLs will be gone, however we would need a way to also actually delete the corresponding temporary files and that may be dependant on the module`s logic. Anyway, WDYT about this direction so far, with using simply http://<server>/<context>/tmp/<resource id>?

Thanks, Eduard On Fri, Apr 15, 2016 at 11:30 AM, Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com&gt; wrote: > On Thu, Apr 14, 2016 at 7:46 PM, Vincent Massol &lt;vincent(a)massol.net&gt; > wrote: > >> >>> On 14 Apr 2016, at 16:52, Marius Dumitru Florea < >> mariusdumitru.florea(a)xwiki.com&gt; wrote: >>> >>> On Thu, Apr 14, 2016 at 5:43 PM, Vincent Massol &lt;vincent(a)massol.net&gt; >> wrote: >>> >>>> Hi devs, >>>> >>>> I’m implementing http://jira.xwiki.org/browse/XWIKI-10375 ("Refactor >> the >>>> temporary resource concept inside the Resource module”) and I need to >>>> define a URL format for the new “tmp” resource type. >>>> >>>> I’m proposing the following: >>>> >>>> >>> >>>> http://<server>/<context>/tmp/<module id>/<serialized owner document >>>> reference>/<module-dependent resource path> >>>> >>> >>> Serialized document reference uses backslash to escape special > characters >>> which breaks the URL in Tomcat for security reasons. >> >> > >> Yes but the same is true whether you have “A\.B.C” or "/A\.B/C”. >> > > WDYM? The dot is escaped in the space name with a backslash only when the > space name is serialized as a reference, which is not the case for the > standard wiki page URL /xwiki/bin/view/Space.With.Dot/Page.With.Dot > > Having a slash or a backslash in the space or page name is less common than > having a dot ("Version 1.2"). And the user might be willing to accept that > having a backslash in the page (or attachment's) name can cause security > issues with Tomcat, but I doubt he will accept to avoid dots. > > >> That’s not a blocking issue anyway since we can easily transform them > into >> other characters when we serialized and do the opposite when we parse the >> URL. >> >>> This is based on the existing TemporaryResourceReference at: >>>> >>>> >> > https://github.com/xwiki/xwiki-platform/blob/96caad053c14fc5546e9bc141bc284… >>>> >>>> For example: >>>> >>>> http:// >>>> >> > <server>/<context>/tmp/officeviewer/A.B.WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>> >>>> Note that in this example from the officeviewer macro the >> module-dependent >>>> resource path consists in: >>>> >>> >>> >>>> - base64(name of office attachment + hashcode(parameters)) >>>> >>> >>> See http://jira.xwiki.org/browse/XWIKI-11528 for the rationale behind >> it. I >>> was trying to avoid backslash (from the serialized attachment > reference) >> in >>> the URL. >> >> > >> Yes. However the image name “Company Presentation-slide0” could also >> contain slash or backlashes too. >> > > It could but it's less common, especially because most Operating Systems > are not very friendly with these characters when used in file or folder > names. > > >> >> Note that I wasn’t sure why you you didn’t compute the base64 of both the >> name of attachment + the parameters instead of having 2 directory levels >> consisting in the base64 of the attachment name + the hashcode of the >> parameters as different path segments. Need to check XWIKI-11528, maybe >> it’s there. >> >> IMO we need to treat all path segments in the same way and convert slash >> and backslash into some other characters. I’m not sure we need the base64 >> solution. But anyway this is an implementation detail of the officeviewer >> module and not really related to the discussion of the generic Temporary >> URL format. >> >> Thanks >> -Vincent >> >>> - generated image name from PPT >>>> >>>> In this case, the implementation would generate the following file: >>>> >>>> >>>> >> > [TMPDIR]/officeviewer/A/B/WebHome/Q29tcGFueSBQcmVzZW50YXRpb24ucHB0/Company+Presentation-slide0.jpg >>>> >>>> WDYT? >>>> >>>> Thanks >>>> -Vincent