I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content. I didn't find these functions used anywhere else in platform. These are the functions I would like to deprecate: XWikiAttachment public void setArchive(Archive archive) public Archive getArchive() XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive) WDYT? Caleb _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content. I didn't find these functions used anywhere else in platform. These are the functions I would like to deprecate: XWikiAttachment public void setArchive(Archive archive) public Archive getArchive() XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive) WDYT? Caleb