Hi, I can't reproduce this locally. All build fine for me.

On Sat, Feb 26, 2011 at 12:19, Vincent Massol <vincent(a)massol.net> wrote: > Hi Thomas, > > FYI the build is failing on the xwiki10 parser syntax tests (links3.test): > > junit.framework.ComparisonFailure: null > Expected :[[http:~~/~~/reference>>reference]] [[*not bold*>>reference]] > Actual :[[http:~~/~~/reference>>reference]] [[**not bold**>>reference]] > at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:159) > at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:106) > at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) > at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) > > Seems like non bold is transformed into bold now. > > Any ide? > > Thanks > -Vincent

I wanted to check on hudson but looks like the agent-2 is in a very bad shape. I even restarted it but it does not change anything... On Sat, Feb 26, 2011 at 12:45, Vincent Massol <vincent(a)massol.net> wrote: -- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Ok I know what is the issue I think. LinkSyntaxFilter and BoldSyntaxFilter have the same priority and depending on the version of the jdk or something they will not appear in the same order. You probably change the java version you use with maven or something like that. LinkSyntaxFilter should have an higher priority, I will will that now and it should be ok for you. On Sat, Feb 26, 2011 at 17:42, Vincent Massol <vincent(a)massol.net> wrote: -- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Just committed, let me know if it's working for you now if you have some time.

On Sat, Feb 26, 2011 at 18:39, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: > Indeed, BoldSyntaxFilter is executed before LinkSyntaxFilter here. > > I haven't changed my JDK AFAIK but yes you're probably right about the order: we need to change the priority to ensure the LinkSyntaxFilter gets executed before most other filters. > > Thanks > -Vincent > > On Feb 26, 2011, at 6:34 PM, Thomas Mortagne wrote: > >> Ok I know what is the issue I think. LinkSyntaxFilter and >> BoldSyntaxFilter have the same priority and depending on the version >> of the jdk or something they will not appear in the same order. You >> probably change the java version you use with maven or something like >> that. >> >> LinkSyntaxFilter should have an higher priority, I will will that now >> and it should be ok for you. >> >> On Sat, Feb 26, 2011 at 17:42, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>> hmm it seems the problem is that the BoldSyntaxFilter matches the bold syntax when in a link label. >>> >>> private static final Pattern BOLDSYNTAX_PATTERN = >>> Pattern.compile("(?<!\\*)\\*([^\\p{Space}](?:[^*\n]*+|\\*)*?(?<=[^\\p{Space}]))\\*(?!\\*)"); >>> >>> Matches >>> >>> [*notbold*>reference] >>> >>> Thus it's put in the FilterContext as some wiki syntax to be protected. >>> >>> I've tested it on http://www.regexplanet.com/simple/ and it says it matches. >>> >>> I have no idea why this is coming up now though since I can't find any recent commits in this area. >>> >>> Ideas? >>> >>> Thanks >>> -Vincent >>> >>> On Feb 26, 2011, at 12:49 PM, Thomas Mortagne wrote: >>> >>>> I wanted to check on hudson but looks like the agent-2 is in a very >>>> bad shape. I even restarted it but it does not change anything... >>>> >>>> On Sat, Feb 26, 2011 at 12:45, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>>> >>>>> On Feb 26, 2011, at 12:39 PM, Thomas Mortagne wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I can't reproduce this locally. All build fine for me. >>>>> >>>>> Strange, I don't have local changes. >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> On Sat, Feb 26, 2011 at 12:19, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: >>>>>>> Hi Thomas, >>>>>>> >>>>>>> FYI the build is failing on the xwiki10 parser syntax tests (links3.test): >>>>>>> >>>>>>> junit.framework.ComparisonFailure: null >>>>>>> Expected :[[http:~~/~~/reference>>reference]] [[*not bold*>>reference]] >>>>>>> Actual :[[http:~~/~~/reference>>reference]] [[**not bold**>>reference]] >>>>>>> at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:159) >>>>>>> at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:106) >>>>>>> at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) >>>>>>> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) >>>>>>> >>>>>>> Seems like non bold is transformed into bold now. >>>>>>> >>>>>>> Any ide? >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent