Hello developers, I seem to see a regression whereby a POST to an /xwiki/bin/upload/ request no more uses the xredirect parameter and simply redirects to the page. Is this a known change? Is it supposed to have been working being undocumented and can try to find a fix? Or should I simply try to adjust the client (tremble tremble). thanks in advance

Hello Sergiu, yes, I can reproduce this. I am running xwiki 3.5 (with one patch which I'll hope will be 3.5.1. We have CURRIKI-5771 open for this. I don't have a one shot reproduction but I can debug on my dev machine to see it in more details. As far as I can debug, the problem is that getFileItemSize returns 0 although firebug tells me the parameter is non-empty (and that code, a static html of the TinyMCE editor) was unchanged. I am suspecting a charset issue but again, this was unchanged,

thanks Paul Le 3 mai 2012 à 19:36, Sergiu Dumitriu a écrit : > On 05/03/2012 01:29 PM, Sergiu Dumitriu wrote: >> On 05/03/2012 12:08 PM, Paul Libbrecht wrote: >>> >>> Hello developers, >>> >>> I seem to see a regression whereby a POST to an /xwiki/bin/upload/ >>> request no more uses the xredirect parameter and simply redirects to >>> the page. >>> >>> Is this a known change? >>> Is it supposed to have been working being undocumented and can try to >>> find a fix? >>> Or should I simply try to adjust the client (tremble tremble). >>> >>> thanks in advance >> >> If it indeed doesn't work, then it's an involuntary regression. I'll >> check the code. >> > > Well, the code still tries to look at that parameter: > > String redirect = fileupload.getFileItemAsString("xredirect", context); > > So it might be a problem at the request parsing stage, introduced by an upgrade of a dependency. Still, IIRC the attachment selector macro makes heavy use of the redirect, and it does work correctly. > > On which version did you notice this? Could you double-check if it indeed is broken?