[xwiki-devs] [VOTE] Use current database instead of current document database in Current*ReferenceResolver
8 Feb
2010
8 Feb
'10
6:17 p.m.
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
--
Thomas Mortagne
8 Feb
8 Feb
6:19 p.m.
On Mon, Feb 8, 2010 at 18:17, Thomas Mortagne <thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
All Current*ReferenceResolver except
CurrentMixedStringDocumentReferenceResolver which is a special
backward compatibility resolver.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
--
Thomas Mortagne
--
Thomas Mortagne
9 Feb
9 Feb
5:26 p.m.
+0
Thanks,
Marius
Thomas Mortagne wrote:
On Mon, Feb 8, 2010 at 18:17, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
All Current*ReferenceResolver except
CurrentMixedStringDocumentReferenceResolver which is a special
backward compatibility resolver.
Problem is that we generally use context wiki as
the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
--
Thomas Mortagne
8 Feb
8 Feb
6:34 p.m.
On Feb 8, 2010, at 6:17 PM, Thomas Mortagne wrote:
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
Yes but that's why the Current Mixed resolver was created....
However it was created as a backward compatibility resolver and we actually need the
current wiki for valid use cases (not just for backward compat) so +1 from me.
If you plan to do this before the 2.2 release then you should to do a search to see where
current resolvers are used and verify it's not going to cause any problem in the
existing code.
Thanks
-Vincent
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
--
Thomas Mortagne
6:56 p.m.
On Mon, Feb 8, 2010 at 18:34, Vincent Massol <vincent(a)massol.net> wrote:
On Feb 8, 2010, at 6:17 PM, Thomas Mortagne wrote:
The main reason for Current Mixed resolver was mainly the special
handling of document name.
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
Yes but that's why the Current Mixed resolver was created....
However it was created as a backward compatibility resolver and we actually need the
current wiki for valid use cases (not just for backward compat) so +1 from me.
If you plan to do this before the 2.2 release then you should to do a search to see where
current resolvers are used and verify it's not going to cause any problem in the
existing code.
Thanks
-Vincent
--
Thomas Mortagne
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
6:58 p.m.
On Mon, Feb 8, 2010 at 18:34, Vincent Massol <vincent(a)massol.net> wrote:
On Feb 8, 2010, at 6:17 PM, Thomas Mortagne wrote:
IMO we already have issue we did not seen because of the way current
resolver works.
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
Yes but that's why the Current Mixed resolver was created....
However it was created as a backward compatibility resolver and we actually need the
current wiki for valid use cases (not just for backward compat) so +1 from me.
If you plan to do this before the 2.2 release then you should to do a search to see where
current resolvers are used and verify it's not going to cause any problem in the
existing code.
Thanks
-Vincent
--
Thomas Mortagne
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9 Feb
9 Feb
5:29 p.m.
On 2/8/10 6:17 PM, Thomas Mortagne wrote:
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
+0
Jerome.
5:43 p.m.
On 02/08/2010 06:17 PM, Thomas Mortagne wrote:
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
+1
Will it first try to use the current document, then the current wiki if
no current document exists?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
10 Feb
10 Feb
9:04 a.m.
On Tue, Feb 9, 2010 at 17:43, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
On 02/08/2010 06:17 PM, Thomas Mortagne wrote:
No, as it's said in the title it's about using current database
INSTEAD of current document database.
Hi devs,
Currently when the reference does not contains any wiki name it's
resolved using the wiki of the current document.
Problem is that we generally use context wiki as the current wiki and
references used to be resolved that way before the refactoring using
official Resolver component.
In many places we set the wiki we want to work on before doing a bunch
of tasks: loading documents, executing queries etc... the problem is
that when Current*ReferenceResolver is used you have to create some
empty document and put it in the context just to set the wiki you want
to work on.
So i propose to change the behavior of all the
Current*ReferenceResolver to get context wiki as default wiki name.
Here is my +1
+1
Will it first try to use the current document, then the current wiki if
no current document exists?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
5429
days inactive
5431
days old
8 comments
5 participants
participants (5)
-
Jerome Velociter -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol