[xwiki-devs] [Brainstorming] What assignee do we put in JIRA when we apply PR from contributors?
4 Jul
2013
4 Jul
'13
8:21 p.m.
Hi devs,
I saw that Marius and Thomas put as assignee the contributor who created the PR today:
* http://jira.xwiki.org/browse/XWIKI-9316
* http://jira.xwiki.org/browse/XWIKI-9232
Thus I've done the same for:
* http://jira.xwiki.org/browse/XWIKI-7403
I was under the impression that till now we were always using a committer as the assignee
in JIRA. The main reason we were doing this is that it's the committed code becomes
the committer's responsibility in case the code causes some issues.
The cons are:
* Less recognition of the contributor (even though he appears in the SCM thanks to
GitHub's PR).
* He won't appear in the BFD reports. For example:
http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=11604
I'm fine either way but it would be good to have an agreement on what strategy we wish
to follow.
Thanks
-Vincent
4 Jul
4 Jul
8:32 p.m.
New subject: [xwiki-devs] [Brainstorming] What assignee do we put in JIRA when we apply PR from contributors?
On 07/04/2013 02:21 PM, Vincent Massol wrote:
Hi devs,
I saw that Marius and Thomas put as assignee the contributor who created the PR today:
* http://jira.xwiki.org/browse/XWIKI-9316
* http://jira.xwiki.org/browse/XWIKI-9232
Thus I've done the same for:
* http://jira.xwiki.org/browse/XWIKI-7403
I was under the impression that till now we were always using a committer as the assignee
in JIRA. The main reason we were doing this is that it's the committed code becomes
the committer's responsibility in case the code causes some issues.
The cons are:
* Less recognition of the contributor (even though he appears in the SCM thanks to
GitHub's PR).
* He won't appear in the BFD reports. For example:
http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=11604
I'm fine either way but it would be good to have an agreement on what strategy we
wish to follow.
Thanks
-Vincent
The assignee is the one responsible for the issue on the long term.
For me the committer is the one more likely to be the "long term"
person. A pull request might be a one-time contribution from someone
that disappears instantly after creating the PR. Although being credited
in the Jira filters is a good boost, it's not the only way to get
recognition, so it's not that important.
However, sometimes I do put the bugfixer as the assignee, when I
explicitly consider that the bugfixer will assume the responsibility,
and when I did almost nothing besides commiting the patch.
Perhaps we could add another field, besides reporter and assignee. I'm
not sure the extra effort/complexity would be that beneficial, though.
As a sidenote, GitHub's simple issue management only accepts a committer
for the assignee field.
--
Sergiu Dumitriu
http://purl.org/net/sergiu
8:34 p.m.
New subject: [xwiki-devs] [Brainstorming] What assignee do we put in JIRA when we apply PR from contributors?
On 07/04/2013 02:32 PM, Sergiu Dumitriu wrote:
On 07/04/2013 02:21 PM, Vincent Massol wrote:
Also, about BFD stats, did the PR authors work _today_ on those issues?
If it's been idle for a while and a committer looked at them during a
BFD, then it's the committer that spent time looking at bugs, not the
author.
--
Sergiu Dumitriu
http://purl.org/net/sergiu
Hi devs,
I saw that Marius and Thomas put as assignee the contributor who created the PR today:
* http://jira.xwiki.org/browse/XWIKI-9316
* http://jira.xwiki.org/browse/XWIKI-9232
Thus I've done the same for:
* http://jira.xwiki.org/browse/XWIKI-7403
I was under the impression that till now we were always using a committer as the assignee
in JIRA. The main reason we were doing this is that it's the committed code becomes
the committer's responsibility in case the code causes some issues.
The cons are:
* Less recognition of the contributor (even though he appears in the SCM thanks to
GitHub's PR).
* He won't appear in the BFD reports. For example:
http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=11604
I'm fine either way but it would be good to have an agreement on what strategy we
wish to follow.
Thanks
-Vincent
The assignee is the one responsible for the issue on the long term.
For me the committer is the one more likely to be the "long term"
person. A pull request might be a one-time contribution from someone
that disappears instantly after creating the PR. Although being credited
in the Jira filters is a good boost, it's not the only way to get
recognition, so it's not that important.
However, sometimes I do put the bugfixer as the assignee, when I
explicitly consider that the bugfixer will assume the responsibility,
and when I did almost nothing besides commiting the patch.
Perhaps we could add another field, besides reporter and assignee. I'm
not sure the extra effort/complexity would be that beneficial, though.
As a sidenote, GitHub's simple issue management only accepts a committer
for the assignee field.
5 Jul
5 Jul
8:17 a.m.
New subject: [xwiki-devs] [Brainstorming] What assignee do we put in JIRA when we apply PR from contributors?
On Thu, Jul 4, 2013 at 9:34 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
On 07/04/2013 02:32 PM, Sergiu Dumitriu wrote:
On 07/04/2013 02:21 PM, Vincent Massol wrote:
Hi devs,
I saw that Marius and Thomas put as assignee the contributor who created the PR today:
* http://jira.xwiki.org/browse/XWIKI-9316
* http://jira.xwiki.org/browse/XWIKI-9232
Thus I've done the same for:
* http://jira.xwiki.org/browse/XWIKI-7403
I was under the impression that till now we were always using a committer as the assignee
in JIRA. The main reason we were doing this is that it's the committed code becomes
the committer's responsibility in case the code causes some issues.
The cons are:
* Less recognition of the contributor (even though he appears in the SCM thanks to
GitHub's PR).
* He won't appear in the BFD reports. For example:
http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=11604
I'm fine either way but it would be good to have an agreement on what strategy we
wish to follow.
Thanks
-Vincent
The assignee is the one responsible for the issue on the long term.
For me the committer is the one more likely to be the "long term"
person. A pull request might be a one-time contribution from someone
that disappears instantly after creating the PR. Although being credited
in the Jira filters is a good boost, it's not the only way to get
recognition, so it's not that important.
However, sometimes I do put the bugfixer as the assignee, when I
explicitly consider that the bugfixer will assume the responsibility,
and when I did almost nothing besides commiting the patch.
Perhaps we could add another field, besides reporter and assignee. I'm
not sure the extra effort/complexity would be that beneficial, though.
As a sidenote, GitHub's simple issue management only accepts a committer
for the assignee field.
Also, about BFD stats, did the PR authors work _today_
on those issues?
If it's been idle for a while and a committer looked at them during a
BFD, then it's the committer that spent time looking at bugs, not the
author.
For XWIKI-9316 the work was done during BFD as the issue was reported
yesterday. But anyway, from a marketing POV it's better to have more
names on the BFD stats, and committers can get recognition in other
ways too so it's not that important that we don't appear with the
"full" number of issues closed.
Thanks,
Marius
--
Sergiu Dumitriu
http://purl.org/net/sergiu
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
8:05 a.m.
New subject: [xwiki-devs] [Brainstorming] What assignee do we put in JIRA when we apply PR from contributors?
On Thu, Jul 4, 2013 at 9:32 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
On 07/04/2013 02:21 PM, Vincent Massol wrote:
Hi devs,
I saw that Marius and Thomas put as assignee the contributor who created the PR today:
* http://jira.xwiki.org/browse/XWIKI-9316
* http://jira.xwiki.org/browse/XWIKI-9232
Thus I've done the same for:
* http://jira.xwiki.org/browse/XWIKI-7403
I was under the impression that till now we were always using a committer as the assignee
in JIRA. The main reason we were doing this is that it's the committed code becomes
the committer's responsibility in case the code causes some issues.
The cons are:
* Less recognition of the contributor (even though he appears in the SCM thanks to
GitHub's PR).
* He won't appear in the BFD reports. For example:
http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=11604
I'm fine either way but it would be good to have an agreement on what strategy we
wish to follow.
Thanks
-Vincent
The assignee is the one responsible for the issue on
the long term.
Yes, but merging the pull request gives you the same responsibility.
If the assignee is not around any more you can look at the Commits tab
to find the person that merged the pull request. What we need is to
clearly mark an issue as closed by a pull request. The "Pull Request
Status" custom field is missing an ending state "Pull request
applied".
For me the committer is the one more likely to be the "long term"
person. A pull request might be a one-time contribution from someone
that disappears instantly after creating the PR. Although being credited
in the Jira filters is a good boost, it's not the only way to get
recognition, so it's not that important.
Giving recognition by assigning the issue is important IMO. Besides
the morale boost it could make the contributor feel responsible for
the issue, as you said about the committer.
However, sometimes I do put the bugfixer as the assignee, when I
explicitly consider that the bugfixer will assume the responsibility,
and when I did almost nothing besides commiting the patch.
With pull requests you almost never do additional changes. You ask the
contributor to make those changes as it is easier to comment on his
lines of code.
Perhaps we could add another field, besides reporter and assignee. I'm
not sure the extra effort/complexity would be that beneficial, though.
I don't like this either.
Thanks,
Marius
As a sidenote, GitHub's simple issue management only accepts a committer
for the assignee field.
--
Sergiu Dumitriu
http://purl.org/net/sergiu
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
4091
days inactive
4092
days old
4 comments
3 participants
participants (3)
-
Marius Dumitru Florea -
Sergiu Dumitriu -
Vincent Massol