[xwiki-devs] Ratings Plugin porting to Components

List overview All Threads
Download

newer

older

[xwiki-devs] Fwd: Adding a...

[xwiki-devs] Issue with install on...

Ludovic Dubost

18 Jun 2013 18 Jun '13

8:24 a.m.

Hi, I have ported the ratings plugin to a component architecture and also to 4.5.x. Could some devs review the pom and apis before I make a release of it ? I mostly interested if the pom are correct for releasing. On the code itself, I don't think we can change the storage classes unless we are ready to loose compatibility with the previous plugin. But we could change the script service API if there are better choices. https://github.com/xwiki-contrib/application-ratings Thanks Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

Show replies by date

Thomas Mortagne

18 Jun 18 Jun

9:01 a.m.

Note that from Extension Manager point of view your application-ratings-api depends on several core extensions in version "4.5.4 or more" so you won't be able to install it in older versions of XE (or some other distribution with older core extensions). On Tue, Jun 18, 2013 at 8:24 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

...

-- Thomas Mortagne

Ludovic Dubost

9:40 a.m.

Right. This is actually important. How can we change this to extend the compatibility level. This is the same issue as the one we have for the xambox connector which cannot install on 4.5.3. It's hard to exactly know from which version the application is compatible without doing a lot of tests, but it's a bit annoying to have the installation blocked just because of these declarations. Ludovic 2013/6/18 Thomas Mortagne <thomas.mortagne(a)xwiki.com>

...

unless

we are ready to loose compatibility with the previous plugin. But we

could

change the script service API if there are better choices. https://github.com/xwiki-contrib/application-ratings Thanks Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

Thomas Mortagne

9:46 a.m.

On Tue, Jun 18, 2013 at 9:40 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

...

It's not very hard to do the right declarations, just indicate the minimum version you want your extension to work on.

...

Ludovic 2013/6/18 Thomas Mortagne <thomas.mortagne(a)xwiki.com>

unless

we are ready to loose compatibility with the previous plugin. But we

could

-- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne

Vincent Massol

9:03 a.m.

Hi Ludovic, On Jun 18, 2013, at 8:24 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

...

Hi, I have ported the ratings plugin to a component architecture and also to 4.5.x. Could some devs review the pom and apis before I make a release of it ?

I've reviewed the pom and fixed the issues I could see: https://github.com/xwiki-contrib/application-ratings/commit/b92244985049fdd… Thanks -Vincent PS: I haven't review the API part

...

I mostly interested if the pom are correct for releasing. On the code itself, I don't think we can change the storage classes unless we are ready to loose compatibility with the previous plugin. But we could change the script service API if there are better choices. https://github.com/xwiki-contrib/application-ratings Thanks Ludovic

Vincent Massol

9:10 a.m.

On Jun 18, 2013, at 9:03 AM, Vincent Massol <vincent(a)massol.net> wrote:

...

Hi Ludovic, On Jun 18, 2013, at 8:24 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

Hi, I have ported the ratings plugin to a component architecture and also to 4.5.x. Could some devs review the pom and apis before I make a release of it ?

I've reviewed the pom and fixed the issues I could see: https://github.com/xwiki-contrib/application-ratings/commit/b92244985049fdd…

One note: you have 1.3-SNAPSHOT so it means it's the continuation of some previous versions… Where are they released? I've checked on e.x.o and I see: * org.xwiki.contrib:xwiki-ratings-application (this is a different id from the new org.xwiki.contrib.ratings:application-ratings-ui. Thus I've just added an alias: https://github.com/xwiki-contrib/application-ratings/commit/e3217574da230f7… Thanks -Vincent

...

Thanks -Vincent PS: I haven't review the API part

Ludovic Dubost

9:36 a.m.

Correct. An alias was need for the continuity. The 1.3 is indeed a follow up for the xwiki-ratings-application but I'm not sure they were released properly. Ludovic 2013/6/18 Vincent Massol <vincent(a)massol.net>

...

On Jun 18, 2013, at 9:03 AM, Vincent Massol <vincent(a)massol.net> wrote:

Hi Ludovic, On Jun 18, 2013, at 8:24 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

Hi, I have ported the ratings plugin to a component architecture and also to 4.5.x. Could some devs review the pom and apis before I make a release of it ?

I've reviewed the pom and fixed the issues I could see:

https://github.com/xwiki-contrib/application-ratings/commit/b92244985049fdd… One note: you have 1.3-SNAPSHOT so it means it's the continuation of some previous versions… Where are they released? I've checked on e.x.o and I see: * org.xwiki.contrib:xwiki-ratings-application (this is a different id from the new org.xwiki.contrib.ratings:application-ratings-ui. Thus I've just added an alias: https://github.com/xwiki-contrib/application-ratings/commit/e3217574da230f7… Thanks -Vincent

Thanks -Vincent PS: I haven't review the API part > I mostly interested if the pom are correct for releasing. > > On the code itself, I don't think we can change the storage classes

unless

> we are ready to loose compatibility with the previous plugin. But we

could

change the script service API if there are better choices. https://github.com/xwiki-contrib/application-ratings Thanks Ludovic

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

Thomas Mortagne

9:38 a.m.

They were release in github at least, I can see the tags. On Tue, Jun 18, 2013 at 9:36 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

...

On Jun 18, 2013, at 9:03 AM, Vincent Massol <vincent(a)massol.net> wrote:

Hi Ludovic, On Jun 18, 2013, at 8:24 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:

Hi, I have ported the ratings plugin to a component architecture and also to 4.5.x. Could some devs review the pom and apis before I make a release of it ?

I've reviewed the pom and fixed the issues I could see:

Thanks -Vincent PS: I haven't review the API part > I mostly interested if the pom are correct for releasing. > > On the code itself, I don't think we can change the storage classes

unless

> we are ready to loose compatibility with the previous plugin. But we

could

change the script service API if there are better choices. https://github.com/xwiki-contrib/application-ratings Thanks Ludovic

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne

4204

days inactive

4204

days old

xwiki-devs@xwiki.org

Manage subscription

7 comments

3 participants

tags (0)

participants (3)

Ludovic Dubost
Thomas Mortagne
Vincent Massol