New subject: [xwiki-devs] [xwiki-notifications] r19510 - in platform: core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container core/trunk/xwiki-containers/xwiki-container-api/src/main/resources/META-INF/plexus core/trunk/xwiki-contain

11 May 2009

Hi Sergiu,

On Mon, May 11, 2009 at 12:46 PM, Sergiu Dumitriu &lt;sergiu(a)xwiki.com&gt; wrote:

...
  asiri (SVN) wrote:
  Author: asiri
 Date: 2009-05-07 21:16:03 +0200 (Thu, 07 May 2009)
 New Revision: 19510

 Added:

platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container/ApplicationContextListener.java

platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container/ApplicationContextListenerManager.java

platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container/DefaultApplicationContextListenerManager.java

platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice/OpenOfficeServerManagerApplicationContextListener.java
 > Modified:

platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/resources/META-INF/plexus/components.xml

platform/core/trunk/xwiki-containers/xwiki-container-portlet/src/main/java/org/xwiki/container/portlet/DefaultPortletContainerInitializer.java

platform/core/trunk/xwiki-containers/xwiki-container-portlet/src/main/resources/META-INF/plexus/components.xml

platform/core/trunk/xwiki-containers/xwiki-container-servlet/src/main/java/org/xwiki/container/servlet/DefaultServletContainerInitializer.java

platform/core/trunk/xwiki-containers/xwiki-container-servlet/src/main/java/org/xwiki/container/servlet/XWikiPlexusServletContextListener.java

platform/core/trunk/xwiki-containers/xwiki-container-servlet/src/main/resources/META-INF/plexus/components.xml

platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/XWikiPortlet.java

platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice/DefaultOpenOfficeServerConfiguration.java

platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice/DefaultOpenOfficeServerManager.java

platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/openoffice/OpenOfficeServerConfiguration.java

platform/core/trunk/xwiki-officeimporter/src/main/resources/META-INF/plexus/components.xml

platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
  Log:
 XWIKI-3710: Add support for automatically restarting OpenOffice server  when XE is
restarted
   > * Implemented.
   > Added:

platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container/DefaultApplicationContextListenerManager.java

===================================================================
 --- 
platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container/DefaultApplicationContextListenerManager.java
                          (rev 0)
  +++ 
platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container/DefaultApplicationContextListenerManager.java
  2009-05-07 19:16:03 UTC (rev 19510)

  +    public void
initializeApplicationContext(ApplicationContext  applicationContext)
  +    {
 +        try {
 +            List<ApplicationContextListener> initializers =
 +   componentManager.lookupList(ApplicationContextListener.class);
  +            for (ApplicationContextListener
initializer : initializers)  {

 I'd say that you should surround this line with a try catch block, so
 that a broken listener doesn't break the entire notification. 

By a broken listener you meant something like throwing a
NullPointerException or such?

Thanks.

- Asiri

Re: [xwiki-devs] [xwiki-notifications] r19510 - in platform: core/trunk/xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container core/trunk/xwiki-containers/xwiki-container-api/src/main/resources/META-INF/plexus core/trunk/xwiki-contain