[xwiki-devs] [Proposal] Prefix the database name used as class name on the document body to avoid conflict with other classes (XWIKI-5165)
5 May
2010
5 May
'10
5:08 p.m.
Hi devs,
Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org to 2.3),
we've face the <body> database className conflict again, on code.xwiki.org.
What happens is that the "code" DOM class name is apposed to the body element
(see htmlheader.vm), and this interferes with styles defined for the {{code}} macro.
Potentially there are other scenarios where class names can conflict with database names.
I propose we prefix the apposed class name with "wiki-" (that's what
we've been doing on xwiki.org for some time now) in order to avoid this.
Though, we need to agree on this, since it can be a breaking change for those who relied
on that "feature" to skin differently different wikis on a farm.
WDYT ?
Jerome.
5 May
5 May
5:29 p.m.
New subject: [xwiki-devs] [Proposal] Prefix the database name used as class name on the document body to avoid conflict with other classes (XWIKI-5165)
On Wed, May 5, 2010 at 17:08, Jerome Velociter <jerome(a)xwiki.com> wrote:
Hi devs,
Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org to 2.3),
we've face the <body> database className conflict again, on code.xwiki.org.
What happens is that the "code" DOM class name is apposed to the body element
(see htmlheader.vm), and this interferes with styles defined for the {{code}} macro.
Potentially there are other scenarios where class names can conflict with database names.
I propose we prefix the apposed class name with "wiki-" (that's what
we've been doing on xwiki.org for some time now) in order to avoid this.
Though, we need to agree on this, since it can be a breaking change for those who relied
on that "feature" to skin differently different wikis on a farm.
WDYT ?
I don't see anything wrong with "wiki-" (note that '-' is forbidden
by
wiki manager) so +1.
Jerome.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
7:19 p.m.
On 05/05/2010 05:08 PM, Jerome Velociter wrote:
Hi devs,
Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org to 2.3),
we've face the<body> database className conflict again, on code.xwiki.org.
What happens is that the "code" DOM class name is apposed to the body element
(see htmlheader.vm), and this interferes with styles defined for the {{code}} macro.
Potentially there are other scenarios where class names can conflict with database names.
I propose we prefix the apposed class name with "wiki-" (that's what
we've been doing on xwiki.org for some time now) in order to avoid this.
+1
Though, we need to agree on this, since it can be a
breaking change for those who relied on that "feature" to skin differently
different wikis on a farm.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
11:28 p.m.
New subject: [xwiki-devs] [Proposal] Prefix the database name used as class name on the document body to avoid conflict with other classes (XWIKI-5165)
+1
Denis
On Wed, May 5, 2010 at 19:19, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
On 05/05/2010 05:08 PM, Jerome Velociter wrote:
--
Denis Gervalle
SOFTEC sa - CEO
eGuilde sarl - CTO
Hi devs,
Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org
to 2.3),
we've face the<body> database className conflict again, on
code.xwiki.org.
What happens is that the "code" DOM class name is apposed to the body
element (see htmlheader.vm), and this interferes with styles defined for the
{{code}} macro. Potentially there are other scenarios where class names can
conflict with database names.
I propose we prefix the apposed class name with "wiki-" (that's what
we've been doing on xwiki.org for some time now) in order to avoid this.
+1
Though, we need to agree on this, since it can be
a breaking change for
those who relied on that "feature" to skin
differently different wikis on a
farm.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
6 May
6 May
11:27 a.m.
New subject: [xwiki-devs] [Proposal] Prefix the database name used as class name on the document body to avoid conflict with other classes (XWIKI-5165)
+1,
JV.
On Wed, May 5, 2010 at 5:08 PM, Jerome Velociter <jerome(a)xwiki.com> wrote:
Hi devs,
Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org to 2.3),
we've face the <body> database className conflict again, on code.xwiki.org.
What happens is that the "code" DOM class name is apposed to the body element
(see htmlheader.vm), and this interferes with styles defined for the {{code}} macro.
Potentially there are other scenarios where class names can conflict with database names.
I propose we prefix the apposed class name with "wiki-" (that's what
we've been doing on xwiki.org for some time now) in order to avoid this.
Though, we need to agree on this, since it can be a breaking change for those who relied
on that "feature" to skin differently different wikis on a farm.
WDYT ?
Jerome.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5344
days inactive
5345
days old
4 comments
5 participants
participants (5)
-
Denis Gervalle -
Jean-Vincent Drean -
Jerome Velociter -
Sergiu Dumitriu -
Thomas Mortagne