3 Jan
2010
3 Jan
'10
2:42 p.m.
Hi devs,
Caty suggested a while ago to allow the users to set custom logos in the
color theme. At first I thought this was not OK, since normally the logo
should be the same regardless of the site colors, but now I realize it's
a pretty good idea, because it ensures more flexibility, and, more
importantly, it allows to workaround transparency issues that appear in
some browsers (yes, I'm talking about IE6) by setting logos with the
same background color as the header.
The necessary changes would be:
- in "ColorThemes.ColorThemeClass" add a property called 'logo' whose
values are names of files attaches to the ColorTheme document
- in "global.vm", when searching for the wiki logo, start by looking in
the current ColorTheme, and, if not found, continue as before.
WDYT?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
3 Jan
3 Jan
2:51 p.m.
New subject: [xwiki-devs] [Proposal] Wiki logo as a property of the ColorTheme object
On Jan 3, 2010, at 2:42 PM, Sergiu Dumitriu wrote:
Hi devs,
Caty suggested a while ago to allow the users to set custom logos in
the
color theme. At first I thought this was not OK, since normally the
logo
should be the same regardless of the site colors, but now I realize
it's
a pretty good idea, because it ensures more flexibility, and, more
importantly, it allows to workaround transparency issues that appear
in
some browsers (yes, I'm talking about IE6) by setting logos with the
same background color as the header.
The necessary changes would be:
- in "ColorThemes.ColorThemeClass" add a property called 'logo' whose
values are names of files attaches to the ColorTheme document
- in "global.vm", when searching for the wiki logo, start by looking
in
the current ColorTheme, and, if not found, continue as before.
WDYT?
I'd agree but only if we remove the new notion of Color Theme and
instead replace it with a notion of Skin Theme (which is more generic
and better IMO since anything that can be customized should be in a
theme, it's not just colors).
We should also take the occasion to list other stuff that should be
customizable in a Skin Theme, if any (even if we only implement them
in the future). If we don't find anything else other than the logo
maybe we could keep the ColorTheme name (even though it's wrong). If
we find other areas we should probably find a migration path from
ColorTheme to SkinTheme.
Thanks
-Vincent
10 Feb
10 Feb
12:15 p.m.
New subject: [xwiki-devs] [Proposal] Wiki logo as a property of the ColorTheme object
Hi,
On Sun, Jan 3, 2010 at 2:51 PM, Vincent Massol <vincent(a)massol.net> wrote:
I agree but I don't think it's that important, it's just a matter of
wording.
What would be more important would be to make the "create new color theme"
button more prominent on the ColorTheme space homepage and make it even
easier to create a new theme (I know there's already something in the works
regarding this). Last, we'll need to link that space from somewhere in the
wiki (or maybe give it an administration section of its own).
Guillaume
On Jan 3, 2010, at 2:42 PM, Sergiu Dumitriu wrote:
Sounds good to me. I'm +1 to allow the user to define the logo in the
ColorTheme. It would make creating a custom look for your wiki much easier
by providing a unified location for the 2 most important parts, colors &
logo.
Hi devs,
Caty suggested a while ago to allow the users to set custom logos in
the
color theme. At first I thought this was not OK, since normally the
logo
should be the same regardless of the site colors, but now I realize
it's
a pretty good idea, because it ensures more flexibility, and, more
importantly, it allows to workaround transparency issues that appear
in
some browsers (yes, I'm talking about IE6) by setting logos with the
same background color as the header.
The necessary changes would be:
- in "ColorThemes.ColorThemeClass" add a property called 'logo' whose
values are names of files attaches to the ColorTheme document
- in "global.vm", when searching for the wiki logo, start by looking
in
the current ColorTheme, and, if not found, continue as before.
WDYT?
I'd agree but only if we remove the new notion of Color Theme and
instead replace it with a notion of Skin Theme (which is more generic
and better IMO since anything that can be customized should be in a
theme, it's not just colors).
We should also take the occasion to list other stuff
that should be
customizable in a Skin Theme, if any (even if we only implement them
in the future). If we don't find anything else other than the logo
maybe we could keep the ColorTheme name (even though it's wrong). If
we find other areas we should probably find a migration path from
ColorTheme to SkinTheme.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Guillaume Lerouge
Product Manager - XWiki SAS
Skype: wikibc
Twitter: glerouge
http://guillaumelerouge.com/
5385
days inactive
5423
days old
2 comments
3 participants
participants (3)
-
Guillaume Lerouge -
Sergiu Dumitriu -
Vincent Massol