Hi Jerome, On 09/21/2010 11:39 AM, Jerome Velociter wrote: We need to decide first if we include wiki macros in the standard XE distribution. AFAIK the policy was to offer only Java macros by default. I'll publish the office preview macro on code.xwiki.org first and then I'll send a vote to decide if we bundle it with XE by default. Thanks, Marius

Hi, On Tue, Sep 21, 2010 at 11:11, Thomas Mortagne <thomas.mortagne(a)xwiki.com>wrote;wrote: Yes, I think it's better. It will allow more flexibility for people willing to tweak the display of the preview. I've used the macro in its current state on a project and I had to modify it a bit to fit the needs of my users. Thus I think it's better this way. Guillaume

On Tue, Sep 21, 2010 at 11:44 AM, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com > On Tue, Sep 21, 2010 at 11:30, Guillaume Lerouge &lt;guillaume(a)xwiki.com&gt; > > Hi, > > > > On Tue, Sep 21, 2010 at 11:11, Thomas Mortagne < > thomas.mortagne(a)xwiki.com&gt;wroteote: > > > >> On Tue, Sep 21, 2010 at 11:01, Marius Dumitru Florea > >> &lt;mariusdumitru.florea(a)xwiki.com> >> > Hi Jerome, > >> > > >> > On 09/21/2010 11:39 AM, Jerome Velociter wrote: > >> >> Hi Marius > >> >> > >> >> On Tue, Sep 21, 2010 at 7:12 AM, Marius Dumitru Florea< > >> >> mariusdumitru.florea(a)xwiki.com&gt; wrote: > >> >> > >> >>> Hi devs, > >> >>> > >> >>> I'm going to continue Asiri's work on integrating officepreview > module > >> ( > >> >>> > >> http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-officepreview/ > >> >>> ) into the main source tree. Following the discussion at > >> >>> > >> >>> > >> > http://xwiki.475771.n2.nabble.com/Discussion-Integrating-officepreview-modu… > >> >>> here are the steps that need to be taken: > >> >>> > >> >>> * Extend DocumentAccessBridge with a method to get the current > version > >> >>> of an attachment in order to drop the dependency on xwiki-core: > >> >>> > >> >>> String getAttachmentVersion(AttachmentReference attachmentReference) > >> >>> > >> >>> * Convert OfficePreviewVelocityBridge to a ScriptService: > >> >>> > >> >>> $services.officepreview.preview($attachmentReference, $filterStyles) > >> >>> > >> >>> * Move /contrib/sandbox/xwiki-officepreview/ to > >> >>> /platform/core/xwiki-officepreview > >> >>> > >> >>> * Publish the office preview wiki macro on code.xwiki.org > >> >> > >> >> > >> >> Do we want it bundled by default in XE ? > >> >> > >> > > >> >> I'd say yes. > >> > > >> > We need to decide first if we include wiki macros in the standard XE > >> > distribution. AFAIK the policy was to offer only Java macros by > default. > >> > I'll publish the office preview macro on code.xwiki.org first and > then > >> > I'll send a vote to decide if we bundle it with XE by default. > >> > >> Does it really need to be a wiki macro ? > >> > > > > Yes, I think it's better. It will allow more flexibility for people > willing > > to tweak the display of the preview. I've used the macro in its current > > state on a project and I had to modify it a bit to fit the needs of my > > users. Thus I think it's better this way. > > If it's really needed i don't think there is counter indication to > have wiki macros in XE. It doesn't need programming right to be used > in a single wiki, it needs programming rights only to be used in a > whole farm. > +1, we have more and more use cases where wiki macros are suited (Anca was mentionning them for dashboard / gadgets, too). I think it's time we take the leap. Maybe need a separate vote, though. Jerome.

On Tue, Sep 21, 2010 at 12:24, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: Yes me to that's why i said "If it's really needed", i just wanted to said that there is no technical issue with wiki macro distributed with XE so it should not be part of the decision. -- Thomas Mortagne