Re: [xwiki-devs] [xwiki-notifications] r33381 - platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/simple/encoding - xwiki-devs@xwiki.org

14 Dec 2010

We need to be careful about this. This test proves that you've changed the behavior.

And changing the behavior is an important change. In this case Thomas and I had designed
the XHTML renderer so that its output would work with any encoding. I think this is no
longer true with your change in http://jira.xwiki.org/jira/browse/XWIKI-5763

To be honest, I'm a bit worried about that change unless you really know what you are
doing... especially in XE 2.7 which is the last minor release of the 2.x cycle.

Thanks
-Vincent

On Dec 14, 2010, at 4:23 PM, sdumitriu (SVN) wrote:

...
  Author: sdumitriu
 Date: 2010-12-14 16:23:00 +0100 (Tue, 14 Dec 2010)
 New Revision: 33381

 Modified:

platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/simple/encoding/encoding1.test
 Log:
 [misc] Disable a failing test until we decide what should be done with non-ASCII
characters

 Modified:
platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/simple/encoding/encoding1.test
 ===================================================================
 ---
platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/simple/encoding/encoding1.test	2010-12-14
14:51:26 UTC (rev 33380)
 +++
platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/simple/encoding/encoding1.test	2010-12-14
15:23:00 UTC (rev 33381)
 @@ -18,6 +18,7 @@
 endParagraph [[param1]=[val(((252)))e]]
 endDocument
 .#-----------------------------------------------------
 -.expect|xhtml/1.0
 +.expect|xhtml/1.0|skip
 +.# TODO: Re-enable this test once we reach a decision about non-ASCII characters
 .#-----------------------------------------------------
 <p>&nbsp;&#732;&#8364;</p><p
param1="val&#252;e">&nbsp;&#732;&#8364;</p> 