Hi everyone,
On Sep 8, 2007, at 8:57 PM, Catalin Hritcu wrote:
Author: hritcu
Date: 2007-09-08 20:57:32 +0200 (Sat, 08 Sep 2007)
New Revision: 4850
Added:
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/client/
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/client/SwizzleXWikiClient.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/client/XWikiClient.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/client/XWikiClientConversionException.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/client/XWikiClientException.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/client/XWikiClientRemoteException.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/Attachment.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/BlogEntry.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/BlogEntrySummary.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/Comment.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/Label.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/MapObject.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/Page.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/PageHistorySummary.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/PageSummary.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/Permission.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/RssFeed.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/SearchResult.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/ServerInfo.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/Space.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/SpaceSummary.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/User.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/UserInformation.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/AttachmentImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/BlogEntryImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/BlogEntrySummaryImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/CommentImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/LabelImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/PageHistorySummaryImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/PageImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/PageSummaryImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/PermissionImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/SearchResultImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/ServerInfoImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/SpaceImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/SpaceSummaryImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/UserImpl.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/model/swizzle/UserInformationImpl.java
Modified:
xwiki-platform/core/trunk/xwiki-core/pom.xml
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/ConfluenceRpcHandler.java
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
xmlrpc/DomainObjectFactory.java
xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-
tests/pom.xml
xwiki-products/xwiki-enterprise/trunk/distribution-test/xmlrpc-
tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AnonymousAccessTest.java
xwiki-products/xwiki-enterprise/trunk/distribution-test/xmlrpc-
tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AttachmentsTest.java
xwiki-products/xwiki-enterprise/trunk/distribution-test/xmlrpc-
tests/src/test/it/com/xpn/xwiki/it/xmlrpc/CommentsTest.java
xwiki-products/xwiki-enterprise/trunk/distribution-test/xmlrpc-
tests/src/test/it/com/xpn/xwiki/it/xmlrpc/PagesTest.java
xwiki-products/xwiki-enterprise/trunk/distribution-test/xmlrpc-
tests/src/test/it/com/xpn/xwiki/it/xmlrpc/SpacesTest.java
xwiki-products/xwiki-enterprise/trunk/distribution-test/xmlrpc-
tests/src/test/it/com/xpn/xwiki/it/xmlrpc/framework/
AbstractXmlRpcTestCase.java
Log:
XWIKI-1706: Use swizzle-confluence through a facade
I think the model classes should reflect more XWiki's concepts since
it's meant to abstract the implementation (swizzle).
For example the following don't look right to me: Blog*, Comment,
Label, Rss*. In XWiki they are all Objects. So I'd rather see an
Object class in the interface and possibly some verification on the
object type in the swizzle implementation to map them to swizzle
concepts.
This is very important and we need to agree on that before we can
release 1.2M1 since when we release it then this api is in the wild
and it'll be harder to change it.
What do others think?
Thanks
-Vincent