Re: [xwiki-devs] [xwiki-notifications] r13873 - in sandbox/xwiki-plugin-officeimporter/src: main/java/com/xpn/xwiki/plugin/officeimporter main/java/com/xpn/xwiki/plugin/officeimporter/core main/java/com/xpn/xwiki/plugin/officeimporter/filters test/ja
28 Oct
2008
28 Oct
'08
6:06 p.m.
Hi Vincent,
Ok, will revert those changes.
Btw, why I tried to use static methods instead of separate classes is
because those classes seemed to be doing very little. I mean those classes
were utilized like,
<code>
new TagRemoveFilter().doFilter(document);
new UnderlineLinkFilter().filter(document);
new XWikiSyntaxEscapeFilter().doFilter(document);
new ImageTagFilter().doFilter(document);
new PinLiFilter().doFilter(document);
new EmptyLinkFilter().doFilter(document);
</code>
That's all. Something didn't look right to me. And also it seems to clutter
the functionality into a lots of tiny classes.
Thanks.
- Asiri
28 Oct
28 Oct
6:14 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13873 - in sandbox/xwiki-plugin-officeimporter/src: main/java/com/xpn/xwiki/plugin/officeimporter main/java/com/xpn/xwiki/plugin/officeimporter/core main/java/com/xpn/xwiki/plugin/officeimporter/filters test/ja
Asiri Rathnayake wrote:
Hi Vincent,
Ok, will revert those changes.
Btw, why I tried to use static methods instead of separate classes is
because those classes seemed to be doing very little. I mean those classes
were utilized like,
<code>
new TagRemoveFilter().doFilter(document);
new UnderlineLinkFilter().filter(document);
new XWikiSyntaxEscapeFilter().doFilter(document);
new ImageTagFilter().doFilter(document);
new PinLiFilter().doFilter(document);
new EmptyLinkFilter().doFilter(document);
</code>
That's all. Something didn't look right to me. And also it seems to clutter
the functionality into a lots of tiny classes.
Listing implementations is wrong. Why not use components?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
6:19 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13873 - in sandbox/xwiki-plugin-officeimporter/src: main/java/com/xpn/xwiki/plugin/officeimporter main/java/com/xpn/xwiki/plugin/officeimporter/core main/java/com/xpn/xwiki/plugin/officeimporter/filters test/ja
On Oct 28, 2008, at 6:14 PM, Sergiu Dumitriu wrote:
Asiri Rathnayake wrote:
This would give the ability for anyone using the office importer to
plug new filters if it's required for some reasons.
Thanks
-Vincent
Hi Vincent,
Ok, will revert those changes.
Btw, why I tried to use static methods instead of separate classes is
because those classes seemed to be doing very little. I mean those
classes
were utilized like,
<code>
new TagRemoveFilter().doFilter(document);
new UnderlineLinkFilter().filter(document);
new XWikiSyntaxEscapeFilter().doFilter(document);
new ImageTagFilter().doFilter(document);
new PinLiFilter().doFilter(document);
new EmptyLinkFilter().doFilter(document);
</code>
That's all. Something didn't look right to me. And also it seems to
clutter
the functionality into a lots of tiny classes.
Listing implementations is wrong. Why not use components?
6:22 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13873 - in sandbox/xwiki-plugin-officeimporter/src: main/java/com/xpn/xwiki/plugin/officeimporter main/java/com/xpn/xwiki/plugin/officeimporter/core main/java/com/xpn/xwiki/plugin/officeimporter/filters test/ja
Vincent Massol wrote:
On Oct 28, 2008, at 6:14 PM, Sergiu Dumitriu wrote:
Also, why doFilter(doc) and not just filter(doc)?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
Asiri Rathnayake wrote:
This would give the ability for anyone using the office importer to
plug new filters if it's required for some reasons.
Hi Vincent,
Ok, will revert those changes.
Btw, why I tried to use static methods instead of separate classes is
because those classes seemed to be doing very little. I mean those
classes
were utilized like,
<code>
new TagRemoveFilter().doFilter(document);
new UnderlineLinkFilter().filter(document);
new XWikiSyntaxEscapeFilter().doFilter(document);
new ImageTagFilter().doFilter(document);
new PinLiFilter().doFilter(document);
new EmptyLinkFilter().doFilter(document);
</code>
That's all. Something didn't look right to me. And also it seems to
clutter
the functionality into a lots of tiny classes.
Listing implementations is wrong. Why not use components?
6:46 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13873 - in sandbox/xwiki-plugin-officeimporter/src: main/java/com/xpn/xwiki/plugin/officeimporter main/java/com/xpn/xwiki/plugin/officeimporter/core main/java/com/xpn/xwiki/plugin/officeimporter/filters test/ja
On Tue, Oct 28, 2008 at 10:52 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
Vincent Massol wrote:
Yes it is filter(). The doFilter() was reverted.
Thanks.
- Asiri
On Oct 28, 2008, at 6:14 PM, Sergiu Dumitriu
wrote:
Also, why doFilter(doc) and not just filter(doc)?
Asiri Rathnayake wrote:
This would give the ability for anyone using the office importer to
plug new filters if it's required for some reasons.
Hi Vincent,
Ok, will revert those changes.
Btw, why I tried to use static methods instead of separate classes is
because those classes seemed to be doing very little. I mean those
classes
were utilized like,
<code>
new TagRemoveFilter().doFilter(document);
new UnderlineLinkFilter().filter(document);
new XWikiSyntaxEscapeFilter().doFilter(document);
new ImageTagFilter().doFilter(document);
new PinLiFilter().doFilter(document);
new EmptyLinkFilter().doFilter(document);
</code>
That's all. Something didn't look right to me. And also it seems to
clutter
the functionality into a lots of tiny classes.
Listing implementations is wrong. Why not use components?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
6:39 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13873 - in sandbox/xwiki-plugin-officeimporter/src: main/java/com/xpn/xwiki/plugin/officeimporter main/java/com/xpn/xwiki/plugin/officeimporter/core main/java/com/xpn/xwiki/plugin/officeimporter/filters test/ja
On Oct 28, 2008, at 6:19 PM, Vincent Massol wrote:
On Oct 28, 2008, at 6:14 PM, Sergiu Dumitriu wrote:
Just one note. Making them components is possible (possibly overkill
although it might be good, I'm not sure). However what's important is
that you don't do the new *Filter() at every run. There should a
singleton component that has an initialization method (Initializable)
and that registers them once and for all.
Thanks
-Vincent
Asiri Rathnayake wrote:
This would give the ability for anyone using the office importer to
plug new filters if it's required for some reasons. Hi Vincent,
Ok, will revert those changes.
Btw, why I tried to use static methods instead of separate classes
is
because those classes seemed to be doing very little. I mean those
classes
were utilized like,
<code>
new TagRemoveFilter().doFilter(document);
new UnderlineLinkFilter().filter(document);
new XWikiSyntaxEscapeFilter().doFilter(document);
new ImageTagFilter().doFilter(document);
new PinLiFilter().doFilter(document);
new EmptyLinkFilter().doFilter(document);
</code>
That's all. Something didn't look right to me. And also it seems
to clutter
the functionality into a lots of tiny classes.
Listing implementations is wrong. Why not use components?
5802
days inactive
5802
days old
5 comments
3 participants
participants (3)
-
Asiri Rathnayake -
Sergiu Dumitriu -
Vincent Massol