Hi Simon, As I commented on https://github.com/xwiki/xwiki-platform/pull/1109 I think that most of the time you will want to use a scripting macro + HTML macro like this: {{velocity}} {{html clean="false"}} <div ...><!-- Some wrapping around the content that may depend on the macro parameters --> ... <!-- Output the macro content here so that it can be edited in-line in the WYSIWYG editor. --> ... </div> {{/html}} {{/velocity}} An example of such a macro could be: {{figure src="someImage.png"}}some description{{/figure}} The macro code would look like this: {{velocity}} {{html clean="false"}} <div class="figure"> <div class="figure-image-wrapper"> <img src="..." class="figure-image" /> </div> <div class="figure-caption"> <!-- Output the figure caption here so that it can be edited in-line in the WYSIWYG editor. --> </div> </div> {{/html}} {{/velocity}} I know you can output DIVs with wiki syntax but that's not the point. The point is that we want to use HTML for the UI and leave the wiki syntax for the user content. So I don't think ``wikimacrocontent`` is that useful (if it's only purpose is to help you output the ``non-generated-content`` DIV). Thanks, Marius On Tue, May 7, 2019 at 9:21 AM Simon Urli &lt;simon.urli(a)xwiki.com&gt; wrote: > Hi everyone, > > I'm currently working on allowing inline editing on new wikimacros. > My first challenge right now is to cope with the problem of inserting > the macro content and allowing to inline edit it. > > In order to do so, I propose to create two new dedicated macro: > - wikimacrocontent: would allow to insert and inline edit a wiki > macro content > - wikimacroparameter: the same for a parameter. > > The idea would be to be able to write something such as: > > {{velocity}} > {{wikimacrocontent/}} > This is a content of $xcontext.macro.content.length() characters. > {{/velocity}} > > So the purpose of those macros would be twofold: > 1. to ease the insertion of macro content/parameters (no need to > always use {{velocity}}$xcontext.macro.content{{/velocity}} > 2. to create the dedicated metadata around the content and to be > processed during wikimacro rendering to allow inline editing > > Of course those macro would be only to be used inside a wikimacro. > I started to develop the wikimacroccontent, so I have a first working > POC, but I'd like to know WDYT about this. > > I would also be really happy if you could give me some wikimacro > examples where the inline editing would make sense, so I could use it in > my tests. > > Thanks, > Simon > -- > Simon Urli > Software Engineer at XWiki SAS > simon.urli(a)xwiki.com > More about us at http://www.xwiki.com >

Hi Marius, all, On 08/05/2019 14:09, Marius Dumitru Florea wrote: so as Thomas mentioned in order to allow inline editing I also perform transformation on the generated list of blocks in DefaultWikiMacroRenderer to remove the macro marker that can cause troubles for inline editing. So the wikimacrocontent is used both to insert content, and to detect where to remove the macro markers during the transformation. Now right now even with this solution it's not possible to inline edit html macro because of the way it's designed: the HTML macro only create a raw blocks that contains all the html, so I cannot easily transform it for inline editing. IMO it requires a change in the HTML macro.

Simon

Hi Simon, Why only on wikimacros? We also need to be able to edit existing wikimacros to make them inline-editable.

I don’t understand. The content is "This is a content of $xcontext.macro.content.length() characters.” but it’s outside of “{{wikimacrocontent/}}”, is this a typo?

{{wikimacrocontent}} This is a content of $xcontext.macro.content.length() characters. {{/wikimacrocontent}} ? What is $xcontext.macro.content? I’ve never used that when writing wiki macros.

I don’t see any start/end. Why not: {{inlineEditable}} My content that is inline editable {{/inlineEditable}} ? Another approach is to use scripting, as in: $xcontext.macro.startInlineEditableContent() My content that is inline editable $xcontext.macro.stoptInlineEditableContent() Or using velocity macros: #startInlineEditableContent My content that is inline editable #stoptInlineEditableContent Yet another idea would be to have a macro xclass parameter to make the whole content inline editable (checkbox), and the 2 approaches above would be when you need fine-grained details (ie not have the whole content inline editable). Question: how is this done on other projects already using the concept of inline editable wiki macros? (I know one that I think you looked at Simon, but I don’t know how they did it :)).

Thanks -Vincent

Hi Simon, Right... Ah yes, my bad, I mixed up the macro code content and the macro usage content. Indeed, I now understand that we’re trying to make changes to the macro usage content. Now we need to take into account in the design the ability to provide some custom mapping between what you edit and how it modifies the usage content. For example, imagine the JIRA macro when using a static list of JIRA issues: {{jira url=“…”}} XWIKI-1000 XWIKI-1001 … {{/jira}} Or Imagine the {{gallery}} macro when used with static images: {{gallery}} img1 img2 {{/gallery}} In these 2 cases we’ll want some custom editors ideally and a custom serialization mechanism to generate back the modified content. This needs to be possible (pluggable) with the new APIs.

Note that in these 2 examples I’m mentioning “static” since it’s possible to use Velocity script around the macro. But in this case the outer macro becomes the {{velocity}} macro which will be inline editable only as text. Other examples are when the macro code script parses the content and would like to expose only some part of it as inline editable. This requires a way to mark some subpart as being inline editable and a custom serializer to reconstruct the modified content. yes was thinking about this. ok, maybe Ludovic was wrong then because I’m pretty sure he mentiopned that Denis was doing this with wiki macros. Thanks -Vincent