Sorry, I've forgot to put an email subject and to give my github ID.
My github ID : sbaloul.
Thank you in advance.
On Tue, Mar 4, 2014 at 10:53 AM, Sofiane Baloul <sofiane.baloul(a)xwiki.com>wrote:
> Hi dev community.
>
> I'm Sofiane Baloul, I have some experience in developing on XWiki
> plateform, I would express my interest in contributing and bringing some
> help on some XWiki projects especially on collaborative applications (
> https://github.com/xwiki-contrib ) at the begining.
>
> I've registered on jira.xwiki.org and I'm going to assigne to me some
> tasks
> related to XWiki Contributed Projects.
>
> Best regards.
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
Hi dev community.
I'm Sofiane Baloul, I have some experience in developing on XWiki
plateform, I would express my interest in contributing and bringing some
help on some XWiki projects especially on collaborative applications (
https://github.com/xwiki-contrib ) at the begining.
I've registered on jira.xwiki.org and I'm going to assigne to me some tasks
related to XWiki Contributed Projects.
Best regards.
Hi,
I have used $obj.set to update a dbList property value. But it selected
only the value I paased in the set method. All the previously selected
values were unselected. Can you help me to add/update the dbList property
retaining the previous selections.
Thanks,
Firmusoft
Hi guys,
Several of you have been updating deps on master for the past days/weeks and this has lead to the enterprise build failing because we’re now packaging duplicate classes!
See http://ci.xwiki.org/job/xwiki-enterprise/10740/consoleFull and search for "maven-duplicate-finder-plugin”
Some dups:
[WARNING] Found duplicate classes in [asm:asm:3.1,org.ow2.asm:asm:4.1]
[WARNING] Found duplicate classes in [jdom:jdom:1.0,org.jdom:jdom:1.1.3] :
[WARNING] Found duplicate classes in [org.bouncycastle:bcmail-jdk15:1.45,org.bouncycastle:bcmail-jdk15on:1.49] :
[WARNING] Found duplicate classes in [org.bouncycastle:bcmail-jdk15:1.45,org.bouncycastle:bcpkix-jdk15on:1.49] :
[WARNING] Found duplicate classes in [org.bouncycastle:bcpkix-jdk15on:1.49,org.bouncycastle:bcprov-jdk15:1.45] :
[WARNING] Found duplicate classes in [org.bouncycastle:bcprov-jdk15:1.45,org.bouncycastle:bcprov-jdk15on:1.49] :
[WARNING] Found duplicate classes in [org.codehaus.woodstox:stax2-api:3.1.1,org.codehaus.woodstox:wstx-asl:3.2.7] :
[WARNING] Found duplicate classes in [org.codehaus.woodstox:woodstox-core-asl:4.1.4,org.codehaus.woodstox:wstx-asl:3.2.7] :
[WARNING] Found duplicate classes in [org.restlet.jee:org.restlet:2.1.1,org.restlet.jse:org.restlet:2.0.14] :
Thanks for helping fix this.
-Vincent
Guys,
Last week we’ve had a deprecation-fixing day. I was worried about one thing and it seems it happened unfortunately. My worry was about breaking the build and introducing regressions.
I’ve just started testing XE very quickly and I’ve noticed in the course of few minutes 2 regressions already :(
* Regression 1: CSRF issue leading to a NPE when you execute XE. This wasn’t noticed for a full week! Correction was done today by GuillaumeD after I reported it (see https://github.com/xwiki/xwiki-platform/commit/bd007f28ee8c079d481c49455ceb…). Caused by https://github.com/xwiki/xwiki-platform/commit/77ebad8c6390dc4389d2de690ab5…
* Regression 2: Incude macro doesn’t work anymore when using the “document” parameter. The problem is that we’re still using that.. For example in Panels.NewPage: {{include document="Panels.PanelSheet"/}}. I’ve just fixed it in https://github.com/xwiki/xwiki-platform/compare/09528b3e668a...4c2da3bf843b and https://github.com/xwiki/xwiki-enterprise/compare/96b63c62a637...7e8188d568… . Caused by https://github.com/xwiki/xwiki-platform/commit/ade4046 (caused by me!! yuck!).
There are possibly more issues that we haven’t discovered yet.
Thus IMO we have 2 problems here:
* Fixing deprecation is something dangerous and if we don’t have automated tests for them we won’t notice regressions
* We’re all not monitoring the build enough since this breakage has been lasting for 1 week. However this may be a consequence of the jenkins stability issue we’re currently experiencing.
I’m not sure what we can to mitigate the risks but we need to think about something for the next time we’ll a Deprecation Fixing Day.
Maybe we should only issue Pull Requests for that day and force that a committer doesn’t push the change himself and instead some other dev would need to review the code before pushing it?
Any idea?
Thanks
-Vincent
PS: Obviously the real solution is to have a stronger automated test suite but that doesn’t happen overnight and we currently don’t have a strategy for catching up with missing tests...
Hello,
I use the Job Module [1] for an extension, and discovered something that
could be a concern ...
Logs of job execution are stored in permanent directory, which is good.
But when using the "{}" notation for writing logs as recommended, the
following is output in the "status.xml" file:
<org.xwiki.logging.event.LogEvent>
<level>DEBUG</level>
<message>blablabla</message>
<argumentArray>
[[ dump of arguments ]]
<argumentArray>
Inside <ArgumentArray>, all attributes of the object passed as argument to
the logger method seem to be dumped - not just a toString().
Currently, in my case sometimes the object I pass contain a password ... I
thought I prevented this password from being output in logs by taking care
of printing "***" in the related toString, but in fact this way it gets in
clear in the status.xml ...
I see those possibilities:
a- store this password encrypted and decrypt it only when used
b- have a possibility to filter what is output in this <argumentArray>
(blacklist some attributes)
c- only pass individual attributes as parameter and not my full object
Obviously a- is the best solution in terms of security. Would xwiki bring
me some helpful methods to implement it (server side) ?
c- is the short term efficient workaround of course, but I would still be
interested to know if there are some crypto tools provided by xwiki (well,
most problematic would be to know where/how to store the secret needed for
encryption/decryption in an extension, if I want to do more than some
scrambling).
WDYT ?
Thanks,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Job+Module