Hi devs,
Good job with the recent activity implementation!
I've noticed that when you build XE from trunk and run it, you see all the pages with an author of XWikiGuest. I would have expected to see them with an author of Administrator. Is that a bug? Maybe it's not related to the recent activity implementation but it doesn't sound right anyway.
Also if I click on XWikiGuest it goes to a non existing page (since XWikiGuest user doesn't exist). I think we shouldn't make XWikiGuest clickable.
Thanks
-Vincent
Good morning,
My name is Gregory GUENEAU and i am actually helping XWiki SAS for its marketing.
I am 39 years old and my all career, since 1992, have been in the numeric business. I first produced CD-ROM applications such as games, cultural applications, softwares for sales or training, etc. I progressively involved more and more in the internet business. I runned more than 250 projects for many companies like l'Oreal, Orange, Disney, Danone, etc. My main experiences were as Production Director and "image" business production co-Management in a very famous event company : "Le Public System". I also runned my own company : Avane, where i invented Chronopolys as a new project management system that got some awards thanks to the collaboration with XWiki.
I am also a professor and research director in "Gobelins, l'ecole de l'image" where i still teach project management. In this school i created a master degree training course, and had also the occasion to write a book published by Eyrolles "Conduite de Projets en Creation Numerique".
I can bring a lot of knowledge about user expectation in the community discussions, i hope you will appreciate.
Best
Gregory
Hi all,
Ludovic suggested that I register an account on http://incubator.myxwiki.org/ so that we can work on a Balsamiq mockup.
I registered on this mailing list, but gather that the incubator is a different thing.
Could someone please set me up with this?
Thanks, Jim
On Nov 7, 2010, at 11:50 AM, sdumitriu (SVN) wrote:
> Author: sdumitriu
> Date: 2010-11-07 11:50:04 +0100 (Sun, 07 Nov 2010)
> New Revision: 32582
>
> Modified:
> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java
> Log:
> XWIKI-4726: Forward links are not refactored on rename causing broken links on rename to different space.
> Fixed.
> Patch from Stefan Abageru applied with some cleanup.
>
> Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java
> ===================================================================
> --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java 2010-11-06 21:41:04 UTC (rev 32581)
> +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java 2010-11-07 10:50:04 UTC (rev 32582)
> @@ -5670,12 +5670,48 @@
> xwiki.saveDocument(backlinkDocument, saveMessage, true, context);
> }
>
> - // Step 4: Delete the old document
> + // Step 4: Refactor the links contained in the document
> + XWikiDocument newDocument = xwiki.getDocument(newDocumentReference, context);
> + XDOM newDocumentXDOM = newDocument.getXDOM();
> + List<LinkBlock> linkBlockList = newDocumentXDOM.getChildrenByType(LinkBlock.class, true);
> + XWikiDocument currentContextDoc = context.getDoc();
> +
> + try {
> + boolean modified = false;
> + for (LinkBlock linkBlock : linkBlockList) {
> + ResourceReference linkReference = linkBlock.getReference();
> + if (linkReference.getType().equals(ResourceType.DOCUMENT)) {
> + context.setDoc(this);
> + DocumentReference currentLinkReference =
> + this.currentDocumentReferenceResolver.resolve(linkReference.getReference());
> +
> + context.setDoc(newDocument);
> + DocumentReference newLinkReference =
> + this.currentDocumentReferenceResolver.resolve(linkReference.getReference());
> +
> + if (!newLinkReference.equals(currentLinkReference)) {
> + modified = true;
> + linkReference.setReference(this.compactWikiEntityReferenceSerializer
> + .serialize(currentLinkReference));
> + }
> + }
> + }
> + // Set new content and save document if needed
> + if (modified) {
> + newDocument.setContent(newDocumentXDOM);
> + xwiki.saveDocument(newDocument, context);
> + }
> + } finally {
> + // Restore original context
> + context.setDoc(currentContextDoc);
> + }
cool thanks stefan and sergiu. IMO we would benefit to introduce some private methods (or not so private if it has a general purpose) to perform this step (or other steps, I don't remember the existing code). checktyle wouldn't probably pass on this method as it is now.
BTW we have a refactoring module and I think it would be a good place to move the rename implementation to this new module... when someone has the time and energy to do so...
Thanks
-Vincent
> +
> + // Step 5: Delete the old document
> xwiki.deleteDocument(this, context);
>
> - // Step 5: The current document needs to point to the renamed document as otherwise it's pointing to an
> + // Step 6: The current document needs to point to the renamed document as otherwise it's pointing to an
> // invalid XWikiDocument object as it's been deleted...
> - clone(xwiki.getDocument(newDocumentReference, context));
> + clone(newDocument);
> }
>
> /**
The XWiki development team is pleased to announce the release of XWiki
Enterprise 2.5.1 and XWiki Enterprise Manager 2.5.1. These are bugfix
releases on the 2.5 branch.
The highlights of this release are: fixed and improved the PDF export,
fixed broken images from the office importer, fixed a severe performance
problem with many blog categories, and fixed broken scheduler functionality.
For more information, see the full release notes at:
- http://www.xwiki.org/xwiki/bin/Main/ReleaseNotesXWikiEnterprise251.
- http://www.xwiki.org/xwiki/bin/Main/ReleaseNotesXEM251.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
Hi Caty,
On 11/03/2010 01:59 PM, evalica (SVN) wrote:
> Author: evalica
> Date: 2010-11-03 13:59:32 +0100 (Wed, 03 Nov 2010)
> New Revision: 32351
>
> Modified:
> platform/xwiki-applications/trunk/annotations/src/main/resources/AnnotationCode/Script.xml
> Log:
> XSCOLIBRI-243: Change page header shortcuts separator to a more simple one that assures readability
I can see that this commit is actually fixing XAANNOTATIONS-37. As all
the commits should have the issue they fix in the commit log (or the
multiple issues they fix), and I will assume that XAANNOTATIONS-37 was
created after this commit was done, you should edit the commit message
to reflect this (this will help me find the code that was committed for
that issue in the jira subversion tab).
See here instructions about how to do that:
http://subversion.apache.org/faq.html#change-log-msg , knowing that our
SVN allows revision property modifications.
Thanks,
Anca
> - Changed separator situated after #annotationsshortcut
>
> Modified: platform/xwiki-applications/trunk/annotations/src/main/resources/AnnotationCode/Script.xml
> ===================================================================
> --- platform/xwiki-applications/trunk/annotations/src/main/resources/AnnotationCode/Script.xml 2010-11-03 12:58:40 UTC (rev 32350)
> +++ platform/xwiki-applications/trunk/annotations/src/main/resources/AnnotationCode/Script.xml 2010-11-03 12:59:32 UTC (rev 32351)
> @@ -665,7 +665,7 @@
> var shortcutsContainer = $('commentsshortcut').up();
> var annShortcut = new Element('span', {'id' : 'annotationsshortcut'}).update('<a href="#' + this.annTabname + '">$msg.get("annotations.title")</a> ');
> shortcutsContainer.insert({top: annShortcut});
> - var separator = new Element('span', {'class' : 'separator'}).update('|');
> + var separator = new Element('span', {'class' : 'separator'}).update('·');
> annShortcut.insert({after : separator});
>
> annShortcut.observe('click', XWiki.displayDocExtra.bind(XWiki, this.annTabname, 'annotationsinline.vm', true));
>
> _______________________________________________
> notifications mailing list
> notifications(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/notifications
Hi guys,
If you can please test XE 2.6 RC1:
http://maven.xwiki.org/releases/org/xwiki/enterprise/
Once I get a few confirmations that it works well, I'll finish the release and publish it.
Thanks for your help!
-Vincent
Acting Release Manager for XE 2.6 RC1