We need to decide where to put events but I think it's wrong to put them in the observation-api package.
Thanks
-Vincent
On Oct 26, 2010, at 6:01 PM, sdumitriu (SVN) wrote:
> Author: sdumitriu
> Date: 2010-10-26 18:01:34 +0200 (Tue, 26 Oct 2010)
> New Revision: 32192
>
> Added:
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractAnnotationEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractAttachmentEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractCommentEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AnnotationAddEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AnnotationDeleteEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AnnotationUpdateEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AttachmentAddEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AttachmentDeleteEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AttachmentUpdateEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/CommentAddEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/CommentDeleteEvent.java
> platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/CommentUpdateEvent.java
> Log:
> XWIKI-5622: New event types: add/update/delete comment/annotation/attachment
> Done.
> Patch from Stefan Abageru applied with a bit of changes.
I was wondering how the current method of configuration came into existence. I googled against the
lists and didn't see anything particularly enlightening.
IMO the promise of component management is "you ask for it and it's there".
The best way I can imagine to ask for a configuration parameter would be:
@Requirement("my-module.param")
private String configParam = "default value";
If no parameter was defined then "default value" would be the value.
Since I imagine making the component manager inject a String and know that it's a configuration
parameter would be horrible, I would have chosen a workaround by creating an interface and class
which is shared among all consumers of configuration. Something like:
public interface ConfigurationString
{
java.lang.String get();
ConfigurationString default(java.lang.String);
}
Then to get the configuration parameter you need:
@Requirement("my-module.param")
private ConfigurationString myParam = ConfigurationString.default("default value");
Since the benefits of writing 2 lines to get a configuration parameter vs. writing 2 classes seem
obvious, I assume that this idea was reviewed and cast aside and I was wondering why it was decided
that something like this was the wrong approach.
If anyone could shed some light on this, I'd appreciate it.
Thanks
Caleb
Hey devs,
I'd like to vote on changing the rule about promotion of contrib
projects out of sandbox (see
http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome#HPromotingaprojectouto…
), in particular skipping the VOTE part.
The main reason is that contrib projects are not managed nor endorsed
by the XWiki Development team, so it should not be their call to
approve project promotion from sandbox/ to projects/
+1 to remove the need to VOTE, and to let project owners decide for
themselves (either as individual developers, or as team decisions)
when their project is ready to go out of the sandbox (usually this
happens when a first release is needed).
Jerome.
The XWiki development team is pleased to announce the release of XWiki
Enterprise 2.5 and XWiki Enterprise Manager 2.5.
Go grab them at http://www.xwiki.org/xwiki/bin/view/Main/Download
The highlights of this release are:
* support for viewing attached office documents in the wiki
* a new User Directory
* an experimental Extension Manager
* improvements to action menus
* further improvements to the edit UI
* support for activating a special accessibility stylesheet
* more consistent use of user avatars
* an experimental xwiki/2.1 wiki syntax
* a mechanism for inserting custom links in the header
* the introduction of cancelable events
* better external search engine indexing support
* experimental CSRF protection
* experimental Cryptographic Module
For more information, see the Release notes at
http://www.xwiki.org/xwiki/bin/Main/ReleaseNotesXWikiEnterprise25 and
http://www.xwiki.org/xwiki/bin/Main/ReleaseNotesXEM25
Thanks
-The XWiki dev team
On Mon, Oct 25, 2010 at 18:40, sdumitriu
<platform-notifications(a)xwiki.org> wrote:
> Author: sdumitriu
> Date: 2010-10-25 18:40:28 +0200 (Mon, 25 Oct 2010)
> New Revision: 32162
>
> Modified:
> Â platform/core/trunk/pom.xml
> Â platform/core/trunk/xwiki-component/xwiki-component-observation/pom.xml
> Â platform/core/trunk/xwiki-core/pom.xml
> Â platform/core/trunk/xwiki-crypto/pom.xml
> Â platform/core/trunk/xwiki-csrf/pom.xml
> Â platform/core/trunk/xwiki-extension/pom.xml
> Â platform/core/trunk/xwiki-management/pom.xml
> Â platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml
> Â platform/core/trunk/xwiki-office/pom.xml
> Â platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-container/pom.xml
> Â platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-dashboard/pom.xml
> Â platform/core/trunk/xwiki-rendering/xwiki-rendering-transformations/xwiki-rendering-transformation-icon/pom.xml
> Â platform/core/trunk/xwiki-rest/xwiki-rest-model/pom.xml
> Â platform/core/trunk/xwiki-rest/xwiki-rest-server/pom.xml
> Log:
> [misc] Updated clirr skips
>
> Modified: platform/core/trunk/pom.xml
> ===================================================================
> --- platform/core/trunk/pom.xml 2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/pom.xml 2010-10-25 16:40:28 UTC (rev 32162)
> @@ -37,7 +37,7 @@
> Â <description>XWiki Platform - Core - Parent POM</description>
> Â <properties>
> Â Â <!-- Versions of XWiki dependencies used in Core modules -->
> - Â Â <clirr.previous.version>2.5-rc-1</clirr.previous.version>
> + Â Â <clirr.previous.version>2.5</clirr.previous.version>
> Â </properties>
> Â <scm>
> Â Â <connection>scm:svn:http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk</connection>
> @@ -194,27 +194,6 @@
> Â Â Â Â Â Â Â Â Â Â Â exclude it for the moment. See http://bit.ly/c5Jnho Remove this exclude when the problem is fixed
> Â Â Â Â Â Â Â Â Â Â Â in CLIRR. -->
> Â Â Â Â Â Â Â Â <exclude>org/xwiki/officeimporter/openoffice/OpenOfficeManager$ManagerState</exclude>
> - Â Â Â Â Â Â Â Â <!-- To be removed when 2.5 final is released -->
> - Â Â Â Â Â Â Â Â <!-- 2.5RC1 was wrongly released using Java 1.6 (instead of 1.5) and we need to add those exclusions
> - Â Â Â Â Â Â Â Â Â Â as otherwise CLIRR complains -->
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/component/descriptor/ComponentInstantiationStrategy</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/model/EntityType</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/cache/eviction/EntryEvictionConfiguration$Algorithm</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/cache/tests/CacheEntryListenerTest$EventType</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/url/XWikiURLType</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/Format</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/HeaderLevel</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/ListType</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/chaining/BlockStateChainingListener$Event</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/chaining/EventType</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/chaining/EventType$*</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/formula/FormulaRenderer$FontSize</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/formula/FormulaRenderer$Type</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/macro/toc/TocMacroParameters$Scope</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/macro/include/IncludeMacroParameters$Context</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/macro/wikibridge/WikiMacroVisibility</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/annotation/maintainer/AnnotationState</exclude>
> - Â Â Â Â Â Â Â Â <exclude>org/xwiki/annotation/renderer/AnnotationEvent$AnnotationEventType</exclude>
> Â Â Â Â Â Â Â Â <!-- To be removed when we release 2.6 -->
> Â Â Â Â Â Â Â Â <exclude>org/xwiki/rendering/listener/reference/ResourceType</exclude><!-- Removed field IMAGE, Added UNKNOWN -->
> Â Â Â Â Â Â Â Â <exclude>org/xwiki/bridge/SkinAccessBridge</exclude><!-- New method getIconURL -->
>
> Modified: platform/core/trunk/xwiki-component/xwiki-component-observation/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-component/xwiki-component-observation/pom.xml   2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-component/xwiki-component-observation/pom.xml   2010-10-25 16:40:28 UTC (rev 32162)
> @@ -33,10 +33,6 @@
> Â <name>XWiki Platform - Core - Component - Observation</name>
> Â <packaging>jar</packaging>
> Â <description>XWiki Platform - Core - Component - Observation</description>
> - Â <properties>
> - Â Â <!-- Remove when 2.5 will be released -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â <dependencies>
> Â Â <dependency>
> Â Â Â <groupId>commons-logging</groupId>
>
> Modified: platform/core/trunk/xwiki-core/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-core/pom.xml    2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-core/pom.xml    2010-10-25 16:40:28 UTC (rev 32162)
> @@ -1431,9 +1431,6 @@
> Â Â Â Â Â Â Â <includes>
> Â Â Â Â Â Â Â Â <include>**/api/**</include>
> Â Â Â Â Â Â Â </includes>
> - Â Â Â Â Â Â Â <excludes>
> - Â Â Â Â Â Â Â Â <exclude>com/xpn/xwiki/user/api/XWikiGroupService</exclude>
> - Â Â Â Â Â Â Â </excludes>
> Â Â Â Â Â Â </configuration>
> Â Â Â Â Â </plugin>
> Â Â Â Â </plugins>
>
> Modified: platform/core/trunk/xwiki-crypto/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-crypto/pom.xml   2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-crypto/pom.xml   2010-10-25 16:40:28 UTC (rev 32162)
> @@ -32,10 +32,6 @@
> Â <artifactId>xwiki-core-crypto</artifactId>
> Â <name>XWiki Platform - Core - Cryptographic Services</name>
> Â <description>XWiki Platform - Core - Cryptographic Services</description>
> - Â <properties>
> - Â Â <!-- Skip Clirr execution, since this is a new component -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â <dependencies>
> Â Â <!-- Used by CryptoScriptService which provides a service to Velocity scripts -->
> Â Â <dependency>
>
> Modified: platform/core/trunk/xwiki-csrf/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-csrf/pom.xml    2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-csrf/pom.xml    2010-10-25 16:40:28 UTC (rev 32162)
> @@ -33,10 +33,6 @@
> Â <name>XWiki Platform - Core - CSRF</name>
> Â <packaging>jar</packaging>
> Â <description>XWiki CSRF Protection Module</description>
> - Â <properties>
> - Â Â <!-- Skip Clirr execution, since this is a new component -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â <dependencies>
> Â Â <dependency>
> Â Â Â <groupId>org.xwiki.platform</groupId>
>
> Modified: platform/core/trunk/xwiki-extension/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-extension/pom.xml 2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-extension/pom.xml 2010-10-25 16:40:28 UTC (rev 32162)
> @@ -33,10 +33,6 @@
> Â <name>XWiki Platform - Core - Extension</name>
> Â <packaging>pom</packaging>
> Â <description>XWiki Platform - Core - Extension</description>
> - Â <properties>
> - Â Â <!-- Remove when 2.6 will be released -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
As you can see in the comment this is to be removed when 2.6 is
released, not 2.5. The reason is that it has been refactored as
several module instead of only one in 2.5 branch.
> Â <modules>
> Â Â <module>xwiki-extension-api</module>
> Â Â <module>xwiki-extension-handlers</module>
>
> Modified: platform/core/trunk/xwiki-management/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-management/pom.xml     2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-management/pom.xml     2010-10-25 16:40:28 UTC (rev 32162)
> @@ -56,9 +56,5 @@
> Â Â Â </plugin>
> Â Â </plugins>
> Â </build>
> - Â <properties>
> - Â Â <!-- Skip Clirr execution since this is the first release of this module. Remove once XE 2.4 is released. -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â </project>
>
>
> Modified: platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml 2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml 2010-10-25 16:40:28 UTC (rev 32162)
> @@ -34,10 +34,6 @@
> Â <name>XWiki Platform - Core - Observation - API</name>
> Â <packaging>jar</packaging>
> Â <description>XWiki Platform - Core - Observation - API</description>
> - Â <properties>
> - Â Â <!-- Remove when 2.5 will be released -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â <dependencies>
> Â Â <dependency>
> Â Â Â <groupId>org.xwiki.platform</groupId>
>
> Modified: platform/core/trunk/xwiki-office/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-office/pom.xml   2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-office/pom.xml   2010-10-25 16:40:28 UTC (rev 32162)
> @@ -64,9 +64,4 @@
> Â Â Â </plugin>
> Â Â </plugins>
> Â </build>
> - Â <properties>
> - Â Â <!-- Skip Clirr execution because xwiki-office-viewer and xwiki-office-macro have not been released yet, and
> - Â Â Â xwiki-office-importer has been renamed. Remove once XE 2.5M2 is released. -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â </project>
>
> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-container/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-container/pom.xml  2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-container/pom.xml  2010-10-25 16:40:28 UTC (rev 32162)
> @@ -50,8 +50,4 @@
> Â Â Â </plugin>
> Â Â </plugins>
> Â </build>
> - Â <properties>
> - Â Â <!-- Skip Clirr execution since this is the first release of this module. Remove once XE 2.5 is released. -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â </project>
>
> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-dashboard/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-dashboard/pom.xml  2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-dashboard/pom.xml  2010-10-25 16:40:28 UTC (rev 32162)
> @@ -56,8 +56,4 @@
> Â Â Â <version>${project.version}</version>
> Â Â </dependency>
> Â </dependencies>
> - Â <properties>
> - Â Â <!-- Skip Clirr execution since this is the first release of this module. Remove once XE 2.5 is released. -->
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â </project>
>
> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-transformations/xwiki-rendering-transformation-icon/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-transformations/xwiki-rendering-transformation-icon/pom.xml   2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-transformations/xwiki-rendering-transformation-icon/pom.xml   2010-10-25 16:40:28 UTC (rev 32162)
> @@ -34,6 +34,7 @@
> Â <name>XWiki Platform - Core - Rendering - Transformation - Icon</name>
> Â <description>XWiki Platform - Core - Rendering - Transformation - Icon</description>
> Â <properties>
> + Â Â <!-- New module introduced in 2.6, remove this skip once 2.6 is released. -->
> Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> Â </properties>
> Â </project>
>
> Modified: platform/core/trunk/xwiki-rest/xwiki-rest-model/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-rest/xwiki-rest-model/pom.xml   2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-rest/xwiki-rest-model/pom.xml   2010-10-25 16:40:28 UTC (rev 32162)
> @@ -32,10 +32,6 @@
> Â <artifactId>xwiki-rest-model</artifactId>
> Â <name>XWiki Platform - Core - REST - Model</name>
> Â <description>The (JAXB) model for XML resource representations served by the REST module.</description>
> - Â <!-- We are disabling clirr in order to avoid errors because since we are introducing this module in 2.4, previous versions don't exist. REMOVE this line in next development cycles! -->
> - Â <properties>
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â <dependencies>
> Â Â <dependency>
> Â Â Â <groupId>javax.xml.bind</groupId>
>
> Modified: platform/core/trunk/xwiki-rest/xwiki-rest-server/pom.xml
> ===================================================================
> --- platform/core/trunk/xwiki-rest/xwiki-rest-server/pom.xml   2010-10-25 16:25:07 UTC (rev 32161)
> +++ platform/core/trunk/xwiki-rest/xwiki-rest-server/pom.xml   2010-10-25 16:40:28 UTC (rev 32162)
> @@ -34,10 +34,6 @@
> Â <packaging>jar</packaging>
> Â <name>XWiki Platform - Core - REST - Server</name>
> Â <description>Service for accessing XWiki through a RESTful API</description>
> - Â <!-- Since in 2.4 we moved all model classes in a separate module, skip clirr otherwise we will get plenty of "removed" errors. Re-enable it in next development cycles! -->
> - Â <properties>
> - Â Â <xwiki.clirr.skip>true</xwiki.clirr.skip>
> - Â </properties>
> Â <dependencies>
> Â Â <dependency>
> Â Â Â <groupId>javax.servlet</groupId>
>
> _______________________________________________
> notifications mailing list
> notifications(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/notifications
>
--
Thomas Mortagne
Hello XWiki devs,
Sorry for postponing this message and about seeing confusing svn commit
messages!
The partenership between XWiki and Loria(http://www.loria.fr) has produced
an integrated editor (prototype still..) that allows real time
collaboration.
It means that it'll allow multiple users to concurrently edit the same xwiki
page without stepping on each other toes... just like in GoogleWave,
GoogleDocs aso.
Thus I invite you to check it out:
http://svn.xwiki.org/svnroot/xwiki/contrib/projects/wiki30/
give it a try (INSTALL.txt) and let me know WDYT.
Feel free to use the mailing list as well as JIRA:
http://jira.xwiki.org/jira/browse/WIKITHREEDOTO/
for bugs, comments, improvements ...
Best regards and looking forward hearing from you!
--
ing. Flueras Bogdan