Hi Devs,
right now the Office Importer feature is available through a button in the
toolbar of the WYSIWYG editor. I think it should be moved to the editor's
top menubar, next to "Macros". Here's the rationale:
- The toolbar has mostly text formatting button while the Office Importer
is a much bigger feature
- Other features that require opening a dialog box (link, images, tables,
macros) are located in the top menubar
The entry would have 2 subentries: paste document & import document.
WDYT?
Guillaume
--
Guillaume Lerouge
Product Manager - XWiki
Skype: wikibc
Twitter: glerouge
http://guillaumelerouge.com/
Hi Marius,
I have updated the code you mention. And I find out I forget to copy
resources/js/xwiki/wysiwyg/xwe
from the place that I built to the server's resources/js/xwiki/wysiwyg/xwe.
Thank you for your help again!
Probably this results the problems below:
"It this a public web site? Can you create me a temporary account to debug
the problem?"
It is a server runs on campus (Miami University) network in order to protect
it from bad people. Thank you very much for helping me. I really
appreciate it.
"Can you install the Firebug Firefox extension?"
I have successfully installed in on WinXP PC, it seems not work on my vista
laptop. Here is the error that I could find under DOM tab:
$continue: Error: "throw $continue" is deprecated, use "return" instead
filename: "
http://wiki.burge.csi.muohio.edu:8080/xwiki/resources/js/prototype/prototyp…
"
lineNumber: 4725
message: ""throw $continue" is deprecated, use "return" instead"
name: "Error"
stack: "Error("\"throw $continue\" is deprecated, use \"return\"
instead")@:0\n@
http://wiki.burge.csi.muohio.edu:8080/xwiki/resources/js/prototype/prototyp…
\n"
I did not see any from Script tab.
And Here is the error message IE8 returns:
"
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; WOW64;
Trident/4.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; InfoPath.2;
.NET CLR 3.5.30729; CIBA;
staticlogin:product=cbpro09&act=login&info=ZmlsZW5hbWU9UG93ZXJ3b3JkMjAwOVByby4yNTI2OS40MDEwLmV4ZSZtYWM9NjQyMTZDODM0QTIyNDIyNkEzMEUxMjFEOEFFRTBEOTYmcGFzc3BvcnQ9JnZlcnNpb249MjAwOS4wNC4yOS4yLjI4MSZjcmFzaHR5cGU9MQ==&verify=550370cea5bed2cbf89407456ed93587;
.NET CLR 3.0.30729; OfficeLiveConnector.1.4; OfficeLivePatch.1.3)
Timestamp: Thu, 1 Oct 2009 22:56:31 UTC
Message: 'isc' is undefined
Line: 7
Char: 1
Code: 0
URI:
http://wiki.burge.csi.muohio.edu:8080/xwiki/resources/js/smartclient/overwr…
Message: 'isc' is undefined
Line: 59
Char: 1
Code: 0
URI:
http://wiki.burge.csi.muohio.edu:8080/xwiki/bin/skin/resources/js/xwiki/xwi…
Message: 'Wysiwyg' is undefined
Line: 217
Char: 5
Code: 0
URI:
http://wiki.burge.csi.muohio.edu:8080/xwiki/bin/edit/Sandbox/TestPage1?edit…
Message: 'Wysiwyg' is undefined
Line: 256
Char: 1
Code: 0
URI:
http://wiki.burge.csi.muohio.edu:8080/xwiki/bin/edit/Sandbox/TestPage1?edit…
"
It's missing a lot of changes...
-Vincent
On Oct 2, 2009, at 12:00 AM, notifications(a)xwiki.org wrote:
> Hello Developers,
>
> This message is sent by XWiki. Here are the documents in your
> watchlist that have been modified since the last notification:
> <wiki.gif> xwiki
> <space.gif> XWiki
> <document.gif> XWikiNotifications XWiki.XWikiNotifications
>
> On 2009/10/01 15:47, the document has been modified by Developers
> (XWiki Notifications)
> <object.gif>XWiki.XWikiUsers
> <string.png>email:
> jerome@xwiki.comnotifications@xwiki.org
> <document.gif> XWiki Preferences XWiki.XWikiPreferences
>
> On 2009/10/01 16:18, the document has been modified by Jerome
> Velociter
> <object.gif>XWiki.XWikiPreferences
> <string.png>admin_email:
> notifications(a)xwiki.org
> <textarea.png>meta:
> <metadata.gif>author: XWiki.VincentMassol > XWiki.jvelociter
> <document.gif> jvdrean XWiki.jvdrean
>
> On 2009/10/01 15:45, the document has been modified by Jean-Vincent
> Drean
> <object.gif>XWiki.WatchListClass
> <textarea.png>wikis:
> ,xwiki,enterprise,workspaces
Hi all,
I propose we create a user on XWiki.org that will subscribe to daily
watchlist notifications on the xwiki.org wikis, with
notifications(a)xwiki.org as email address.
We can try to watch entire wikis, though we might get some noise on
certain wikis (for example with all users that are created on the main
wiki).
WDYT ?
+1 to try out this.
Jerome.
Hi Anca,
Be very very careful with ThreadLocal. It's very easy to make mistakes
and cause memory leaks. Actually I think you may have introduced one
already ;) (please do some web research on ThreadLocal you'll see it
has some caveats and they must absolutely be freed when the thread
exits).
I believe this needs to be discussed more to ensure it's the right way
and doesn't cause pbs.
Also we already have an ExecutionContext so I'm not sure why we need
this.
Can you please explain?
Thanks
-Vincent
On Oct 1, 2009, at 10:13 AM, lucaa (SVN) wrote:
> Author: lucaa
> Date: 2009-10-01 10:13:20 +0200 (Thu, 01 Oct 2009)
> New Revision: 24158
>
> Modified:
> platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/server/
> XWikiServiceImpl.java
> platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/
> server/DefaultWysiwygService.java
> Log:
> XWIKI-4411: XWikiServiceImpl's xwiki context is not handled threadsafe
> * handled the prepared context in a ThreadLocal member.
>
>
> Modified: platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
> server/XWikiServiceImpl.java
> ===================================================================
> --- platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
> server/XWikiServiceImpl.java 2009-09-30 21:49:09 UTC (rev 24157)
> +++ platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
> server/XWikiServiceImpl.java 2009-10-01 08:13:20 UTC (rev 24158)
> @@ -66,7 +66,7 @@
> {
> private static final Log LOG = LogFactory.getLog(XWiki.class);
>
> - private XWikiContext context;
> + private ThreadLocal<XWikiContext> context;
>
> /**
> * We override the default processCall method in order to
> provide XWiki initialization before
> @@ -131,7 +131,7 @@
> }
>
> context.put("ajax", new Boolean(true));
> - this.context = context;
> + this.context.set(context);
> }
>
> private void initializeContainerComponent(XWikiContext context)
> @@ -168,7 +168,7 @@
>
> protected XWikiContext getXWikiContext()
> {
> - return this.context;
> + return this.context.get();
> }
>
> protected XWikiGWTException getXWikiGWTException(Exception e) {
>
> Modified: platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/
> wysiwyg/server/DefaultWysiwygService.java
> ===================================================================
> --- platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/
> server/DefaultWysiwygService.java 2009-09-30 21:49:09 UTC (rev 24157)
> +++ platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/
> server/DefaultWysiwygService.java 2009-10-01 08:13:20 UTC (rev 24158)
> @@ -302,14 +302,8 @@
> getXWikiContext().setDatabase(wikiName);
> }
> spaceNamesList =
> getXWikiContext().getWiki().getSpaces(getXWikiContext());
> - // get the blacklisted spaces from the session as
> they've been set in xwikivars.vm, when the page edited
> - // with this wysiwyg was loaded
> - // TODO: remove this when the public API will exclude
> them by default, or they'll be set in the config
> - List<String> blacklistedSpaces =
> - (ArrayList<String>)
> getThreadLocalRequest
> ().getSession().getAttribute("blacklistedSpaces");
> - if (blacklistedSpaces != null &&
> blacklistedSpaces.size() > 0) {
> - spaceNamesList.removeAll(blacklistedSpaces);
> - }
> + // remove the blacklisted spaces from the all spaces list
> + spaceNamesList.removeAll(getBlackListedSpaces());
> Collections.sort(spaceNamesList);
> } catch (XWikiException e) {
> e.printStackTrace();
> @@ -322,6 +316,26 @@
> }
>
> /**
> + * Helper function to retrieve the blacklisted spaces in this
> session, as they've been set in xwikivars.vm, when the
> + * page edited with this wysiwyg was loaded. <br />
> + * TODO: remove this when the public API will exclude them by
> default, or they'll be set in the config.
> + *
> + * @return the list of blacklisted spaces from the session
> + */
> + @SuppressWarnings("unchecked")
> + private List<String> getBlackListedSpaces()
> + {
> + // get the blacklisted spaces from the session
> + List<String> blacklistedSpaces =
> + (ArrayList<String>)
> getThreadLocalRequest
> ().getSession().getAttribute("blacklistedSpaces");
> + // always return a list, even if blacklisted spaces
> variable wasn't set
> + if (blacklistedSpaces == null) {
> + blacklistedSpaces = new ArrayList<String>();
> + }
> + return blacklistedSpaces;
> + }
> +
> + /**
> * {@inheritDoc}
> *
> * @see WysiwygService#getPageNames(String, String)
> @@ -379,12 +393,31 @@
> throws XWikiGWTException
> {
> try {
> + String quote = "'";
> + String doubleQuote = "''";
> // FIXME: this fullname comparison with the keyword does
> not contain the wiki name
> - String escapedKeyword = keyword.replaceAll("'",
> "''").toLowerCase();
> + String escapedKeyword = keyword.replaceAll(quote,
> doubleQuote).toLowerCase();
> + // add condition for the doc to not be in the list of
> blacklisted spaces.
> + // TODO: might be a pb with scalability of this
> + String noBlacklistedSpaces = "";
> + List<String> blackListedSpaces = getBlackListedSpaces();
> + if (!blackListedSpaces.isEmpty()) {
> + StringBuffer spacesList = new StringBuffer();
> + for (String bSpace : blackListedSpaces) {
> + if (spacesList.length() > 0) {
> + spacesList.append(", ");
> + }
> + spacesList.append(quote);
> + spacesList.append(bSpace.replaceAll(quote,
> doubleQuote));
> + spacesList.append(quote);
> + }
> + noBlacklistedSpaces = "doc.web not in (" +
> spacesList.toString() + ")";
> + }
> List<XWikiDocument> docs =
> getXWikiContext().getWiki().search(
> - "select distinct doc from XWikiDocument as doc
> where lower(doc.title) like '%" + escapedKeyword
> - + "%' or lower(doc.fullName) like '%" +
> escapedKeyword + "%'", count, start, getXWikiContext());
> + "select distinct doc from XWikiDocument as doc
> where " + noBlacklistedSpaces
> + + " and (lower(doc.title) like '%" +
> escapedKeyword + "%' or lower(doc.fullName) like '%"
> + + escapedKeyword + "%')", count, start,
> getXWikiContext());
> return prepareDocumentResultsList(docs);
> } catch (XWikiException e) {
> throw getXWikiGWTException(e);
> @@ -406,7 +439,7 @@
> for (XWikiDocument doc : docs) {
> com.xpn.xwiki.gwt.api.client.Document xwikiDoc = new
> com.xpn.xwiki.gwt.api.client.Document();
> xwikiDoc.setFullName(doc.getFullName());
> -
> xwikiDoc.setTitle(doc.getDisplayTitle(getXWikiContext()));
> +
> xwikiDoc.setTitle(doc.getRenderedTitle(Syntax.XHTML_1_0,
> getXWikiContext()));
> // FIXME: shouldn't use upload URL here, but since we
> don't want to add a new field...
> xwikiDoc.setUploadURL(doc.getURL(VIEW_ACTION,
> getXWikiContext()));
> results.add(xwikiDoc);
>
> _______________________________________________
> notifications mailing list
> notifications(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/notifications
Hi,
I'm not exactly sure if that is the best method name, but we need such a
method so that we can disable fileUpload tab (or display a message) in
officeimporter wysiwyg plugin if there is no OpenOffice server running.
Thanks.
- Asiri
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with
a trailing and ending new line:
1.A
(((
* list1
* list 2
)))
instead of
1.B
(((* list1
* list 2)))
for example but it also mean:
2.A
| (((
* list
))) | second cell
instead of
2.B
| (((* list with one item)))
Here are my arguments:
* i tough of that idea at first because it's not very easy/clean to
support well the escaping of an ending ) before a ending group in an
events based renderer, the problem is that you need to bufferize at
least 4 events (if not more) to know when you print the ) character
that it will be followed by end group syntax when printed. For example
it can be the last character of paragraph in the last cell or last row
of a table before the end of the group
* i prefer to "break" 2.A done on purpose than 1.A done on purpose
since it's not possible to support both currently
* even with 2.A it's more readable to have it in its own line IMO
Here is my +1
--
Thomas Mortagne
Hi Everyone, Hi Marius,
Here is the screen shot link:
http://picasaweb.google.com/lh/photo/XWqNdRICk3o-27h9bm0rYA?feat=directlink
"Also, are there any JavaScript errors in the Firebug console or any
exceptions in the server log?"
The browser did not give my any error message.
"Did you build the XWiki trunk or a branch? Is it up to date? "
I built the trunk.I download the source code about two weeks ago and built
it.
"Have you changed anything inthe WYSIWYG sources?"
I did not change anything.
I was wondering is there any configuration of xwiki is missing. I moved the
jar file to Xwiki Enterprise 1.93 that I install on Windows by using
Installer and it works fine. And I moved the wysiwyg 1.93 jar file to the
xwiki that I built is still look like that.
So any ideas, guys?
Thank you for your help!