June 2008 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Fabio Mancinelli as core committer
by Vincent Massol 12 Jun '08

12 Jun '08

Hi, I'd like to propose Fabio as a core committer. Fabio has been mostly participating in the rewrite of the XMLRPC support and I think it's important that he has access to maintain and improve it. Fabio's patches are very good too. In addition I believe Fabio is professional enough to not commit things he's not sure about if he's modifying other parts of the core and ask for core review instead. Last, if this make Fabio contributes to other parts in the core, then that's great for the project! Here's my +1 Thanks -Vincent

7 7

[xwiki-devs] [GSOC]syntax highlighting probleam
by malaka ekanayake 12 Jun '08

12 Jun '08

Hi fabio Regarding the xwiki syntax I have some questions. Up to now its straightforward to implement the highlighting for syntaxes like *bold*. *bold* can be easily identified by a "MultiLineRule" as a single partition. But it is possible for someone to write a *bold~~bold &italics~~bold*.Right ?. So this can go on and on.How should I tackle this problem. I think *bold~~bold &italics~~bold* should generate 3 partitions because partitions are non overlapping. *bold ~~bold &italics~~ bold* Is this right ?. Should I look into this problem later and implement the sample plugin for simple syntaxes like *bild*,~~italics~~ or not ? . cheers -- Malaka Ekanayake

3 3

Re: [xwiki-devs] [xwiki-notifications] r10277 - in xwiki-platform/web/trunk/standard/src/main/webapp: templates wiki_editor/plugins
by Vincent Massol 12 Jun '08

12 Jun '08

On Jun 12, 2008, at 5:17 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 05:17:43 +0200 (Thu, 12 Jun 2008) > New Revision: 10277 > > Modified: > xwiki-platform/web/trunk/standard/src/main/webapp/templates/ > editwysiwyg.vm > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/attachments.js > Log: > XWIKI-1284: Image disappears from WYSIWYG editor in documents with > special characters in name > Fixed. > [snip] > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/plugins/attachments.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/attachments.js 2008-06-12 01:39:44 UTC (rev 10276) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/attachments.js 2008-06-12 03:17:43 UTC (rev 10277) > @@ -44,7 +44,7 @@ > var contextPathImage = > tinyMCE.getParam("wiki_images_path").toString(); > href = contextPathImage.substring(0, > contextPathImage.indexOf("/",2)) + > "/bin/" + href.substring(href.indexOf("/",3) + 1); > - href = unescape(href); > +// href = unescape(href); Shouldn't this be removed? > > var imgname_reg = new RegExp(this.getImagePath() + "(.*)", > "i"); > var r = imgname_reg.exec(href); > if(r) { > @@ -82,7 +82,7 @@ > if (halign != "") { > str += "<div class=\"img" + halign + "\">" > } > - str += "<img id=\"" + result[1] + "\" class=\"" + > this.IMAGE_CLASS_NAME + "\" src=\"" + this.getImagePath() + > result[1] + "\" "; > + str += "<img id=\"" + result[1] + "\" class=\"" + > this.IMAGE_CLASS_NAME + "\" src=\"" + escape(this.getImagePath() + > result[1]) + "\" "; > if( result[5] && (width = this.trimString(result[5])) != "") { > str += "width=\"" + width + "\" "; > } Thanks -Vincent

1 0

Re: [xwiki-devs] [xwiki-notifications] r10272 - in xwiki-platform/core/trunk/xwiki-core/src/main: java/com/xpn/xwiki/store/hibernate resources
by Vincent Massol 12 Jun '08

12 Jun '08

On Jun 12, 2008, at 2:47 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 02:47:34 +0200 (Thu, 12 Jun 2008) > New Revision: 10272 > > Added: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > store/hibernate/DocumentWebPropertyAccessor.java > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml > Log: > XWIKI-2456: Deprecate the doc.web mapping and add doc.space in the > Hibernate mapping file > Done. > > > Added: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/store/hibernate/DocumentWebPropertyAccessor.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > store/hibernate/ > DocumentWebPropertyAccessor.java (rev 0) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > store/hibernate/DocumentWebPropertyAccessor.java 2008-06-12 00:47:34 > UTC (rev 10272) > @@ -0,0 +1,69 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package com.xpn.xwiki.store.hibernate; > + > +import org.apache.commons.logging.Log; > +import org.apache.commons.logging.LogFactory; > +import org.hibernate.PropertyNotFoundException; > +import org.hibernate.property.BasicPropertyAccessor; > +import org.hibernate.property.Getter; > +import org.hibernate.property.PropertyAccessor; > +import org.hibernate.property.Setter; > + > +import com.xpn.xwiki.web.XWikiAction; > + > +/** > + * Hibernate property accessor that allows using the deprecated > <code>doc.web</code> in HQL queries, while using the > + * new <code>space</code> getter and setter for the actual object > access. > + * > + * @version $Id$ > + */ > +public class DocumentWebPropertyAccessor extends > BasicPropertyAccessor implements PropertyAccessor > +{ > + /** Logging helper object. */ > + private static final Log LOG = > LogFactory.getLog(XWikiAction.class); > + > + /** > + * {@inheritDoc} > + * > + * @see PropertyAccessor#getGetter(Class, String) > + */ > + @SuppressWarnings("unchecked") > + @Override > + public Getter getGetter(Class theClass, String propertyName) > throws PropertyNotFoundException > + { > + LOG.warn("Deprecated usage of doc.web property in HQL > query"); shouldn't we say: "Deprecated usage of doc.web property in HQL query, use doc.space instead." ? same below. Thanks -Vincent > > + return super.getGetter(theClass, "space"); > + } > + > + /** > + * {@inheritDoc} > + * > + * @see PropertyAccessor#getSetter(Class, String) > + */ > + @SuppressWarnings("unchecked") > + @Override > + public Setter getSetter(Class theClass, String propertyName) > throws PropertyNotFoundException > + { > + LOG.warn("Deprecated usage of doc.web property in HQL > query"); > + return super.getSetter(theClass, "space"); > + } > + > +} > > > Property changes on: xwiki-platform/core/trunk/xwiki-core/src/main/ > java/com/xpn/xwiki/store/hibernate/DocumentWebPropertyAccessor.java > ___________________________________________________________________ > Name: svn:keywords > + Id > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml 2008-06-12 00:45:31 UTC (rev 10271) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml 2008-06-12 00:47:34 UTC (rev 10272) > @@ -66,10 +66,15 @@ > <column name="XWD_CREATOR" length="255" not-null="true" /> > </property> > > - <property name="web" type="string"> > +  > + <property name="web" type="string" update="false" > insert="false" > access="com.xpn.xwiki.store.hibernate.DocumentWebPropertyAccessor"> > <column name="XWD_WEB" length="255" not-null="true"/> > </property> > > + <property name="space" type="string"> > + <column name="XWD_WEB" length="255" not-null="true"/> > + </property> > + > <property name="content" type="string"> > <column name="XWD_CONTENT" sql-type="CLOB" > length="200000" not-null="true"/> > </property> > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml 2008-06-12 00:45:31 UTC (rev 10271) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml 2008-06-12 00:47:34 UTC (rev 10272) > @@ -58,10 +58,15 @@ > <column name="XWD_CREATOR" length="255" not-null="true" /> > </property> > > - <property name="web" type="string"> > +  > + <property name="web" type="string" update="false" > insert="false" > access="com.xpn.xwiki.store.hibernate.DocumentWebPropertyAccessor"> > <column name="XWD_WEB" length="255" not-null="true"/> > </property> > > + <property name="space" type="string"> > + <column name="XWD_WEB" length="255" not-null="true"/> > + </property> > + > <property name="content" type="string"> > <column name="XWD_CONTENT" length="200000" not- > null="true"/> > </property> > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml 2008-06-12 00:45:31 UTC (rev 10271) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml 2008-06-12 00:47:34 UTC (rev 10272) > @@ -60,10 +60,15 @@ > <column name="XWD_CREATOR" length="255"/> > </property> > > - <property name="web" type="string"> > +  > + <property name="web" type="string" update="false" > insert="false" > access="com.xpn.xwiki.store.hibernate.DocumentWebPropertyAccessor"> > <column name="XWD_WEB" length="255" not-null="true"/> > </property> > > + <property name="space" type="string"> > + <column name="XWD_WEB" length="255" not-null="true"/> > + </property> > + > <property name="content" type="string"> > <column name="XWD_CONTENT" length="200000" not- > null="true" sql-type="clob"/> > </property> > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

1 0

Re: [xwiki-devs] [xwiki-notifications] r10270 - xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium
by Vincent Massol 12 Jun '08

12 Jun '08

On Jun 12, 2008, at 1:53 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 01:53:06 +0200 (Thu, 12 Jun 2008) > New Revision: 10270 > > Modified: > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > Log: > [misc] Added a comment > > > Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ > selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/ > WikiEditorTest.java > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > 2008-06-11 23:51:17 UTC (rev 10269) > +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > 2008-06-11 23:53:06 UTC (rev 10270) > @@ -159,6 +159,9 @@ > // TODO: We need to find out how to make a text selection in > Selenium > } > > + /** > + * See XWIKI-1007 > + */ Personally I don't like referring to JIRA issues like this because: 1) the reader has to navigate to the issue to understand what it is 2) there's the risk that in the future we'll use a tool other than jira So I'd prefer you simply say: "Verify that a document's content can be empty" or if you prefer " Verify that a document's content can be empty (see XWIKI-2007).". My preference for the former. BTW naming the test: testEmptyDocumentContentIsAllowed would be even better :) Thanks -Vincent > public void testEmptyContent() > { > open("/xwiki/bin/edit/Test/EmptyWikiContent?editor=wiki"); > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

1 0

[xwiki-devs] [Reminder] Wednesday Bug Fixing Day tomorrow...
by Vincent Massol 11 Jun '08

11 Jun '08

This is just a reminder. See http://tinyurl.com/5ngsok Thanks -Vincent

1 1

[xwiki-devs] SSO support - status update
by Markus Lanthaler 11 Jun '08

11 Jun '08

Hi guys, I'm currently evaluating possible frameworks to use for my Single Sign On project (SSO). ESOE [1] and OpenSSO [2] both very promising, but both have their pros and cons. I didn't have a detailed look at JOSSO [3] yet. ESOE is licensed under the Apache 2.0 license, supports Shibboleth and OpenID (don't know yet which versions) and has authentication support for LDAP, Active Directory, and many more (comming). It also has support for multi-factor authentication. The downside of ESOE is that there isn't yet any final version available. It also can't act as a OpenID identity provider (OP) and needs an Apache module or IIS filter to act as an SAML provider. OpenSSO on the other hand has full SAML 2.0 support, but lacks a bit regarding OpenID which isn't supported by default. There is an extension which allows OpenSSO to act as a OpenID 1.1 OP, but doesn't have RP support. OpenID is licensed under Sun's Common Development and Distribution License (CDDL). So the next thing I'll do is to dig into JOSSO [3]. Do you know any other framework which I should consider? Regards, Markus -- [1] http://esoeproject.org [2] http://opensso.dev.java.net [3] http://www.josso.org

2 2

[xwiki-devs] [GSOC] [WebDAV] Ground work done.
by Asiri Rathnayake 11 Jun '08

11 Jun '08

Hi All, I think i made a mistake in my last update with the words "test framework". Actually what i meant is the basic environment setup and ground work. specifically, i wanted following things, * A maven project using ludovic's existing code (few modifications were done + a patch to the xwiki-core). * A way to easily build and deploy xwiki-webdav servlet. Now it's simply `mvn jetty:run` (uses hsqldb and a preconfigured database). * A platform independent WebDAV client so that anyone can test xwiki-webdav. Found DAVExplorer. * An eclipse project setup (M2Eclipse) that would allow anyone (that's me) to jump in and develop. I have committed my work (which has everything mentioned above) into http://svn.xwiki.org/svnroot/sandbox/xwiki-webdav/ . I have put a README along with it so that anyone can get started quickly. Btw, ludovic's original code is still available at http://svn.xwiki.org/svnroot/sandbox/webdav/ , should it be left as it is ? Now i will start to enhance xwiki-webdav and to add advanced DAV functionalities along the way. Please feel free to make comments / suggestions, they are always welcome. Thanks. - Asiri

2 3

Re: [xwiki-devs] ntlm with xwiki [END]
by Colin Tay 11 Jun '08

11 Jun '08

Hello, I have managed to authenticate users with the Active directory through LDAP. However, all the users i login were shown the error message "You are not allowed to view this document or perform this action." when i am at http://localhost:8080/xwiki/bin/view/Main/WebHome. I pressume the users records are not in the Xwiki database. Where and how do i create these records when the user first logon onto xwiki? Regards, ----- Original Message ---- From: arnaud <adlz(a)netcourrier.com> To: devs(a)xwiki.org Sent: Thursday, 15 November 2007 2:01:06 Subject: Re: [xwiki-devs] ntlm with xwiki [END] hello FYI it works !! just had to use the createUserFromLdap from Ldap plugin class now user are recognized by xwiki and authenticated by ntlm! At last! ----Message d'origine---- >Date: Mon, 12 Nov 2007 22:20:27 +0100 (CET) >De: "Jerome Velociter" <jerome(a)xwiki.com> >A: "XWiki Developers" <devs(a)xwiki.org> >Sujet: Re: [xwiki-devs] ntlm with xwiki > >Hi Arnaud, > >As far as your problem, I can't really help you much as I've never >experimented custom auth. I don't know how LDAP binds the users to actual >XWiki users, but I suppose for this to work, you should at some point feed >XWikiUsers documents/objects with data from LDAP. (since LDAPAuthImpl is >only auth, maybe there is something else needed). >Maybe you can ask this on the users list, as it is both more of a user >issue, and you could get insights from those who actually use LDAP >auth/user management. > >Good luck with this, >Jérôme. > >> >> hi again >> >> very sorry to disturbing you once again >> >> i saw that i can get request from wikicontext >> so in my own auth class i can get my user >> no longer need a servlet to send user to the login form >> great everything is fine BUT >> >> first: i still have "you are not allowed to view this document ...." when >> the user log in >> >> >> second : i can't log out >> >> problem look like xwiki don't know my user >> (in my AuthImpl i did all that it's found in LDAPAuthImpl...) >> >> sorry again >> (BTW if it's not the right place to ask this kind of questions, tell me, >> no problem...) >> >> >> >> >> >> >> >> >> >> >> >> ----Message d'origine---- >>>Date: Sat, 10 Nov 2007 23:19:23 +0100 (CET) >>>De: "Jerome Velociter" <jerome(a)xwiki.com> >>>A: "XWiki Developers" <devs(a)xwiki.org> >>>Copie à: devs(a)xwiki.org >>>Sujet: Re: [xwiki-devs] ntlm with xwiki >>> >>>Hello, >>>> >>>> First of all Sorry for creating a new topic >>>> >>>> thanks for your anwser Jerome. >>>> >>>> but Actually i have seen this feature >>>> >>>> i added jcifs and it works well >>>> an other hand i have tested impletentetion for ldap its works too >>>> >>>> but i want a transparent authentication >>>> so now the problem is : >>>> >>>> i would like to not have form login >>>> i saw in code that we can define our login page with this property in >>>> xwiki.cfg : >>>> xwiki.authentication.loginpage (if null default is >>>> /bin/login/XWiki/XWikiLogin) >>>> >>>> i've changed this property but no changes when template call >>>> >>>> $xwiki.getURL("XWiki.XWikiLogin", "login", "xredirect=$logredir")) >>>> >>>> i still got the same url : bin/login/XWiki/XWikiLogin? >>> >>>Actually, it's the expected behavior : the call asks for the URL of the >>>XWiki.XWikiLogin document, under the login action and with a xredirect >>>query string parameter. If you changed your authentication login page to >>>XWiki.MyCustomLogin in the conf, the calls to login URL should ask for >>>that document IMO. Also, you may have to modidy a bit the skin if you >>> want >>>the users to be redirected to the proper login page any case. If you are >>>using albatross skin, you can look over global.vm and login.vm, there is >>>also the header.vm file in the webapp/templates folder that calls for the >>>login URL. >>> >>>Hope it's clear enough, as I'm not sure what you exactly want to do (In >>>particuliar, I don't understand why you wany to post username to >>>loginsubmit action, since you use third-party authentication). >>> >>>Tell us how it goes. >>> >>>Regards, >>>Jerome. >>> >>>> >>>> >>>> the purpose of that is log-in link goes to my servlet , then i do ntlm >>>> authentication (it already works), then i post user name to >>>> /xwiki/bin/loginsubmit/XWiki/XWikiLogin >>>> >>>> in the same time i do my own version of authentification (get user info >>>> (name mail,etc...) from another ldap without test of password cos >>>> already >>>> done with ntlm) >>>> >>>> >>>> So! how can i redirect log-in page ? thanks a lot >>>> >>>> ------------------------------------------------------------ >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> Hi, >>>> >>>> You can implement your own version of the >>>> com.xpn.xwiki.user.api.XWikiAuthService interface. >>>> >>>> There's already a LDAP impl existing (different from the XWiki default >>>> one), so you can look over that too as an example. >>>> >>>> Then, you must precise in the xwiki.cfg configuration file that you >>>> want >>>> to use your own class, with something like >>>> >>>> xwiki.authentication.authclass = >>>> com.mycompany.mypackage.MyXWikiAuthImpl >>>> >>>> Regards, >>>> Jerome. >>>> >>>> _______________________________________________ >>>> devs mailing list >>>> devs(a)xwiki.org >>>> http://lists.xwiki.org/mailman/listinfo/devs >>>> >>> >>> >>>_______________________________________________ >>>devs mailing list >>>devs(a)xwiki.org >>>http://lists.xwiki.org/mailman/listinfo/devs >>> >> >> _______________________________________________ >> devs mailing list >> devs(a)xwiki.org >> http://lists.xwiki.org/mailman/listinfo/devs >> > > >_______________________________________________ >devs mailing list >devs(a)xwiki.org >http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs __________________________________ Yahoo! Movies - Search movie info and celeb profiles and photos. http://sg.movies.yahoo.com/

2 1

Re: [xwiki-devs] New Administration Status & Implementation
by Vincent Massol 11 Jun '08

11 Jun '08

On Jun 11, 2008, at 9:08 AM, Evelina Slatineanu wrote: > Hi devs, > > > > I've updated > http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministration > with > the status and current implementation of the new administration app. > Please > review it and provide comments and suggestions before I make the first > patch. The css stylesheet are in development, so are the selenium > tests. > There is also a small but I couldn't fix so far, althouth I have a > workaround in mind. Hi Evelina, Can we seem a demo? That would be the best for us to provide feedback. right now what you've updated is very technical and hard for anyone to comment on. Thanks -Vincent

1 0