August 2009 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Branch trunk for 2.0 release so that we can start work for 2.1
by Vincent Massol 26 Aug '09

26 Aug '09

Hi, I'd like to branch platform/core, web and enterprise/ so that we can start working on 2.1. I'd like to be able make commits for 2.1 that shouldn't go in 2.0 (they're too dangerous). Here's my +1 Thanks -Vincent

3 2

[xwiki-devs] [VOTE] Release XWiki Enterprise 2.0M4
by Thomas Mortagne 26 Aug '09

26 Aug '09

Hi, I would like to release what was planned as a RC1 as a Milestone 4 now to release something and since there is some remaining issues in it. Among other things, this release contains: - first final and automatically tested version of remote observation manager and support of new observation manager instead of old notification system - new colibri skin - first introduction of activity stream plugin - refactor of the watchlist based on activity stream to greatly improve speed - new macros categories Here is my +1 Thanks, -- Thomas Mortagne

7 7

Re: [xwiki-devs] [xwiki-notifications] r22950 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/notify
by Vincent Massol 26 Aug '09

26 Aug '09

Some questions: 1) I thought this notify package was going to be removed since all the code was updated to use the new observation module? 2) Why do you do the protection inside the rule instead of inside the Notification Manager. Funnily I had put a TODO comment 2 days ago there exactly for this... ;) Thanks -Vincent On Aug 26, 2009, at 5:04 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-08-26 17:04:31 +0200 (Wed, 26 Aug 2009) > New Revision: 22950 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/notify/ > DocChangeRule.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/notify/ > XWikiActionRule.java > Log: > XWIKI-4238: Nofification system should protectd itself from bad > listeners > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > notify/DocChangeRule.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > notify/DocChangeRule.java 2009-08-26 15:04:15 UTC (rev 22949) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > notify/DocChangeRule.java 2009-08-26 15:04:31 UTC (rev 22950) > @@ -21,12 +21,17 @@ > > package com.xpn.xwiki.notify; > > +import org.apache.commons.logging.Log; > +import org.apache.commons.logging.LogFactory; > + > import com.xpn.xwiki.XWikiContext; > import com.xpn.xwiki.doc.XWikiDocument; > > @Deprecated > public class DocChangeRule implements XWikiNotificationRule > { > + protected static final Log LOG = > LogFactory.getLog(DocChangeRule.class); > + > private XWikiDocChangeNotificationInterface target; > > private boolean preverify = false; > @@ -71,7 +76,13 @@ > return; > } > > - getTarget().notify(this, newdoc, olddoc, > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + try { > + getTarget().notify(this, newdoc, olddoc, > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + } catch (Exception e) { > + // protect from bad listeners > + LOG.error("Fail to notify target [" + getTarget() + "] > for event [" + this + ", newdoc=" + newdoc > + + ", olddoc=" + olddoc + "]", e); > + } > } > > /** > @@ -86,7 +97,13 @@ > return; > } > > - getTarget().notify(this, newdoc, olddoc, > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + try { > + getTarget().notify(this, newdoc, olddoc, > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + } catch (Exception e) { > + // protect from bad listeners > + LOG.error("Fail to notify target [" + getTarget() + "] > for pre event [" + this + ", newdoc=" + newdoc > + + ", olddoc=" + olddoc + "]", e); > + } > } > > /** > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > notify/XWikiActionRule.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > notify/XWikiActionRule.java 2009-08-26 15:04:15 UTC (rev 22949) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > notify/XWikiActionRule.java 2009-08-26 15:04:31 UTC (rev 22950) > @@ -21,12 +21,17 @@ > > package com.xpn.xwiki.notify; > > +import org.apache.commons.logging.Log; > +import org.apache.commons.logging.LogFactory; > + > import com.xpn.xwiki.XWikiContext; > import com.xpn.xwiki.doc.XWikiDocument; > > @Deprecated > public class XWikiActionRule implements XWikiNotificationRule > { > + protected static final Log LOG = > LogFactory.getLog(XWikiActionRule.class); > + > private XWikiActionNotificationInterface target; > > private boolean preverify = false; > @@ -74,9 +79,9 @@ > try { > getTarget().notify(this, doc, action, context); > } catch (Throwable e) { > - // Notification should never fail > - // Just report an error > - e.printStackTrace(); > + // protect from bad listeners > + LOG.error("Fail to notify target [" + getTarget() + "] > for event [" + this + ", doc=" + doc + ", action=" > + + action + "]", e); > } > } > > @@ -87,9 +92,9 @@ > try { > getTarget().notify(this, doc, action, context); > } catch (Throwable e) { > - // Notification should never fail > - // Just report an error > - e.printStackTrace(); > + // protect from bad listeners > + LOG.error("Fail to notify target [" + getTarget() + "] > for pre event [" + this + ", doc=" + doc > + + ", action=" + action + "]", e); > } > }

2 1

[xwiki-devs] Feeds page in default XE + no UI for getting the global RSS feed
by Vincent Massol 26 Aug '09

26 Aug '09

Hi, Problem 1 ======== We need to decide what we do with http://localhost:8080/xwiki/bin/view/Main/RssFeeds I thought it was useful but it's not linked anymore from anywhere. Problem 2 ======== On the Blog home there's no way to easily get the Blog RSS feed. The category panel only allows to get feeds for a given category. Any ideas? Thanks -Vincent

3 5

[xwiki-devs] Interesting idea of i18N: CAI18N
by Vincent Massol 26 Aug '09

26 Aug '09

http://cai18n.qos.ch/manual.html Advantage: typed keys. Thanks -Vincent

1 0

Re: [xwiki-devs] [xwiki-notifications] r22920 - in platform/skins/trunk: . colibri colibri/src colibri/src/assemble colibri/src/main colibri/src/main/resources colibri/src/main/resources/colibri
by Vincent Massol 26 Aug '09

26 Aug '09

Hi Sergiu, You've been busy :) Wow lots of vms. Won't we have problems maintaining (ie keep in sync) all the vms from templates + toucan + colibri? Also isn't the idea to have only vm files in templates as much as possible? (maybe this is just a temporary step?) Thanks -Vincent On Aug 26, 2009, at 8:59 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2009-08-26 08:59:24 +0200 (Wed, 26 Aug 2009) > New Revision: 22920 > > Added: > platform/skins/trunk/colibri/ > platform/skins/trunk/colibri/pom.xml > platform/skins/trunk/colibri/src/ > platform/skins/trunk/colibri/src/assemble/ > platform/skins/trunk/colibri/src/assemble/skin.xml > platform/skins/trunk/colibri/src/main/ > platform/skins/trunk/colibri/src/main/resources/ > platform/skins/trunk/colibri/src/main/resources/colibri/ > platform/skins/trunk/colibri/src/main/resources/colibri/ > accessdenied.vm > platform/skins/trunk/colibri/src/main/resources/colibri/admin.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > attachments.vm > platform/skins/trunk/colibri/src/main/resources/colibri/captcha.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > changemyavatar.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > changesall.vm > platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css > platform/skins/trunk/colibri/src/main/resources/colibri/comments.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > contentview.vm > platform/skins/trunk/colibri/src/main/resources/colibri/copy.vm > platform/skins/trunk/colibri/src/main/resources/colibri/delete.vm > platform/skins/trunk/colibri/src/main/resources/colibri/deleted.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > deleteversionsconfirm.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > docalreadyexists.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > docdoesnotexist.vm > platform/skins/trunk/colibri/src/main/resources/colibri/docextra.vm > platform/skins/trunk/colibri/src/main/resources/colibri/edit.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > edithistory.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > editinline.vm > platform/skins/trunk/colibri/src/main/resources/colibri/editmodes.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > editpanelsvars.vm > platform/skins/trunk/colibri/src/main/resources/colibri/exception.vm > platform/skins/trunk/colibri/src/main/resources/colibri/global.vm > platform/skins/trunk/colibri/src/main/resources/colibri/header.vm > platform/skins/trunk/colibri/src/main/resources/colibri/hierarchy.vm > platform/skins/trunk/colibri/src/main/resources/colibri/history.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > historyinline.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ie.css > platform/skins/trunk/colibri/src/main/resources/colibri/ > information.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > informationinline.vm > platform/skins/trunk/colibri/src/main/resources/colibri/login.vm > platform/skins/trunk/colibri/src/main/resources/colibri/logo.png > platform/skins/trunk/colibri/src/main/resources/colibri/menuview.vm > platform/skins/trunk/colibri/src/main/resources/colibri/message.vm > platform/skins/trunk/colibri/src/main/resources/colibri/passwd.vm > platform/skins/trunk/colibri/src/main/resources/colibri/preview.vm > platform/skins/trunk/colibri/src/main/resources/colibri/register.vm > platform/skins/trunk/colibri/src/main/resources/colibri/rename.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > resetversions.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > resetversionsdone.vm > platform/skins/trunk/colibri/src/main/resources/colibri/shortcuts.vm > platform/skins/trunk/colibri/src/main/resources/colibri/style.css > platform/skins/trunk/colibri/src/main/resources/colibri/ > templatedoesnotexist.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > userinactive.vm > platform/skins/trunk/colibri/src/main/resources/colibri/view.vm > platform/skins/trunk/colibri/src/main/resources/colibri/ > viewattachrev.vm > Modified: > platform/skins/trunk/pom.xml > Log: > XSCOLIBRI-1: Initial version > Done. >

2 1

[xwiki-devs] ParseGroovyFromPage and XWiki Syntax 2.0
by Vincent Massol 26 Aug '09

26 Aug '09

Hi, I've seen some IRC discussion about this yesterday. We need to decide what's the canonical way of doing it in 2.0: Here's the idea that I currently have: Step 1(works today) * Use syntax = plain/1.0 to write the groovy page (you can remove the / * #* */ hack) * Use $xwiki.parseGroovyFromPage() Step 2 (future) * Same as solution 1 but in addition use the future Document Type to type the groovy page as a "Groovy Class Page", which means we could offer a default stylesheet for it that would underneath use the {{code language="groovy"}} macro to color it for example + add some info at the top explaining why this page exists. Step 3 (future) * Deprecate the $xwiki.parseGroovyFromPage() api to move it to a proper place, either in the script module (if it can be generified for all scripting languages) or in script-groovy submodule of xwiki-script and accessed through the new Services proposal (see http://markmail.org/thread/g4z56pl734lng2ym ). WDYT? Thanks -Vincent

1 0

[xwiki-devs] JBoss HornetQ
by Vincent Massol 26 Aug '09

26 Aug '09

Just noticed this project http://www.infoq.com/news/2009/08/hornetq And wondered if if could be useful for us, especially for the distributed event part. Anyway this is mostly a FYI message. Thanks -Vincent

1 0

[xwiki-devs] JBoss HornetQ
by Vincent Massol 26 Aug '09

26 Aug '09

Just noticed this project http://www.infoq.com/news/2009/08/hornetq And wondered if if could be useful for us, especially for the distributed event part. Anyway this is mostly a FYI message. Thanks -Vincent

1 0

[xwiki-devs] [Colibri Skin] [Proposal] Move Jump action
by Ecaterina Valica 25 Aug '09

25 Aug '09

Hi, I was talking to Marta and we came across the "Jump" action (*Jump to any page in the wiki (Meta+G)*) The problem is that it has low visibility and it's not well placed in the "Quick Links" panel. *A.* First solution - make a "Keyboard Shortcuts" panel with different shortcuts taken from http://platform.xwiki.org/xwiki/bin/view/Features/KeyboardShortcuts But (Meta+G) is still operating system dependent and with an advanced user target. *B. *How about we put it near the Search input, in the right corner? You can see a mockup at http://incubator.myxwiki.org/xwiki/bin/download/Improvements/Skin20P1/jump.… This will be not the final version of the UI for the jump, but just to get the point. Thanks, Caty

4 5